Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp618648ybz;
        Wed, 15 Apr 2020 15:15:15 -0700 (PDT)
X-Google-Smtp-Source: APiQypLt71xRCJPA/2j+/uBe+9eajJ8M4BKvlbqtuYNs+dfojpnQH8/+bEM445iXkI5U2RoGQzyW
X-Received: by 2002:a17:907:20b5:: with SMTP id pw21mr6711817ejb.227.1586988915767;
        Wed, 15 Apr 2020 15:15:15 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1586988915; cv=none;
        d=google.com; s=arc-20160816;
        b=XGF/NoUkxWoY1x+V6lnhwuNVXRhRg6LSN0CX9Nd0bs6i3afEP5LygVY+tWaOBemboj
         uXLmLtXQcDWWd9psWTpqIQxdaoNunp/83evWKcZ5imXAkFhYO77/nf+PRLZRRRqjuRKO
         UHzeDeKxsBUPWmV9fydndqLmkD3RzkFMZb84r0khfQCbbJfpFKfYKnVuJy+1Sebg4u/n
         lYM8bzlE7Kh2bTI1co7ftcvnhe7I++0PwIf4pRrjaEYEuwcsfetWiFO4TSz65XP15ckl
         cG7QvBgNpp8uP5za1cynwKJxfubicVO9FYgUndKW/aUEtwpsBoONSpR5N2gtKQmhI6e6
         kLXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-disposition:mime-version
         :message-id:subject:cc:to:from:date;
        bh=YAjVwOW5+MAEVGUZITzA9KP2ft9GY7dJC9IkrG7J3Iw=;
        b=EathUHt0qOQsJT4CfQoLoh5AARa8ozmMncqejF4nluLA+suwha8LvcchAMtoENHzbC
         5dkXtsKCl4NaglQnUsv1S9T5Dbx0A/I16zQW2K+GObwHQRIBUppk3e+3MeHltKqpek7G
         AGkgCQsQGr3HdHeDSZQ/UmSGvzv/yvjt0KjHsP2UMVNyI0CarkAAYkqGPqGEMuAIGvAp
         O67rf6FV7f9h2RIRCB9eqINa3gCe1odIMs/kORsP38OL6EvZPFiKWIZO6KHtQVNWKxZ/
         VaCL+bqs3naCeJWixaoqq27Pnv3MmBjiAI8ysqjZvP7kpbnmZWhIGOeuWK0V1lYyIehe
         mDtQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id pk26si7082473ejb.404.2020.04.15.15.14.52;
        Wed, 15 Apr 2020 15:15:15 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2404086AbgDOHCh (ORCPT <rfc822;utfcpqpk@gmail.com> + 99 others);
        Wed, 15 Apr 2020 03:02:37 -0400
Received: from mail-wm1-f66.google.com ([209.85.128.66]:35745 "EHLO
        mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2404013AbgDOHCc (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 15 Apr 2020 03:02:32 -0400
Received: by mail-wm1-f66.google.com with SMTP id r26so17594628wmh.0;
        Wed, 15 Apr 2020 00:02:31 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version
         :content-disposition;
        bh=YAjVwOW5+MAEVGUZITzA9KP2ft9GY7dJC9IkrG7J3Iw=;
        b=iZ3YliEPxi5ut2pMzERRZSOJI3M/K/V/egj45+oVUOFg4yZO0nhOi/O2MT1P+1izGa
         U4+vS6UE0jbQFKsU9YMr272UwRN4bMrwhd3jdHnry0kL7nFNKW2RwjfiXFOGEc7w/vhY
         r8RsyFewOmGQDXoUlOGsHqCl3nVIhb0ufWI1svBh7IQQ93Pujj3FOKTyVGhyGmEzMXYe
         OVenb5xHf0g8bwLDAR9iiuy0ZRuKPDKsYjZZ5ai/KPNiUdm0ui4yiMCjiHRudjPeFlCm
         9c71TBTDMq9QsQuccZOJa5Il8TRnGH0+/MvuaZHtn8mv8tkHs5lKc5ixUfTQnMAGmOl2
         XKFg==
X-Gm-Message-State: AGi0Pubw/H9OvbixtJUhLc59UfCFIiXpFPvvUakBKFi587q7yNSR501l
        kNArw7tYypGEk11OpXsxnXc=
X-Received: by 2002:a7b:c401:: with SMTP id k1mr3551702wmi.152.1586934150877;
        Wed, 15 Apr 2020 00:02:30 -0700 (PDT)
Received: from localhost (ip-37-188-180-223.eurotel.cz. [37.188.180.223])
        by smtp.gmail.com with ESMTPSA id g6sm2960436wrw.34.2020.04.15.00.02.29
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Wed, 15 Apr 2020 00:02:30 -0700 (PDT)
Date:   Wed, 15 Apr 2020 09:02:28 +0200
From:   Michal Hocko <mhocko@kernel.org>
To:     Christoph Hellwig <hch@infradead.org>,
        "Darrick J. Wong" <darrick.wong@oracle.com>
Cc:     linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>
Subject: implicit AOP_FLAG_NOFS for grab_cache_page_write_begin
Message-ID: <20200415070228.GW4629@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,
I have just received a bug report about memcg OOM [1]. The underlying
issue is memcg specific but the stack trace made me look at the write(2)
patch and I have noticed that iomap_write_begin enforces AOP_FLAG_NOFS
which means that all the page cache that has to be allocated is
GFP_NOFS. What is the reason for this? Do all filesystems really need
the reclaim protection? I was hoping that those filesystems which really
need NOFS context would be using the scope API
(memalloc_nofs_{save,restore}.

Could you clarify please?

[1] http://lkml.kernel.org/r/20200414212558.58eaab4de2ecf864eaa87e5d@linux-foundation.org
-- 
Michal Hocko
SUSE Labs