Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.60.83 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01;
Subject: Re: [PATCH] firmware: xilinx: make firmware_debugfs_root static
To:     Jason Yan <yanaijie@huawei.com>, michal.simek@xilinx.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     Hulk Robot <hulkci@huawei.com>
References: <20200415084311.24857-1-yanaijie@huawei.com>
From:   Michal Simek <michal.simek@xilinx.com>
Message-ID: <d17ad4d4-43a7-8cab-bbdd-f63d425a0abc@xilinx.com>
Date:   Wed, 15 Apr 2020 10:25:14 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <20200415084311.24857-1-yanaijie@huawei.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2020 08:25:21.6801
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e73f183-496e-4922-09bf-08d7e11689fe
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR02MB7044
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 15. 04. 20 10:43, Jason Yan wrote:
> Fix the following sparse warning:
> 
> drivers/firmware/xilinx/zynqmp-debug.c:38:15: warning: symbol
> 'firmware_debugfs_root' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/firmware/xilinx/zynqmp-debug.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/xilinx/zynqmp-debug.c b/drivers/firmware/xilinx/zynqmp-debug.c
> index c6d0724da4db..43bc6cfdab45 100644
> --- a/drivers/firmware/xilinx/zynqmp-debug.c
> +++ b/drivers/firmware/xilinx/zynqmp-debug.c
> @@ -35,7 +35,7 @@ static struct pm_api_info pm_api_list[] = {
>  	PM_API(PM_QUERY_DATA),
>  };
>  
> -struct dentry *firmware_debugfs_root;
> +static struct dentry *firmware_debugfs_root;
>  
>  /**
>   * zynqmp_pm_argument_value() - Extract argument value from a PM-API request
> 

Applied.

Thanks,
Michal