Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp632380ybz; Wed, 15 Apr 2020 15:33:08 -0700 (PDT) X-Google-Smtp-Source: APiQypJ0RGEbG82KsjLbDNwo1Z2g+8MnwKFMZVpvHKx3oKZjet8nE4XiV/OmB5ls1sKDOvEFnNKJ X-Received: by 2002:a17:906:1ccb:: with SMTP id i11mr7066291ejh.101.1586989988045; Wed, 15 Apr 2020 15:33:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586989988; cv=none; d=google.com; s=arc-20160816; b=VkB+VOmbQt1VHReSnWe5+F+cEjUs94vaNlSgEl3YFl8p2HfQmPgmlSWrYDL0vtY7sf W4K+Bc+jIg1xG/9QP1YN+w8Cv3cgprGZVR+EsuoC9yGjfzp35rf2jl6OCfaBbzXst8Lq aQ8T3rvPEW654p4CKnv0z75JGeE1DaDT6g0xq8zm/JaRXhVjBA8r0+1v8skhaR0Jg1wr EtteopoZhhs9UYVkdwjMRgpJEkeBcObvir2HOd4+PbP8VNI0/ei81yUcopPySmMvAc56 e4OsoXsicgI/jrHglUZUZe3MoRqyOZZp+gGJQKUv6zooW0/i+H11zQu8t7cAV8HCvYpy eELg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=zdw6tgQaWHCsQ/jM5eMhbMqcSRitvrYHIiq91eMiHBw=; b=cRznHpVG0H6cqtV4NC6glUqs2KbT4EQk8+oojx5OZNWmTaQjbpvxKYIL0cTVsowjjS ZTIjnHpeKgdnqJvP2beGvE2/OmtlbcCyPVxMdmJqHZPPMesdkTzXLTerej6n50PPN1OD xs4jrZ+GA8W+mZqmB5iVGki+7Z8F2l36a2OJCTTMwNv0x3awCyQd0gRu/SQGZLXw6+oX 5tbSj5M+TAZ6eY0q+F7OrWrY7YvzEu+GF+3YMFPAqcubFFWx7uRiF4Sru60PFriIpsVU /3o5ChPt61yviBwhgM3nvNY4mVEXk39qBmCA6Mf5gw4m/r8IyWP/kPFTeSmCDp6lOJz1 K68g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGM9sA8D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q4si11716279edh.273.2020.04.15.15.32.44; Wed, 15 Apr 2020 15:33:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=vGM9sA8D; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2894399AbgDOIXr (ORCPT + 99 others); Wed, 15 Apr 2020 04:23:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:43572 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2635898AbgDOIXi (ORCPT ); Wed, 15 Apr 2020 04:23:38 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 803C520784; Wed, 15 Apr 2020 08:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1586939018; bh=0kpxY7WRGFbm5Qwfk/sr8dvg3Yio8hbJ+U8aY4ogpnA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=vGM9sA8DLqJS/QtEocHEqn/OvB/TI8TVm/SPdYRlIaKnHqtE4vOYZjexduuu5974c hrpTnb4L2dDtN9i58/NQOYkv28mC7SPW0RuV8+EGtecJ3NngVYWdwaUqcYn8W2m3+S 2bvaxNKzZCBZfN/N9RLXRcbMvBWXMf7Jly+QPEa0= Date: Wed, 15 Apr 2020 17:23:31 +0900 From: Masami Hiramatsu To: Masami Hiramatsu Cc: Peter Zijlstra , Christian =?UTF-8?B?S8O2bmln?= , Jann Horn , Harry Wentland , Leo Li , amd-gfx@lists.freedesktop.org, Alex Deucher , David Zhou , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , the arch/x86 maintainers , kernel list , Josh Poimboeuf , Andy Lutomirski , Arnaldo Carvalho de Melo Subject: Re: [PATCH v3] x86: insn: Add insn_is_fpu() Message-Id: <20200415172331.96807c231956f3a7255b0202@kernel.org> In-Reply-To: <158648174982.1073.6608148826246795028.stgit@devnote2> References: <20200409143212.GW20696@hirez.programming.kicks-ass.net> <158648174982.1073.6608148826246795028.stgit@devnote2> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Apr 2020 10:22:30 +0900 Masami Hiramatsu wrote: > @@ -318,10 +331,14 @@ function convert_operands(count,opnd, i,j,imm,mod) > if (match(opcode, rex_expr)) > flags = add_flags(flags, "INAT_MAKE_PREFIX(INAT_PFX_REX)") > > - # check coprocessor escape : TODO > - if (match(opcode, fpu_expr)) > + # x87 escape opcode needs MODRM > + if (match(ext, x87_expr)) Oops, it must be match(opcode, x87_expr). I'll fix it. Thanks, -- Masami Hiramatsu