Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp639221ybz; Wed, 15 Apr 2020 15:42:50 -0700 (PDT) X-Google-Smtp-Source: APiQypKHQ6xPK6rfQgJW2ZsJ59Wh62MumwgLQSspTGSqw8jtVlfh909ov49r+TAW6R/8yiKkTA2C X-Received: by 2002:aa7:c6c9:: with SMTP id b9mr932005eds.5.1586990570178; Wed, 15 Apr 2020 15:42:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586990570; cv=none; d=google.com; s=arc-20160816; b=0HGw29vSTjG1EFJeXvazLGufAw4F9cvJMjUz1kD5AWMpblR6EmzNkUhVp2lqQkEgRm d2UwOFldTt2oR+EEfTA60uAxvXMrcvT7vmFnFJIeqshRF510IDO8aHz/8P91Ocu79PNS IhorIUOaQU74TFKSKoerBjsRq12+ABjl1OY+/0KBKOhB1jwL95703Y2w1gKGJ3XK09vP FsHsmF3ZUon7n927bUdmRC305qXOFhdkPniX/lfl6ZBmdoyDwQPgVBPdRaB5zyJyugUo ByP1xa6qxB5LoRKhgYEcJA60Oi9OPzSzc/3ianv60y44B0YlO2AmigNMC7VZKIZIUBuM mk6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=GffN4wdV1b8/+GP7bB7msfOG3SsTk4D9FpQBELdB7UQ=; b=PfwF1afO03B35V/G7RBnlTR9LDv7ALNta7KpLKFDG56tlvEDXjktjst3uJT5j9Y4Xi wFZYjReR8Yh+V+7qRlV8QUEulZ0nnNg0zuJUsL68kOJ2EDJ4pAm1YIaJUuot1z89BB37 HeoatUkGKyCGP75M/YJamD7nzSwIIrHwqwI9EoGDQ7+/aynXS1BklPK901r5Di9OA3tv CZau/KcrI1ml8yG0Mp1wEhzfnCWkhsKFshBa0Ee1TOPfilENTlVAuyBYm4vzk7+NWy4F 3aiYV2JQlyHNiUr/N03OjJP+8S3aojW9sgEFlL2encRJRU+SBGlYlD+2d+j3AoQaJGmg s2Wg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ut9RWSaO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v11si1747919edq.225.2020.04.15.15.42.26; Wed, 15 Apr 2020 15:42:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Ut9RWSaO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895175AbgDOIxB (ORCPT + 99 others); Wed, 15 Apr 2020 04:53:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2895164AbgDOIwr (ORCPT ); Wed, 15 Apr 2020 04:52:47 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 535E7C061A0E for ; Wed, 15 Apr 2020 01:52:47 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id 21so1045333uae.4 for ; Wed, 15 Apr 2020 01:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=GffN4wdV1b8/+GP7bB7msfOG3SsTk4D9FpQBELdB7UQ=; b=Ut9RWSaOq1yupMZbWU33o+RQiJm1VcNInX3xL0Qg2Yu12twvk6t/92Wf0Py1JaXBW7 seiwUhSnzZDeqIFK/o6vdQ1KzM/lWT9y7RRQNWbGx64yLdbrPQxDTAnsOWWnqXGKMOLL GxFZhp0BptUY2s68S0lWCLTgEsrSz3e0BRd8KcU7xFSdUMqzK1yrr+JlURONDWZBNJZq w1+L9MVjy0l/BwMUarAgZKemDe7WXlv7abAiHz9Kl9N7XQ5JE8Hcjk59ti4cK4THNy9D HnotyGjdAwHUGgJi+IjmHnkpf/cHvijf63dA3kf0GXIeof5uub5vU+szxsj3JT1mQVlA 65jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=GffN4wdV1b8/+GP7bB7msfOG3SsTk4D9FpQBELdB7UQ=; b=j9qGZaRj7CP2UumH6y8gonllVaxfSRddt5v961sjEXZXz+mvVU/Mrz+XctB8JLE2PS gnAWW9tlwgxOZyNNb6Jq6hMAd0TAiwdqgks3HzL2in5Zv8nOWUeNs9//C3sVeoSAYQpD 4FYXOuuvtEx7kSmGqOX2zX+Pn/eKZCzFJvPHlzi1S3KIFEqcjZX5TMj9EvAwqOKUbvUS 7/UT/ehPox9lYIKkomuPc6cZYq9YjNEIXiU0/lnT3otjHUQuNPeKHqkLKylogVKAEeRN s2MW0hDqEEHB0EofOrz3fJUOW+shwdNzuziB4NVyaAzUKVzBJqIwm++wyv1WErAn1PMu zGWQ== X-Gm-Message-State: AGi0PuZQPAFlzcBqzZhhPxB5wAgeZeb9UW7tSuuqP+VIdigySqLmCeS0 crffeMOxc4CxwOfgHvQi8ghfFFqQBbEfPlYGXLliRw== X-Received: by 2002:a9f:20c6:: with SMTP id 64mr3823674uaa.100.1586940766283; Wed, 15 Apr 2020 01:52:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ulf Hansson Date: Wed, 15 Apr 2020 10:52:10 +0200 Message-ID: Subject: Re: [PATCH 0/7] SDHCI clock handling fixes and cleanups To: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Adrian Hunter Cc: Kevin Liu , Michal Simek , Suneel Garapati , Linux Kernel Mailing List , "linux-mmc@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2 Apr 2020 at 13:54, Micha=C5=82 Miros=C5=82aw wrote: > > This patch set combines a few of code improvements for SDHCI clock handli= ng. > Besides small fixes, most value comes from simplifying the code, so it's > easier to understand. > > Micha=C5=82 Miros=C5=82aw (7): > mmc: sdhci: fix base clock usage in preset value > mmc: sdhci: fix programmable clock config from preset value > mmc: sdhci: fix SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN > mmc: sdhci: move SDHCI_QUIRK2_CLOCK_DIV_ZERO_BROKEN frequency limit > mmc: sdhci: simplify clock frequency calculation > mmc: sdhci: squash v2/v3+ clock calculation differences > mmc: sdhci: respect non-zero div quirk in programmable clock mode > > drivers/mmc/host/sdhci-of-arasan.c | 7 +- > drivers/mmc/host/sdhci.c | 126 +++++++++++++---------------- > drivers/mmc/host/sdhci.h | 4 +- > 3 files changed, 64 insertions(+), 73 deletions(-) > > -- > 2.20.1 > Adrian, whenever you get the time, I would like to get your feedback on these, especially on patch1->patch3 as those may be targeted for fixes. Kind regards Uffe