Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp640908ybz; Wed, 15 Apr 2020 15:45:12 -0700 (PDT) X-Google-Smtp-Source: APiQypLuFIC2gwxMu5iO8AdW9nEvVt+e5jA4OdDQ4qzp870gbU8YGyLn8rmJdAcE++w09u3xHedT X-Received: by 2002:a50:85c4:: with SMTP id q4mr25553933edh.147.1586990712668; Wed, 15 Apr 2020 15:45:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586990712; cv=none; d=google.com; s=arc-20160816; b=1FIodbMhc7beYOvGZ+rVPA/qTSpec5h1LaMCZ3JNxhcd5P5q8Bjj1fHtt6JTb7TiTL bpq4km2peCn8UmV7PalrWt/qvIXifiD/XK+sb17xrUbsKMeEdWnSvvP8EvCyGdAjOQBg hIIFxAZrNearpgqMOp49XVPHU+0CgMQYWsUaJfCq3XJAuxXt/xCzhZFJmV6zHCJG88xX C+GcR8n4Nt6OonU0uDuRPnY2hLBtblJSrEquGf4M8Jek1pV/DhB1kqsHmJ2bYgoYc/tT t7gAn1MsusboghXrpe5/T2PQHHjoQnYiTKxwxRsLfUcEA54Fm2K2W4NPjocYWE92avba 7zMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=nJSsEbdbEgPFXfNxljKZTWiPY2PJQ70NQ5ROhMlcdC0=; b=DzNswOGeJg7YN0tM9l7/OOnEv1ZL45nHIvY94Ekj7HWYQEKoJFpxffnW7TVhPMSQgp L9x5E4OACABgbcBfJNxnPhOsZnxAzxqNglmamjPWmjkzelGxbtssFCyMC6YsZTMeXAMx OdRQYTg7P5uCqOSASEerELrHNP8rOBTv38G+4GITdzNBWFGcKiMma3RDV2BpyVXGA4rf oMJWa0GY07hpfJvHU8OL+y2ds7sAkbs4D+5V3MIn4rI1oTMdjf+ybl86wqkvBeFvf/5U jS+4MbsyTRJSsdK/TgmXncgOSNKSc4sgI8U2t7klJ84wNJuYM0/0K2vGjcGGl6JBkXdK 2ing== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fx19si2906666ejb.39.2020.04.15.15.44.49; Wed, 15 Apr 2020 15:45:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408370AbgDOJMU (ORCPT + 99 others); Wed, 15 Apr 2020 05:12:20 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:39052 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2408347AbgDOJMK (ORCPT ); Wed, 15 Apr 2020 05:12:10 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 1E9E24F0DF89DDA865DB; Wed, 15 Apr 2020 17:12:06 +0800 (CST) Received: from huawei.com (10.175.124.28) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.487.0; Wed, 15 Apr 2020 17:11:59 +0800 From: Jason Yan To: , , , , , , CC: Jason Yan , Hulk Robot Subject: [PATCH 1/3] scsi: fnic: make some symbols static Date: Wed, 15 Apr 2020 17:38:07 +0800 Message-ID: <20200415093809.9365-1-yanaijie@huawei.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.124.28] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following sparse warning: drivers/scsi/fnic/vnic_dev.c:257:5: warning: symbol 'vnic_dev_cmd1' was not declared. Should it be static? drivers/scsi/fnic/vnic_dev.c:319:5: warning: symbol 'vnic_dev_cmd2' was not declared. Should it be static? drivers/scsi/fnic/vnic_dev.c:414:5: warning: symbol 'vnic_dev_init_devcmd1' was not declared. Should it be static? drivers/scsi/fnic/vnic_dev.c:425:5: warning: symbol 'vnic_dev_init_devcmd2' was not declared. Should it be static? drivers/scsi/fnic/vnic_dev.c:495:6: warning: symbol 'vnic_dev_deinit_devcmd2' was not declared. Should it be static? drivers/scsi/fnic/vnic_dev.c:506:5: warning: symbol 'vnic_dev_cmd_no_proxy' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/scsi/fnic/vnic_dev.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/fnic/vnic_dev.c b/drivers/scsi/fnic/vnic_dev.c index 1b88a3b53eee..a2beee6e09f0 100644 --- a/drivers/scsi/fnic/vnic_dev.c +++ b/drivers/scsi/fnic/vnic_dev.c @@ -254,7 +254,7 @@ void vnic_dev_free_desc_ring(struct vnic_dev *vdev, struct vnic_dev_ring *ring) } } -int vnic_dev_cmd1(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, int wait) +static int vnic_dev_cmd1(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, int wait) { struct vnic_devcmd __iomem *devcmd = vdev->devcmd; int delay; @@ -316,7 +316,7 @@ int vnic_dev_cmd1(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, int wait) return -ETIMEDOUT; } -int vnic_dev_cmd2(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, +static int vnic_dev_cmd2(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, int wait) { struct devcmd2_controller *dc2c = vdev->devcmd2; @@ -411,7 +411,7 @@ int vnic_dev_cmd2(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, } -int vnic_dev_init_devcmd1(struct vnic_dev *vdev) +static int vnic_dev_init_devcmd1(struct vnic_dev *vdev) { vdev->devcmd = vnic_dev_get_res(vdev, RES_TYPE_DEVCMD, 0); if (!vdev->devcmd) @@ -422,7 +422,7 @@ int vnic_dev_init_devcmd1(struct vnic_dev *vdev) } -int vnic_dev_init_devcmd2(struct vnic_dev *vdev) +static int vnic_dev_init_devcmd2(struct vnic_dev *vdev) { int err; unsigned int fetch_index; @@ -492,7 +492,7 @@ int vnic_dev_init_devcmd2(struct vnic_dev *vdev) } -void vnic_dev_deinit_devcmd2(struct vnic_dev *vdev) +static void vnic_dev_deinit_devcmd2(struct vnic_dev *vdev) { vnic_dev_free_desc_ring(vdev, &vdev->devcmd2->results_ring); vnic_wq_disable(&vdev->devcmd2->wq); @@ -503,7 +503,7 @@ void vnic_dev_deinit_devcmd2(struct vnic_dev *vdev) } -int vnic_dev_cmd_no_proxy(struct vnic_dev *vdev, +static int vnic_dev_cmd_no_proxy(struct vnic_dev *vdev, enum vnic_devcmd_cmd cmd, u64 *a0, u64 *a1, int wait) { int err; -- 2.21.1