Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp645933ybz; Wed, 15 Apr 2020 15:52:15 -0700 (PDT) X-Google-Smtp-Source: APiQypKkWCm4BH1OM5gNhASaJTP8BvAgSHiZeEGdJ2SzzIFeNZxX0IM0xHmZl7GVTAVLYPRj3fbl X-Received: by 2002:aa7:cd65:: with SMTP id ca5mr28079518edb.283.1586991135525; Wed, 15 Apr 2020 15:52:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586991135; cv=none; d=google.com; s=arc-20160816; b=guc8hCJMW6e0QYiXcrhry4f/+IaYgEMsABA0cDdZxy8CkK4lwljVOqXTuIfcnXbfJz ZPWR7V/tiFM4Yos17+AVprKeVaghLQgzBgbO+ozWMK3qOrtFg311NJ0JLx0F58fS2GQD TFUezlrOjT6Nk1Z62olag9cE8GL0t0bcwzNyRd19ZRiuyJiuxfNtXtwlw6mmSIVClZHs 9dvv4Di7GSOnUzIognpOsRf7DwFojg3otgrja91/FWc8LZtNFJ6HbDWOE4LPt4nhznlh OReRJesiZdUvMc08eGHS/k8RXo4R/266hEXiMXKMV7bdtVWHRPXB2JbW/RzoMj7eo9dx kX7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=XM1Z8cdaxW1gEH8XQB3f7fNbxixDQWXVOYGx3dfIihk=; b=xYiF4RNMYlzQqI1LqSc3IaU0Xc5xuMikUk2uRtXAAEHdUzE/MKOCkC0KVwc0FlYpiO ZxH0fG3sivq4sd15geHol481hxEi+LbKlLiIkw6PsqOGJJ49PV+exsvJFvg/HW2oOC+Y 6fDLzSWgsFzQCLNhDwdHBtK3O+na+7bbKcSv/OnGaR+fWLOyPmOPWuaQ58eqBtBondNv drXTI4BW9n11E6VjB0gJjUu/KvKCtKlozJ+0pnVRiN1Pcowr4whJtiOdmIg+uuCFjufY HiYcHv3T1efuUdwub8ecLIKZCQ2qTAAWHYIQ2oG1y7ocGZd9KFquKXoMYoqUroB7D4sS yBcA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Y9S0dV0t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ch28si369659edb.247.2020.04.15.15.51.52; Wed, 15 Apr 2020 15:52:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=Y9S0dV0t; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895734AbgDOJkS (ORCPT + 99 others); Wed, 15 Apr 2020 05:40:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2895721AbgDOJkP (ORCPT ); Wed, 15 Apr 2020 05:40:15 -0400 Received: from merlin.infradead.org (unknown [IPv6:2001:8b0:10b:1231::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0347EC061A0C for ; Wed, 15 Apr 2020 02:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=XM1Z8cdaxW1gEH8XQB3f7fNbxixDQWXVOYGx3dfIihk=; b=Y9S0dV0t/YeSgy4L/RLwRlkYiv Z7Fkjr/gFed11uPUOn+zTOtYFinIXW3jjeriZ4DmvbNf5dPzO1zvMREfDakzTlBAe2kAO+wbrXSU8 LSPa+qM7Q/HlIaPOV8ikP27M49+ldf8TwaySmcpqKsslmMH3H0pIbQthSp7jugwllyZCJ4OD7uvHq ySVc6Mkaz9eQxhJ9lUy1LIItSvlJDP+VO6zekMTJpYU5zCfY1SWpmheQnuSZWcPblt2ht5H646P3T WsaMS5bfYk/ZdAtBVdJY4WyhnNyR5yTBAymiRRFh1wT1IIiYFr/rdhtPDiZI5JKH14YuOQha6Rqri z4/fiwOA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOeW9-0006G1-1l; Wed, 15 Apr 2020 09:39:37 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 50D3C30066E; Wed, 15 Apr 2020 11:39:35 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 336532BC6F2D8; Wed, 15 Apr 2020 11:39:35 +0200 (CEST) Date: Wed, 15 Apr 2020 11:39:35 +0200 From: Peter Zijlstra To: Steven Rostedt Cc: Valentin Schneider , Qais Yousef , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , Andrew Morton , Thomas Gleixner , Yury Norov , Paul Turner , Alexey Dobriyan , Josh Don , Pavan Kondeti , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/4] sched/rt: Distribute tasks in find_lowest_rq() Message-ID: <20200415093935.GA20730@hirez.programming.kicks-ass.net> References: <20200414150556.10920-1-qais.yousef@arm.com> <20200414162742.0ef4d9ee@gandalf.local.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200414162742.0ef4d9ee@gandalf.local.home> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 04:27:42PM -0400, Steven Rostedt wrote: > On Tue, 14 Apr 2020 19:58:49 +0100 > Valentin Schneider wrote: > > > To move this forward, I would suggest renaming the current cpumask_any_*() > > into cpumask_first_*(), and THEN introduce the new pseudo-random > > ones. People are then free to hand-fix specific locations if it makes sense > > there, like you're doing for RT. > > Or leave "cpumask_any()" as is, and create a new "cpumask_random()" for > this purpose. Well, that's just twisting words, not sure I like that. 'Any' really means 'any'. So in order to preserve long term sanity, I'd vote for Valentin's approach of converting existing users over to first.