Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: ygNsGP78gNK4RB0HRw8sUDmSvzMEJKY0vwPEdzRcxA/3CTJzToExOkAJ+SnFADnGHC0lgMouee
 y/tHgHX9Nu2Q==
IronPort-SDR: EebCVhxBJNMGFCCIJUcJimG8dbFy8SUtdHsZNe9cSASoYoSg7Qs3kyDlU5J/tctuXl4/esOHUE
 NHVUWyDjuO5g==
Date:   Wed, 15 Apr 2020 13:07:42 +0300
From:   Andy Shevchenko <andriy.shevchenko@intel.com>
To:     Jason Yan <yanaijie@huawei.com>
Cc:     lorenzo.pieralisi@arm.com, amurray@thegoodpenguin.co.uk,
        bhelgaas@google.com, p.zabel@pengutronix.de,
        gustavo.pimentel@synopsys.com, eswara.kota@linux.intel.com,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
        Hulk Robot <hulkci@huawei.com>
Subject: Re: [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static
Message-ID: <20200415100742.GR34613@smile.fi.intel.com>
References: <20200415084953.6533-1-yanaijie@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200415084953.6533-1-yanaijie@huawei.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol
> 'intel_pcie_cpu_addr' was not declared. Should it be static?

Please, learn how to use get_maintainers.pl to avoid spamming people.
Hint:
	scripts/get_maintainer.pl --git --git-min-percent=67
would give advantage, though it still requires a common sense to be applied.

> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/pci/controller/dwc/pcie-intel-gw.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-intel-gw.c b/drivers/pci/controller/dwc/pcie-intel-gw.c
> index fc2a12212dec..2d8dbb318087 100644
> --- a/drivers/pci/controller/dwc/pcie-intel-gw.c
> +++ b/drivers/pci/controller/dwc/pcie-intel-gw.c
> @@ -453,7 +453,7 @@ static int intel_pcie_msi_init(struct pcie_port *pp)
>  	return 0;
>  }
>  
> -u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
> +static u64 intel_pcie_cpu_addr(struct dw_pcie *pcie, u64 cpu_addr)
>  {
>  	return cpu_addr + BUS_IATU_OFFSET;
>  }
> -- 
> 2.21.1
> 

-- 
With Best Regards,
Andy Shevchenko