Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp650830ybz; Wed, 15 Apr 2020 15:59:00 -0700 (PDT) X-Google-Smtp-Source: APiQypIgdly3vbJzNQ0pB1Ry+bLgT4jmkcl2dXvK79M5o9c6xTG6QS0Vsn5zTvpBVrSpzZ7gIb7V X-Received: by 2002:a50:99c4:: with SMTP id n4mr27968532edb.187.1586991540178; Wed, 15 Apr 2020 15:59:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586991540; cv=none; d=google.com; s=arc-20160816; b=A5iVWWhmGxR/3c+YKpSjF1syI/SG8RxouEltod5azLAfWRvhrkm27W9jTitr41F1ct wMZlk5uUJ40Q4qgi894Y/o9MM4uYLZrNTj8U5qh2MfseEMsEK5Hc0YTE5o7lH9Fw/sFF h50Ix7PtrnJSnrOhOnFCDh6ggMsI5g0VX+rutuI2SoGoCtkzomTuJKZFvsTCZEVOLSpY QSh+LbLP3qYOKJe0G4GCKn/jM1AwC4xBlrKHwW0u1+uI1NYlcan+W3DHdQF39t+K4jHe l1P9qicBtPwsj8h/GbMJaSk2/6srGnw6F7XRMLOFSnQRphCXsFFI4y16LMZzxSOxV8i9 T6GQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=21hC42/qRxZDmqiUxEvzYQPrDZOJ/smRvBWWoE1k9hQ=; b=wAtkBlhiR9ES9MchySuZATUlgCImCSfcDKDYUnzSHkxCfh6DpLaQ/JJ4jxtERNT2GR UCAmkKIdHeqZQPU6yGKLjjeLH+YIUj82/jCTXfmcgAVQkI8kwXdptwY1cwX2tT8bQYfv 012yuI5xIE3adr33GdT63Qoj48Bu/agx33v7AAjZwbkpTtf2uVSo9bVp9ZKRHLlJkBcV VizqvyFulyw+LjWU8Q5+BckZYQ7Ay0EeImjMg1NkUfeXVUVbF98rBAh8AjXm52llmavR w/2B7Zqya8ygrgrQ9DP1F6Ja/mF4x0640BH+jcRlN+PEhokJh/JRRxYPh3mad2w0vSwp i+Ng== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="vvcS/23m"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e25si1718277edv.157.2020.04.15.15.58.37; Wed, 15 Apr 2020 15:59:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="vvcS/23m"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2896777AbgDOLLp (ORCPT + 99 others); Wed, 15 Apr 2020 07:11:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408845AbgDOLJp (ORCPT ); Wed, 15 Apr 2020 07:09:45 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91134C061A10 for ; Wed, 15 Apr 2020 04:09:45 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id g74so16633042qke.13 for ; Wed, 15 Apr 2020 04:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=21hC42/qRxZDmqiUxEvzYQPrDZOJ/smRvBWWoE1k9hQ=; b=vvcS/23mH11jORzDN8BGcCfZvJeI826FrnG3u+asgYZjL616yu62DIXvN4L4mHRN8v L2mwkXiEwhvpvYYvranvuYpbFBlaCiS8JdywVkE8pyyDLAjZV2wrfEMNqxN5F6hA0JFM xPzIB9ihc+EQwh1lRf3VNQ4yqgX22zDAy2N0mLLHpo2AKkrhB2yb+1FqDaCjdl+fdhRa pzHxRoJ8HK6zqNP7CPtKx6+xSPvQ+EXt5RhNSKjPhGMfC0HC0Yv+a5M555lQPbKJ1eNL 5Gs9DoTHmumKvr5bql4j8pBdlxxsCWamObMWPWeyLIuHNTd+ixwU/w0jqHNzja8sHO9/ 9WPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=21hC42/qRxZDmqiUxEvzYQPrDZOJ/smRvBWWoE1k9hQ=; b=ZL2F0dp2ZbWqCLXzu199QmF2zHM8kHg5fK0rwR66F7IxrML1tTK3lZ1JuqjORJ/JlK LLqsqb/fGm3JyRUc7gphZTsYrq1Jqkwc+zVSUJYnBR/BBIpb1eHuGdzOdKv2nDRbxjh3 PANEmhgxLW93uPn2cVclfKeylWWlw093AMaSZ1ql/+H3+x1e4y8B+SXxfHHrnf0xqgjn 13mJelhNweczg+AizgH+nkqykLH/QODDW2vzbz79mqOS3TwMv2yUm5VYfvEKYHZuRB8y Aw0yCCV+MgLwKtBDOwVd+x9PM36HGug0QpTbpmkxn/6tcfC0KPtvTbPheLk8OzPy986X XRPA== X-Gm-Message-State: AGi0PuYqL8yV91FlnynpSYmXqzPzs4c/cN7R9C4Pf2jpSbidUZJ1rq3f dXKFrCEdPbu+2b7Lv9ODwK5yPZHOq/CH4upnb/JLVQ== X-Received: by 2002:a37:8d86:: with SMTP id p128mr26303566qkd.250.1586948984176; Wed, 15 Apr 2020 04:09:44 -0700 (PDT) MIME-Version: 1.0 References: <20200408014010.80428-1-peterx@redhat.com> <20200408174732.bc448bbe41d190bfe5cc252e@linux-foundation.org> <20200410092951.6db32bfe@canb.auug.org.au> <7325374A-6072-44E4-85EE-F97FC7E8565F@lca.pw> <20200414192840.4yp3zqbe2tgtesve@xps.therub.org> In-Reply-To: <20200414192840.4yp3zqbe2tgtesve@xps.therub.org> From: Dmitry Vyukov Date: Wed, 15 Apr 2020 13:09:32 +0200 Message-ID: Subject: Re: [PATCH 0/2] mm: Two small fixes for recent syzbot reports To: Dan Rue Cc: Qian Cai , Linus Torvalds , Stephen Rothwell , Andrew Morton , Peter Xu , LKML , Linux-MM , Jens Axboe , Christoph Lameter , Johannes Weiner , syzkaller Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 9:28 PM Dan Rue wrote: > > On Tue, Apr 14, 2020 at 01:12:50PM +0200, Dmitry Vyukov wrote: > > On Tue, Apr 14, 2020 at 12:06 AM Qian Cai wrote: > > > Well, there are other CI's beyond syzbot. > > > On the other hand, this makes me worry who is testing on linux-next every day. > > > > How do these use-after-free's and locking bugs get past the > > unit-testing systems (which syzbot is not) and remain unnoticed for so > > long?... > > syzbot uses the dumbest VMs (GCE), so everything it triggers during > > boot should be triggerable pretty much everywhere. > > It seems to be an action point for the testing systems. "Boot to ssh" > > is not the best criteria. Again if there is a LOCKDEP error, we are > > not catching any more LOCKDEP errors during subsequent testing. If > > there is a use-after-free, that's a serious error on its own and KASAN > > produces only 1 error by default as well. And as far as I understand, > > lots of kernel testing systems don't even enable KASAN, which is very > > wrong. > > I've talked to +Dan Rue re this few days ago. Hopefully LKFT will > > start catching these as part of unit testing. Which should help with > > syzbot testing as well. > > LKFT has recently added testing with KASAN enabled and improved the > kernel log parsing to catch more of this class of errors while > performing our regular functional testing. > > Incidentally, -next was also broken for us from March 25 through April 5 > due to a perf build failure[0], which eventually made itself all the way > down into v5.6 release and I believe the first two 5.6.x stable > releases. > > For -next, LKFT's gap is primarily reporting. We do build and run over > 30k tests on every -next daily release, but we send out issues manually > when we see them because triaging is still a manual effort. We're > working to build better automated reporting. If anyone is interested in > watching LKFT's -next results more closely (warning, it's a bit noisy), > please let me know. Watching the results at https://lkft.linaro.org > provides some overall health indications, but again, it gets pretty > difficult to figure out signal from noise once you start drilling down > without sufficient context of the system. What kind of failures and noise do you get? Is it flaky tests? I would assume build failures are ~0% flaky/noisy. And boot failures are maybe ~1% flaky/noisy due to some infra issues. I can't find any actual test failure logs in the UI. I've got to this page: https://qa-reports.linaro.org/lkft/linux-mainline-oe/build/v5.7-rc1-24-g8632e9b5645b/testrun/1363280/suite/kselftest/tests/ which seem to contain failed tests on mainline. But I still can't find the actual test failure logs. > Dan > > [0] https://lore.kernel.org/stable/CA+G9fYsZjmf34pQT1DeLN_DDwvxCWEkbzBfF0q2VERHb25dfZQ@mail.gmail.com/ > > -- > Linaro LKFT > https://lkft.linaro.org