Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp650928ybz; Wed, 15 Apr 2020 15:59:06 -0700 (PDT) X-Google-Smtp-Source: APiQypLmp4wseun5eGK/2ohDVDb6amu0uttR8XlGo3v+I1CGPsWPrebk3Qjr5oHN0LVhWWCpupp/ X-Received: by 2002:a17:906:3289:: with SMTP id 9mr7125165ejw.130.1586991546760; Wed, 15 Apr 2020 15:59:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586991546; cv=none; d=google.com; s=arc-20160816; b=BP7g+02/8FQfUefoHS/NfpCEbZW9zy9EEtCo5AommWWEzbhwoeo6w8exluEEMP5ZK3 krxNSjO2Nlp4M6CRfHxjNdqJJ9qUg/tS+7bKKJ3pARdyzZJ8FQvtNwrszKA0x8zDG/Im UuXUymZtSHof1nra/VDIHYvf3Xce1vMGk8SODDqUGxKTu3Cwi9Q6P/Llb6I2BAZo1dWu sibgy+nTvegcUhAONa0rwd5lzJw0dKE9FO/Nz03mr87RS0q5pkNO4L76mwXS5WVCSoH2 RXq0K9YyDJmFPnBhEThuSY7MFne6j/xwfQgwJJ6uyJ9Wn7HLv19amrE5eD2cQcD3lF1Q Mwdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:autocrypt :from:to:subject:cc:dkim-signature; bh=Uyc/JgUYUF0x93fiBIrjjRttso5hxJiBBi8LdmVxlcM=; b=0HEex/Ib0cb4pYZFPSOQU3xH3YLDh6qM/ugviuiUoEKwlDmgiDUukMeNv0W7voit2l jifKv1qeAdlkc1Va8jSn/NFK4cHHAO8fDmlafQhGgIU6llc9e8hF961+Q4M0rO4Kh24n 5U8dawp1Rzb+wUaIO3dEccn2JnwzUQfIfTHfVcCbbtmk+iuYsMFAZgdkVSHkSq3IfZB5 kZ6/0nHtn1UB8zZa6ns49ocVOgunr8DfgHgLnx8bVTQVztni0sAYioZt5FXo+XbSy2Nm bBJaMOtaMonTdX8x9pM8m7pzjsyBfH5NKcpdajUMBYTk2PBfUEkloMD86UlpHVAlrO+T M7HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=YNf8jj4p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i11si12494102eds.272.2020.04.15.15.58.43; Wed, 15 Apr 2020 15:59:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=YNf8jj4p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2896808AbgDOLND (ORCPT + 99 others); Wed, 15 Apr 2020 07:13:03 -0400 Received: from mout.web.de ([217.72.192.78]:37689 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896759AbgDOLLp (ORCPT ); Wed, 15 Apr 2020 07:11:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1586949015; bh=Uyc/JgUYUF0x93fiBIrjjRttso5hxJiBBi8LdmVxlcM=; h=X-UI-Sender-Class:Cc:Subject:To:From:Date; b=YNf8jj4pPjHUp43E/roe/4iEoezLUctJcdCTPTbJuiGJqjPUF3zowchK7rDdzn4F2 soLcUY4wT7xFPRUXFVQZ8wxZtmNclVe+r9ign2TDcqIlShL0B57Z66bIUpANwfvCA+ gPLoteEf//PfdLyjqqznywLG+p5ynS/a9DO+TODI= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.3] ([78.48.133.192]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0Lmcf9-1ip3rh3cbD-00aHGp; Wed, 15 Apr 2020 13:10:15 +0200 Cc: linux-kernel@vger.kernel.org, Antonio Quartulli , "David S. Miller" , Jakub Kicinski , Kangjie Lu , Marek Lindner , Simon Wunderlich , Sven Eckelmann , Yuan Zhang Subject: Re: [PATCH] batman-adv: Fix refcnt leak in batadv_store_throughput_override To: Xiyu Yang , Xin Tan , b.a.t.m.a.n@lists.open-mesh.org, netdev@vger.kernel.org From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: Date: Wed, 15 Apr 2020 13:10:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:mkQolI8XcWr8+vLOs8HJMBFqXy5OGBb4+jUbWRZrMI+YPsOlT27 9ENpzFA7j1QixKKBIScLqTaDF1sCyTXitvqjgLV8jJ3Pophih2rDY2v/UTyZUkGEsDWnMCi ha8JaLFOxXSpmNWcZ166r0wvfJuSYk7bw8OPotc7PVL32UN83YeSsqU9gVdYF6rDqTdhr6w 2d5WY7liDt4XZM7YGUbxQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:fhXCi2r++Kk=:KbI2y5i2O4NtAa6CBoD/zo O9LDdK7GcbDHvcWMKVhtWTSYyQPpleAvQHrdGfW3zFc7UKGaq9HSyahaHucn9vcnHOTFtY9zX IHoS5BLQ2XR+DTOq1fHdOi2gnEURUb6tKR+50DxOQ4ODANGk7oLQ0KTGOOTuv/qsBYkz6WDHx MXKTx7rYG4eed0Z+6I7ui2muCO76adlmbxbbqPPURE4NFe44a5QF3fMNsPVMh9p+co+0wIwSF sj5M7WNKhyfwoOE4krSrbrxv9Lh1LNTZ+nmJCEcDX0TKWPYMIJQfi83j7WpYLJ++se+ZxmaEo nCi82UvHwGYMoNNeRZux1bKB/+O+8wplVPHIDMZOMRSlmsuP/lpor4dUA/psskbR2A4T2FQip EeMQPoLVZevB7O5BmU/E3cSxrLQsUFWxrAwfl1/F9B0sBxC0B/COctVNq49ZJyaqrVKYvXtf7 qSDo9rWpoNgnuCq/e2UM8eu9fje0CiiEeeL6xMyAB+6m5ac4DNAgmjGOmsMLyV9PYdF55/BCm tr9TBpkKVbtnpVQOZrmtoPzClFkE8jX4bI3xmkGKbixV8RQNF2jbDWl+RhoDA2qfQIiAoht9H ql3wQ9+KznRQShXxL5O+CwZi26fppJh+8Zcd04pylloUghVWrgfWGiCJjLtKRj1qzA/y2jfmT 2TLMQ5Na2TBjL8rIHVXK0EQpTdG3G4G98emywocsQ75LW0jzmFgbdxhatmbu5VjO+PjjJ3pbq 3bWRevmauA92U44OHV0pNP5zw+nGgdmudatXXovCp7jKnylg3guUyISNgzHGSpZ7eVn65VaPW HESzwHLYvTuWRwJP/yvd9r//ziYU/fFGac+MI10QoUeJMjzzysJMxtKtgOwDDAzNHZTlWoegJ znsT4hcbj8VZe0EJfy34qUoD3j2wl9fSr9/NfzNMNdHcLbthpiWbz/5HTUL3S2zLrmM+JrjfP /cq9igjlnAxUnN3vfeenKmgEhrjOCKmjb9qrOhzFCnbAKE0uUC/ScEu7+x7d8eubgUnkBOnp5 wkHhuv959dMia/nABilKGt1fbfRH3ii3o3IZ/J9sCcmJoZNZRHQmQp9/MwnCmYgRrxScs/CVr 3zksueJO3qnJJ3nPmdrTAAZbY4Ke8oIqH60nrMmUDtQivkY/7vjFkXBIZ0osaMTtFjO+biyfn MSxNnFTrApfUWeAZyeFZ1UwXej4gov5zejFRz6DfrhIrIFlOHKzcyDC7Y2BnT0TK6rcbe8aix BNPEWGUvKVvmhbvks Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The issue happens in one error path of > batadv_store_throughput_override(). When batadv_parse_throughput() > returns NULL, the refcnt increased by batadv_hardif_get_by_netdev() is > not decreased, causing a refcnt leak. How do you think about to mention the terms =E2=80=9Cexception handling=E2= =80=9D and =E2=80=9Creference counting=E2=80=9D in the commit message? Would you like to add the tag =E2=80=9CFixes=E2=80=9D to the change descri= ption? Regards, Markus