Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp651779ybz; Wed, 15 Apr 2020 16:00:11 -0700 (PDT) X-Google-Smtp-Source: APiQypLBfrHiHYF4utjuCyL4Gj612r/o5uDrT/ntSLo/pRg92NWFtwxg315c8EEbwjk4kSQ1wcTF X-Received: by 2002:a50:85c4:: with SMTP id q4mr25594749edh.147.1586991611055; Wed, 15 Apr 2020 16:00:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586991611; cv=none; d=google.com; s=arc-20160816; b=lL/G98fWTFh2OLb8L92eWVxuxMXLqLLFaIz2iCW3mwR/sFkAiheHhj2KdgxXgzvnTN d767Bs7vX+O/6T61c5gEWgDoFNY1XknIKmBzcARg/KOlibHL+VRkuyD5zFifKrve173F 4SxBqluwiOLjZhOAraX1dRCQaNrRltrAXW3ZEY/tQnPJcCZgT1TEQHIas8AFcNqXwVMd 64GTcrluOXq88bfBeZnGrB6semZvojyC/4Bh92HN1Z/H0e9KuochevBcyKojQwOMefE5 hSdljlvnrAfX87kOS8YD8ErQ5BuBG3UIlfoniBaKPoIyslv/8OT7dBClLipkH3xEw++Q GlwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=caMWrDdLRB/GT4PMMj6m9lXC3z2vMfRJzGNCxgoCqNc=; b=DT9OJ7iW0o+iZfLUJoff8Njh6vCbGOdfVzUIavUGPr6LKi1cGacZWASPkB7GVHThFv nUvGHG4YXEEAvsKdscIG0cvWnTODqgU4TSoZnK1ca8Cdls6xHCM7FQ4k9ZfJ056Zafrz SADxjAK/zh1JDCXRm13FBmz2xjsp17ya39hFqWGFYhaUhzqlwFTYob33PsXI9+/yxTde DCGQY4PG7rAGhi2O9E/OI/0xXjOUWhkbRMpTutm4DQjYl52USI0d6vNNcB8Sy5pYAh8i uJDnIYTkztZOO38cFRLFzK6o7ISJ1OpudTStbueYwr6wU/4sD6kvDE53jC9bm4ZVwhUG fqCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bs1si2690864edb.200.2020.04.15.15.59.48; Wed, 15 Apr 2020 16:00:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2896833AbgDOLPq (ORCPT + 99 others); Wed, 15 Apr 2020 07:15:46 -0400 Received: from sauhun.de ([88.99.104.3]:52850 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896802AbgDOLM5 (ORCPT ); Wed, 15 Apr 2020 07:12:57 -0400 Received: from localhost (p54B33507.dip0.t-ipconnect.de [84.179.53.7]) by pokefinder.org (Postfix) with ESMTPSA id C08EA2C1FF1; Wed, 15 Apr 2020 13:12:55 +0200 (CEST) Date: Wed, 15 Apr 2020 13:12:55 +0200 From: Wolfram Sang To: Aishwarya R Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Greg Kroah-Hartman , Thomas Gleixner , Richard Fontana , linux-i2c@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] i2c: powermac: Simplify reading the "reg" and "i2c-address" property Message-ID: <20200415111255.GP1141@ninjato> References: <20200408100354.17782-1-aishwaryarj100@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mejza3ZMMA5Za1mX" Content-Disposition: inline In-Reply-To: <20200408100354.17782-1-aishwaryarj100@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mejza3ZMMA5Za1mX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Apr 08, 2020 at 03:33:53PM +0530, Aishwarya R wrote: > Use of_property_read_u32 to read the "reg" and "i2c-address" property > instead of using of_get_property to check the return values. >=20 > Signed-off-by: Aishwarya R This is quite a fragile driver. Have you tested it on HW? --mejza3ZMMA5Za1mX Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl6W7DcACgkQFA3kzBSg KbbKcg/+LuL3CQDRqRDK5QM2XE52jwFinJ8KZNx2KhKdg3UvWQMcWqt+V0ZvVy0F NTo355uvwsvO9dtuemowZmBP6QgS6SPBWktIpn7FX73l5CCx4YT9J/LsHYnJOoCR 2xm3Ai02XtRv3cB6E9jCKXqLz1gxKdmQVDmVcjODqiqDjzppgXuQhsEDeTb6/jpK 6Blt2slVkB2GYEakAuV5+4lLXdAFb7Gl1+VIGxnBYz0H5eGdzU/i3TC5Zbr3FFWT tjaFJmnQIPQc9kjw2vXy/UZagb3KQ+9nJe1/55iF9VyaA8u7wpS8dPBwXLuKuqX9 PrHffSmjd7MIVvMXEVq/lh3z3cxk4eFKz8uCh+XYBPFVDpTfyupZoa2mxZHqPk4E WxpRhoSRY7rG/GyO8dGaMfQdYL+9mX+tDI8is3U4gfUPXqaaTRogZ/85T0Y7rZIN xs2IO8SC/e8TAQqQ1SbH4oErJk4QjyK9n+YprFiirsm28U8D0FD7/Kiy8nFny/17 4j8DB2xTwtyZyVg8OjPojUm00XEPGZEUFdsYgxUW5nesk+lZkDvlVAWgUg0v9rWO BjM+OWhc3ShIar6Wp2W8Zog18i5ds4wTYNqMPjI8VUv9muuYxMOUdZGD/oUKcylf rMBsGgX0hoTe6KVyd+MP9ER4nhckHKMgemOKQJuF14sFRUi8Ri4= =XD4D -----END PGP SIGNATURE----- --mejza3ZMMA5Za1mX--