Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp662795ybz; Wed, 15 Apr 2020 16:11:01 -0700 (PDT) X-Google-Smtp-Source: APiQypJBJHTSduZ2w3ANpI11gvRcXqMPTHVhon/7i6MEW873vdER+47pvBPJys93qrFMOqRFGhdE X-Received: by 2002:aa7:d653:: with SMTP id v19mr3858186edr.383.1586992261525; Wed, 15 Apr 2020 16:11:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586992261; cv=none; d=google.com; s=arc-20160816; b=hULnd6BjQvpAx/2E1lnFkPUl/Zxa8N8uqr3itAEHj8EuBdy+rPT6FMaO/GmC2XZ9dt lVfC6sK+dBDy7Inlwex58FPvcU/oupJ3Yq01XjK4utGYJM3c4kMU5knJQ91Rbpi1cj60 hz6pIbMvwK1MhFZyRcHcqvCXYF+zVnSOqDxGvgrqdbDaoNJQ3rasiWhGSYH2u6zfOxWn tcVVgKPj+X8RVlRnLys7ST3EF92F5Qv8Yhc8D6YrwtErogBu9kcjUFpYZrn+SVXMTIt5 JldwyOaCKFopbsQEyNrdyGM3xzVzxMmVbJKm7p8GEmhFN+0yyACJuuhrIQVILmUlqBmV 1dgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:mime-version:user-agent:date:message-id:subject :from:cc:to; bh=awmPjsnYQCq8gyFIupT8XohvIQ4sZYkS9Kb5cKGknMI=; b=ge5N1YDt/oc6avHmRMJiYDz+RMNN9rjhXdAJI9QqU5+WxSoP8Yf74y0HlF8rLLkbVi eIpfsnwnp/E5TsqcRFEQ4r4XYxBWuATcuGdfqkTLUJYZ3qJcJGGvZkdVWH25uePMRvXY jwaAZ5dyerY+l2fxRTRVQSbCnhw30rwNH5bNz4f4bNWntB0fts00X0VWTlePw8Vh4806 ln+XKgyoObKaJnpbk452xfVn6uT2sw9aCAFK36Fws6MhT+9orw7C9JdR8FyLqnUbBOPG I9VkD/4GDAzIPGRU2e+AIr4/lVroHhZA7ZW2I35ShJJuHBCZmhDfy2JHLUXgPzFtAFJ3 Ixqg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id gh8si5768607ejb.301.2020.04.15.16.10.38; Wed, 15 Apr 2020 16:11:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S368418AbgDOMGZ (ORCPT + 99 others); Wed, 15 Apr 2020 08:06:25 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:36096 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2409684AbgDOL5n (ORCPT ); Wed, 15 Apr 2020 07:57:43 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id CCB38869BAD155A7B79A; Wed, 15 Apr 2020 19:57:40 +0800 (CST) Received: from [127.0.0.1] (10.173.220.183) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Wed, 15 Apr 2020 19:57:32 +0800 To: , , , "linux-kernel@vger.kernel.org" CC: linfeilong , Mingfangsen , "wubo (T)" , Yanxiaodan From: Zhiqiang Liu Subject: [PATCH] md/persistent-data: exit_ro_spine func return void Message-ID: Date: Wed, 15 Apr 2020 19:57:31 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.220.183] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Zhiqiang Liu In commit 4c7da06f5a78 ("dm persistent data: eliminate unnecessary return values"), r value in exit_ro_spine will not changes, so exit_ro_spine donot need to return values. Signed-off-by: Zhiqiang Liu --- drivers/md/persistent-data/dm-btree-internal.h | 2 +- drivers/md/persistent-data/dm-btree-spine.c | 6 ++---- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/md/persistent-data/dm-btree-internal.h b/drivers/md/persistent-data/dm-btree-internal.h index a240990a7f33..55a4096f1334 100644 --- a/drivers/md/persistent-data/dm-btree-internal.h +++ b/drivers/md/persistent-data/dm-btree-internal.h @@ -68,7 +68,7 @@ struct ro_spine { }; void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info); -int exit_ro_spine(struct ro_spine *s); +void exit_ro_spine(struct ro_spine *s); int ro_step(struct ro_spine *s, dm_block_t new_child); void ro_pop(struct ro_spine *s); struct btree_node *ro_node(struct ro_spine *s); diff --git a/drivers/md/persistent-data/dm-btree-spine.c b/drivers/md/persistent-data/dm-btree-spine.c index b27b8091a1ca..e03cb9e48773 100644 --- a/drivers/md/persistent-data/dm-btree-spine.c +++ b/drivers/md/persistent-data/dm-btree-spine.c @@ -132,15 +132,13 @@ void init_ro_spine(struct ro_spine *s, struct dm_btree_info *info) s->nodes[1] = NULL; } -int exit_ro_spine(struct ro_spine *s) +void exit_ro_spine(struct ro_spine *s) { - int r = 0, i; + int i; for (i = 0; i < s->count; i++) { unlock_block(s->info, s->nodes[i]); } - - return r; } int ro_step(struct ro_spine *s, dm_block_t new_child) -- 2.19.1