Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Makarand Pawagi <makarand.pawagi@nxp.com>
To:     Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Laurentiu Tudor <laurentiu.tudor@nxp.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "iommu@lists.linux-foundation.org" <iommu@lists.linux-foundation.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "robin.murphy@arm.com" <robin.murphy@arm.com>,
        "ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
        Ioana Ciornei <ioana.ciornei@nxp.com>,
        "Diana Madalina Craciun (OSS)" <diana.craciun@oss.nxp.com>,
        "maz@kernel.org" <maz@kernel.org>,
        "jon@solid-run.com" <jon@solid-run.com>,
        Pankaj Bansal <pankaj.bansal@nxp.com>,
        Calvin Johnson <calvin.johnson@nxp.com>,
        Varun Sethi <V.Sethi@nxp.com>,
        Cristi Sovaiala <cristian.sovaiala@nxp.com>,
        "Stuart.Yoder@arm.com" <Stuart.Yoder@arm.com>,
        "jeremy.linton@arm.com" <jeremy.linton@arm.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "jason@lakedaemon.net" <jason@lakedaemon.net>
Subject: RE: [EXT] Re: [RFC PATCH 1/4] bus: fsl-mc: add custom .dma_configure
 implementation
Thread-Topic: [EXT] Re: [RFC PATCH 1/4] bus: fsl-mc: add custom .dma_configure
 implementation
Thread-Index: AQHWAsVH5evd3VqgDk+6ugY0rVkdjah4zWyAgAD9FYA=
Date:   Wed, 15 Apr 2020 05:42:03 +0000
Message-ID: <DB7PR04MB4986A8A3427DBA096628D6FBEBDB0@DB7PR04MB4986.eurprd04.prod.outlook.com>
References: <20200227100542.13819-1-laurentiu.tudor@nxp.com>
 <20200325125109.GA5430@red-moon.cambridge.arm.com>
 <499fbf9a-416f-d7c7-0655-881d92138a6c@nxp.com>
 <20200414143211.GA14905@red-moon.cambridge.arm.com>
In-Reply-To: <20200414143211.GA14905@red-moon.cambridge.arm.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 42b0c87f-85c5-436a-cfb4-08d7e0ffb9dd
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2020 05:42:03.4938
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gCQVlYyuUu5aGleQ4XT4N8or98o6FoAkEBRWafGO7jY49+y7V0Jn9p/x00Rxv6465zhHDNSAx2oa34T6lE49rw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4057
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> Sent: Tuesday, April 14, 2020 8:02 PM
> To: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> Cc: linux-kernel@vger.kernel.org; iommu@lists.linux-foundation.org; linux=
-arm-
> kernel@lists.infradead.org; linux-acpi@vger.kernel.org;
> robin.murphy@arm.com; ard.biesheuvel@linaro.org; Ioana Ciornei
> <ioana.ciornei@nxp.com>; Diana Madalina Craciun (OSS)
> <diana.craciun@oss.nxp.com>; maz@kernel.org; jon@solid-run.com; Pankaj
> Bansal <pankaj.bansal@nxp.com>; Makarand Pawagi
> <makarand.pawagi@nxp.com>; Calvin Johnson <calvin.johnson@nxp.com>;
> Varun Sethi <V.Sethi@nxp.com>; Cristi Sovaiala <cristian.sovaiala@nxp.com=
>;
> Stuart.Yoder@arm.com; jeremy.linton@arm.com; joro@8bytes.org;
> tglx@linutronix.de; jason@lakedaemon.net
> Subject: [EXT] Re: [RFC PATCH 1/4] bus: fsl-mc: add custom .dma_configure
> implementation
>=20
> Caution: EXT Email
>=20
> On Wed, Mar 25, 2020 at 06:48:55PM +0200, Laurentiu Tudor wrote:
> > Hi Lorenzo,
> >
> > On 3/25/2020 2:51 PM, Lorenzo Pieralisi wrote:
> > > On Thu, Feb 27, 2020 at 12:05:39PM +0200, laurentiu.tudor@nxp.com wro=
te:
> > >> From: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > >>
> > >> The devices on this bus are not discovered by way of device tree
> > >> but by queries to the firmware. It makes little sense to trick the
> > >> generic of layer into thinking that these devices are of related so
> > >> that we can get our dma configuration. Instead of doing that, add
> > >> our custom dma configuration implementation.
> > >>
> > >> Signed-off-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
> > >> ---
> > >>  drivers/bus/fsl-mc/fsl-mc-bus.c | 31
> > >> ++++++++++++++++++++++++++++++-
> > >>  1 file changed, 30 insertions(+), 1 deletion(-)
> > >>
> > >> diff --git a/drivers/bus/fsl-mc/fsl-mc-bus.c
> > >> b/drivers/bus/fsl-mc/fsl-mc-bus.c index 36eb25f82c8e..eafaa0e0b906
> > >> 100644
> > >> --- a/drivers/bus/fsl-mc/fsl-mc-bus.c
> > >> +++ b/drivers/bus/fsl-mc/fsl-mc-bus.c
> > >> @@ -132,11 +132,40 @@ static int fsl_mc_bus_uevent(struct device
> > >> *dev, struct kobj_uevent_env *env)  static int
> > >> fsl_mc_dma_configure(struct device *dev)  {
> > >>    struct device *dma_dev =3D dev;
> > >> +  struct iommu_fwspec *fwspec;
> > >> +  const struct iommu_ops *iommu_ops;  struct fsl_mc_device *mc_dev
> > >> + =3D to_fsl_mc_device(dev);  int ret;
> > >> +  u32 icid;
> > >>
> > >>    while (dev_is_fsl_mc(dma_dev))
> > >>            dma_dev =3D dma_dev->parent;
> > >>
> > >> -  return of_dma_configure(dev, dma_dev->of_node, 0);
> > >> +  fwspec =3D dev_iommu_fwspec_get(dma_dev);  if (!fwspec)
> > >> +          return -ENODEV;
> > >> +  iommu_ops =3D iommu_ops_from_fwnode(fwspec->iommu_fwnode);
> > >> +  if (!iommu_ops)
> > >> +          return -ENODEV;
> > >> +
> > >> +  ret =3D iommu_fwspec_init(dev, fwspec->iommu_fwnode, iommu_ops);
> > >> + if (ret)
> > >> +          return ret;
> > >> +
> > >> +  icid =3D mc_dev->icid;
> > >> +  ret =3D iommu_fwspec_add_ids(dev, &icid, 1);
> > >
> > > I see. So with this patch we would use the MC named component only
> > > to retrieve the iommu_ops
> >
> > Right. I'd also add that the implementation tries to follow the
> > existing standard .dma_configure implementations, e.g.
> > of_dma_configure + of_iommu_configure. I'd also note that similarly to
> > the ACPI case, this MC FW device is probed as a platform device in the
> > DT scenario, binding here [1].
> > A similar approach is used for the retrieval of the msi irq domain,
> > see following patch.
> >
> > > - the streamid are injected directly here bypassing OF/IORT bindings
> translations altogether.
> >
> > Actually I've submitted a v2 [2] that calls into .of_xlate() to allow
> > the smmu driver to do some processing on the raw streamid coming from
> > the firmware. I have not yet tested this with ACPI but expect it to
> > work, however, it's debatable how valid is this approach in the
> > context of ACPI.
>=20
> Actually, what I think you need is of_map_rid() (and an IORT equivalent, =
that I
> am going to write - generalizing iort_msi_map_rid()).
>=20

That would help.

> Would that be enough to enable IORT "normal" mappings in the MC bus named
> components ?
>=20

But still the question remain unanswered that how we are going to represent=
 MC? As Platform device with single ID mapping flag?

> Thanks,
> Lorenzo