Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp699917ybz; Wed, 15 Apr 2020 17:01:34 -0700 (PDT) X-Google-Smtp-Source: APiQypLtaHeJnXh2YFGegQLvCEUb5uk4RgOw5qRuwD8vKcJUcCiAjWBHwIqvuMrWa7MEIEb0bQY4 X-Received: by 2002:a17:906:4406:: with SMTP id x6mr5575542ejo.160.1586995294378; Wed, 15 Apr 2020 17:01:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586995294; cv=none; d=google.com; s=arc-20160816; b=r+RrnM8NB97aqcTD0rg5PY2q67F0g5d7/mSMhB8rpfOTNfpfXIDeUd7to8cerIryT+ BI98kioi2pENM2wLClWy6ZAeucfq4YOUT6oTCz2qyd4CR3+vqSwiONX6kmcqU9PpyTpb nHI2UGrqtlv3UK6mnHdcaKHgpRgilEomn+kwBG2oagAlgg3ALkjNnmgAZY4btro6LwMs oHqmeCy9XYmur2ChndAOLbMx0x3Bc06peBVXpUVNauaK/VKqbXZFJ5YIf6QmYKxhBWCC Vm/Ta1WG/tAmpbf5sxFfOcfclU/UjLy8V3agf1kMmkATWqdBz37DyL0W2U5ySyODc6+8 +14w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=ZUVa/Vu2A97usHuRMdPf5GLdnW8lNAhzw/IcPlS7Pxc=; b=Eadh2xpNgYxy8UobCKCdDXlG2F+OHbpcKdojU7tZjZUjYy+9wPYSuFZcB2ufR/U8h+ X29vvf8SBtrSJZzXH3yPqLe7R2hfL//W+AE43Mf4R91Am49WysVcDGHUaCdJksPYoQsP A1ZHWMq9r47ugSRBHnVPDPPzOSg+3F+QEmCpi6yikhgK+fP7+Jb4JbxlJfKod5OgFTYj mU3O+zpwCPU3o52HAbD04XsCoaEKgB8HwYUici1pD3LCXWvzdYDDZdjvdHRtCN6VvVxh CgRmYg4yf5ePyPYTjRbaVm1+gk1n7a4BgO2zZkAleFvVIBOe8LnGLYQRUOfsQStRLds7 1+WQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i26si9784734edv.307.2020.04.15.17.01.10; Wed, 15 Apr 2020 17:01:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2506050AbgDONK3 (ORCPT + 99 others); Wed, 15 Apr 2020 09:10:29 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:50276 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2505981AbgDONKL (ORCPT ); Wed, 15 Apr 2020 09:10:11 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 9B3CF165915F79B5C852; Wed, 15 Apr 2020 21:10:07 +0800 (CST) Received: from [127.0.0.1] (10.173.221.195) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.487.0; Wed, 15 Apr 2020 21:09:57 +0800 Subject: Re: [PATCH] PCI: dwc: intel: make intel_pcie_cpu_addr() static To: Andy Shevchenko CC: , , , , , , , , Hulk Robot References: <20200415084953.6533-1-yanaijie@huawei.com> <20200415100742.GR34613@smile.fi.intel.com> From: Jason Yan Message-ID: <29bc09ef-6e81-9411-302c-50ee9314764b@huawei.com> Date: Wed, 15 Apr 2020 21:09:56 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: <20200415100742.GR34613@smile.fi.intel.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.173.221.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2020/4/15 18:07, Andy Shevchenko ะด??: > On Wed, Apr 15, 2020 at 04:49:53PM +0800, Jason Yan wrote: >> Fix the following sparse warning: >> >> drivers/pci/controller/dwc/pcie-intel-gw.c:456:5: warning: symbol >> 'intel_pcie_cpu_addr' was not declared. Should it be static? > > Please, learn how to use get_maintainers.pl to avoid spamming people. > Hint: > scripts/get_maintainer.pl --git --git-min-percent=67 > would give advantage, though it still requires a common sense to be applied. > I'm so sorry to bother you with this. I will be more careful when I'm sending patches. Thanks, Jason