Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp706047ybz; Wed, 15 Apr 2020 17:08:36 -0700 (PDT) X-Google-Smtp-Source: APiQypKM6PGyRuSoxXH+Wtytr7hyd6l7gRgyvUClGB8Dpp44DF2LayuTcF8rIdft9S81ZwLmb21T X-Received: by 2002:aa7:d857:: with SMTP id f23mr27190958eds.235.1586995716599; Wed, 15 Apr 2020 17:08:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586995716; cv=none; d=google.com; s=arc-20160816; b=Yb6pGkG247nF4Y11OjAOTeogO6xBWcJ52Gne00v6xi3Yitv7hohpPkozvNN7WGwZFH HL1Q2USlPJMBWO6LP9ExpgqtcQdXVrc0LxyGG7tWPjA9JNKtJzxDGqyKqDhhy4WgR0J9 VyiavAj+i4VqxF29sBuXTDK3VY3SdfDiZ4euHLf8m6Oha94D9Nha/d1Wl3/oJDu9ZMk7 uhM/+iLF83jjPSVjGNUQDQFbafDovtf3+P2bMa0sdY6xZeYEBql1gXXQaPJtrnfh/ktr cufo1TH8XBdCECT2hA9NC0UPw+TZQQaG8f8jKRUyX9G4EANikk7R7k6eyLv8CQlPVD2d XFyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0UT8lst5nDXa5EduKqboY813zRQkbwrz0jocGjjJQg4=; b=AP6An0HZ0/qICXz3p0iqGoft9EMlYeLTOV/aOqM2kJRs1P3Mv+hOingXMuY+809WxR nI4Sg8fo+41Mtt+K+fXkcbpk9RjvhU8SOT5IPKvc4bGOltVZWwlbcOa5wOi1Eu7hiO8t gLamA8Flp6bN8gf6CC4tQ/13gmG3rk1+5YVoH/RarL6sd8jIbhPe5vDo753EVL7uv7sB arlA3PnACdKEYAd3NjhAwZYzNg9lTk19CcMzHC0FhnQo7qKSnbELIGsw31MRF5Ez0LdO v/N6t0QTDE1duCBepRiyfmFBn5oK41sZE+LT0DHQ5fxtfvZ5H8Q9lYGkW2XV/ZltMZB4 shYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=M4ITrRhk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bi17si11956053edb.370.2020.04.15.17.08.13; Wed, 15 Apr 2020 17:08:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=M4ITrRhk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392054AbgDOO1m (ORCPT + 99 others); Wed, 15 Apr 2020 10:27:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729551AbgDOO1i (ORCPT ); Wed, 15 Apr 2020 10:27:38 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C1D4EC061A0E for ; Wed, 15 Apr 2020 07:27:37 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id s63so13193794qke.4 for ; Wed, 15 Apr 2020 07:27:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=0UT8lst5nDXa5EduKqboY813zRQkbwrz0jocGjjJQg4=; b=M4ITrRhk7dfzvUeRdnL4el+TCzeHs3naP4MrWW4R1ebq1UIOWnrl93o0W9yRfnjzHy NT032XMp1hFXo56VJAe4LrTAJy3eE/dHu37RBmLt2Zl5j5aNPUg7XgPdeK5Nc0z8l935 msisJ0cQFtktiusujfESKJ+ZOURH6tbRVKt6mnLWAQuba28l/jNyCYQCghrerFGhW0cJ VrTpFPgcobc3NRi5mFK/mbFhgNMIjkl6q6wtEucefdcmM++kvP83i7hObsP1GN96TDcG xrqPzBLivfZkOewyhTOIO+Hq3K1umGyG+P0qUutNW6Dm6RzqofYyRH65wS2ceiYOi19V QUIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=0UT8lst5nDXa5EduKqboY813zRQkbwrz0jocGjjJQg4=; b=e1wEpdhKOMYnX4mc6BL6L4UgVMP58cuZGrBHSekJPa1N/YNnKUMS14kLu6bUnziLPC En3d2tpYLTuiJ5ta42uFPMSaeLd3zbX5o/xmd+t3d3VxbB6nGAwloBXvACz2IyQDaK+3 yyRWFn5uZIQHXDBIy9aWk9JtBLew0fqFPaxlHjtG+ZQhnz12iLktQHeFJB2gero7+ywH Jv+5Pelc0m6yo0NHoudnGMl0IoDeL5GJTbNnoVS1tGCSxri2mj6/DGsjrlvDoNn7oF+s mvZ13ADr6iLGKrsnSfwJ5Gxk+gKGQHNw/ANldzRU9rO6u7MeTrntRxuW5XcNQifAEgfB ehLw== X-Gm-Message-State: AGi0PubKMc0NoRHOmtK1LNULCqe/UQWUO6c0lQY1fjxAIu/kVwIIiiCC 7SvXup21ACGXWiRNnWEQXT4PJw== X-Received: by 2002:a05:620a:5fc:: with SMTP id z28mr27276673qkg.346.1586960856921; Wed, 15 Apr 2020 07:27:36 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id v187sm12740442qkc.29.2020.04.15.07.27.36 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 15 Apr 2020 07:27:36 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jOj0p-0005zU-UU; Wed, 15 Apr 2020 11:27:35 -0300 Date: Wed, 15 Apr 2020 11:27:35 -0300 From: Jason Gunthorpe To: Bernard Metzler Cc: Xiyu Yang , Doug Ledford , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, yuanxzhang@fudan.edu.cn, kjlu@umn.edu, Xin Tan Subject: Re: [PATCH] RDMA/siw: Fix potential siw_mem refcnt leak in nr_add_node Message-ID: <20200415142735.GP5100@ziepe.ca> References: <20200415140910.GN5100@ziepe.ca> <1586939949-69856-1-git-send-email-xiyuyang19@fudan.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 02:16:54PM +0000, Bernard Metzler wrote: > Fine with me in principle, but we would have to return > directly here as well - since we do not have a valid mem > to be put back. Woops, yes, thanks Jason