Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F1184C433F2
Date:   Wed, 15 Apr 2020 08:17:54 -0600
From:   Lina Iyer <ilina@codeaurora.org>
To:     Stephen Boyd <swboyd@chromium.org>
Cc:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [PATCH] soc: qcom: cmd-db: Add debugfs dumping file
Message-ID: <20200415141754.GB3820@codeaurora.org>
References: <20200309185704.2491-1-swboyd@chromium.org>
 <20200414215015.GA3820@codeaurora.org>
 <158693222998.105027.13298557609451842017@swboyd.mtv.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <158693222998.105027.13298557609451842017@swboyd.mtv.corp.google.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Apr 14 2020 at 00:30 -0600, Stephen Boyd wrote:
>Quoting Lina Iyer (2020-04-14 14:50:15)
>> On Mon, Mar 09 2020 at 12:57 -0600, Stephen Boyd wrote:
>> >+              seq_puts(seq, "-------------------------\n");
>> >+
>> >+              ent = rsc_to_entry_header(rsc);
>> >+              for (j = 0; j < le16_to_cpu(rsc->cnt); j++, ent++) {
>> >+                      seq_printf(seq, "0x%08x: %*pEp", le32_to_cpu(ent->addr),
>> 0x%05x is what we would have for a resource address.
>
>Sorry I totally missed this because the mail wasn't trimmed at all and
>it was really hard to find the one line that wasn't quoted!
>
Sorry, my bad. Somehow didn't notice the quoting has changed.

>5 vs. 8 sounds OK to me. Send a patch? Or I can do it if you prefer.
Apart from the nit, I think the patch looks good. Feel free to add -

Reviewed-by: Lina Iyer <ilina@codeaurora.org>
Tested-by: Lina Iyer <ilina@codeaurora.org>