Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp707349ybz; Wed, 15 Apr 2020 17:10:20 -0700 (PDT) X-Google-Smtp-Source: APiQypLs3K8EbrzcdHBY5UhtSOWF4OaCCIgXU2wm6WeogfJyk1yiVuR+yYpe5qwfcsojbKqs4+7g X-Received: by 2002:a50:c850:: with SMTP id s16mr28146487edg.90.1586995820088; Wed, 15 Apr 2020 17:10:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586995820; cv=none; d=google.com; s=arc-20160816; b=kMF5b2jnVduUEfx4ftrQNWUNtFbm6pOGG8TyAaY+Jr4XNTraBLqtTCrdhZofJyNJ1a 8k/5Se30dRCKJvGPAJUIBZqoTQ0GmeybQ01B9T69rlZypN0own7sR8YOLRLPskcUhbye 627Dicy8voDAyXGhLsKTGZSR+YvDIzf8OZgPPulfTsCKHmR7ZHTVqVWfxO3YOxXoaou5 2jkvwKNMfSF3QDsu0LVnyohfwX4FLkLQC+q1b9qpDH3DRXEf1nNLEcUEOf4AdB39syGr VEEvO2c+vXqPbVB1/CPWQq/tc8Z7f6QcaPWD+EO53OI0bd1zItM1pM5FdGJo4OITwnDR wSAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=ei+NuE+HZiAAurqz/oia0GUvfK3A3xVPX/O38dEVSXU=; b=CzWk4NJopFHd3dxLxxBQBD+FSqTBHR/qGEyWDaKH1a5MuvVSlucvlC0PBRmFYaiJp6 Del2Hr3N+/3ooUN6gBLLoe7yVyXPVHOHRkPx1sBouAPJ0f4pJo6UGQGc1keVNsH6oxem 4gMCXNic5etiDiuDiJ6kuHWlbezDi+ey+QdJXkaE0qmm1LHoQlWakcoWRi6txfgZuLiV Kt4RJj7pGDd1TahIBZP9gnwicypS5478gsiFQ73VZQt9HAJz2bJ6mjQ6tPVJcczxg6X8 dQQPjRndGK0b25zSqlK08xVg3DS45MIunplnfkJrKY9dxR+njd0Mi6f5wf2sSPJ9Af1J uOHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org ([23.128.96.18]) by mx.google.com with ESMTP id z92si3604470ede.45.2020.04.15.17.09.57; Wed, 15 Apr 2020 17:10:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634265AbgDOOWn (ORCPT + 99 others); Wed, 15 Apr 2020 10:22:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2391788AbgDOOWa (ORCPT ); Wed, 15 Apr 2020 10:22:30 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 34ED7C061A0F for ; Wed, 15 Apr 2020 07:22:30 -0700 (PDT) Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOivp-0000OA-H5; Wed, 15 Apr 2020 16:22:25 +0200 Received: from ukl by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1jOivp-0008MH-3O; Wed, 15 Apr 2020 16:22:25 +0200 Date: Wed, 15 Apr 2020 16:22:25 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Tang Bin Cc: wsa@the-dreams.de, o.rempel@pengutronix.de, ardb@kernel.org, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Shengju Zhang Subject: Re: [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe() Message-ID: <20200415142225.pxstqwyqvj7ayd6m@pengutronix.de> References: <20200415135734.14660-1-tangbin@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200415135734.14660-1-tangbin@cmss.chinamobile.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote: > In the function efm32_i2c_probe(),when get irq failed,the function > platform_get_irq() logs an error message,so remove redundant message > here. adding a space after each comma seems usual style. > Signed-off-by: Tang Bin > Signed-off-by: Shengju Zhang Usually the Sign-off of the sender comes last. How is Shengju Zhang involved with this patch? > diff --git a/drivers/i2c/busses/i2c-efm32.c b/drivers/i2c/busses/i2c-efm32.c > index a8c6323e7..4de31fae7 100644 > --- a/drivers/i2c/busses/i2c-efm32.c > +++ b/drivers/i2c/busses/i2c-efm32.c > @@ -352,7 +352,6 @@ static int efm32_i2c_probe(struct platform_device *pdev) > > ret = platform_get_irq(pdev, 0); > if (ret <= 0) { > - dev_err(&pdev->dev, "failed to get irq (%d)\n", ret); The change looks fine. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | https://www.pengutronix.de/ |