Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp709100ybz; Wed, 15 Apr 2020 17:12:46 -0700 (PDT) X-Google-Smtp-Source: APiQypL+mnq/wuFt7wnIN3TtIhDsaHrV+SXjTHmKOu9bUbEV9eq/GDBBwhcclWZXN4YxILyqGE42 X-Received: by 2002:a17:906:3291:: with SMTP id 17mr7158519ejw.343.1586995966467; Wed, 15 Apr 2020 17:12:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586995966; cv=none; d=google.com; s=arc-20160816; b=ublp9bEFOZ87ASwihfu5kX85LrvqX/XSh3KUf70sM6HtILpoA4/QLiXBKgKvdq9ogk KJXaRz7OQXkXeZzsAvH/OJ9psretzeYX8RtZv+BPWwjptIf83bBAKrXge9jz8lNizzzv 51R7OXn8qTFOogt8SE1DrYrqixX2Yaih/w+BVSEzT5CBW+jtl07XbRYoNpoXMJY0n7te D6ILlEzybaBG8l3HXSLg71EV5YC9MEonalvZMF0wfwPrAAVfW7M4CeKD9uQIzFw7HFX9 ZDuKunWIVszcW5UGqRfpYiPLTGDTVv5ux6XyEaEejJN9/3+JpQ6+7GTQ+JfX+suj9AgD h2Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=jcswj4fMIzy1VSkpe0j3kCHXPaYoyRFwnxHUU0e019I=; b=Q0z5QSTBykseRzzlkD3ux8k00qL2dfK4R1zagYap23AuH5gfQ4xT8Re0F+EMDWr+GS n7tL+oT2CMk5bLvVzVzZdgjPzeGpDRxKjQNAF/5WrojhGJ8NQCEBiKeEZrFKYhAfi3Z9 Fa7CCaP/JwkBvhtr8pkNXoXYJDlAyAlo+O35FF0n6yWg/lX/gJBASrgLk7yHi4Ok8YqO /eqIrmdZe6Gf1Dxuaan+WBkVbX38jPK00zauGh6Si9Fz/aTl07hT3SfvnbtxAnk01wPq l/D/ZjQ6xCADfLGjecq6SXLZTQ9A3cekY0NP/aiP7rHx4bc4+1+7OpH6bxVaMnMzo63h Ty5g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="X/VB/KtI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a9si10883333edk.466.2020.04.15.17.12.22; Wed, 15 Apr 2020 17:12:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="X/VB/KtI"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2894373AbgDOOna (ORCPT + 99 others); Wed, 15 Apr 2020 10:43:30 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:30215 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1733249AbgDOOmf (ORCPT ); Wed, 15 Apr 2020 10:42:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586961751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jcswj4fMIzy1VSkpe0j3kCHXPaYoyRFwnxHUU0e019I=; b=X/VB/KtIlPs8RqKvLkqQYahNrzV16JhtmeJ1N037/IwNDMekMuzIvmYShQlgwGbBj1Yx+d j5AprWri9WbEf9UdvBoVRRtGrMwkqSf8RkadhSi/MqjeX7Nz0VBu9xU2DxGLOHJTXuyaPT YON+/iJQe1STB9nSPqNq6CXVbChqNho= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-Y1KEESK7MoaD85yEUkY4iQ-1; Wed, 15 Apr 2020 10:42:30 -0400 X-MC-Unique: Y1KEESK7MoaD85yEUkY4iQ-1 Received: by mail-wr1-f69.google.com with SMTP id d17so1832wrr.17 for ; Wed, 15 Apr 2020 07:42:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jcswj4fMIzy1VSkpe0j3kCHXPaYoyRFwnxHUU0e019I=; b=DOD6N+df8FtQivuPmrR7AJrc1a9v9JEOHOePb9m1iF5VSRn9nP9vjKp6fvN+hPXJ7A oWL4bnt7rp1lQPCKd4NALEX5nG01lidf3yw30xnpScpEn7yd4O2+wSCSbM4RQrlH1Gll R/VIDOPh3dDZrL/TN0iAz7baUDgnvkkBZ8YGKRNnMMCAwNXEZbwqX5Wokya5MBChZ9/t s8dudcyPBCVvXTO/NovPVsQ1Qa52LNhokrhyyqYYdmARA9GKwQLPHFDh5MVU36wwsW26 cHjQo76M0ppBHe7cdeiCLvryYgY5SkW/qm8o52UOHoIDiRZkyEMeo5zQxIKjjoJsiFIj iIjA== X-Gm-Message-State: AGi0PuYnkNxfzn8nqsa8mRSRzaa+KBLcPbLoJk1gWpkB0FUDAezwfilu OctdrFqyvPlrH9hb1IrrXUObZgFK9LnX8VEJ/dciY1/7P2WggDs3nwE8/2dj3UB0a9MXRJh3NPJ X4QD9h7+dGmnLT4msiMhucUDZ X-Received: by 2002:a5d:51c6:: with SMTP id n6mr23228102wrv.314.1586961748851; Wed, 15 Apr 2020 07:42:28 -0700 (PDT) X-Received: by 2002:a5d:51c6:: with SMTP id n6mr23228081wrv.314.1586961748565; Wed, 15 Apr 2020 07:42:28 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:9066:4f2:9fbd:f90e? ([2001:b07:6468:f312:9066:4f2:9fbd:f90e]) by smtp.gmail.com with ESMTPSA id j11sm2090904wrr.62.2020.04.15.07.42.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Apr 2020 07:42:27 -0700 (PDT) Subject: Re: [PATCH] x86/kvm: make steal_time static To: Jason Yan , sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hulk Robot References: <20200415084939.6367-1-yanaijie@huawei.com> From: Paolo Bonzini Message-ID: Date: Wed, 15 Apr 2020 16:42:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200415084939.6367-1-yanaijie@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/04/20 10:49, Jason Yan wrote: > Fix the following sparse warning: > > arch/x86/kernel/kvm.c:58:1: warning: symbol '__pcpu_scope_steal_time' > was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan > --- > arch/x86/kernel/kvm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index 6efe0410fb72..f75010cde5d5 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -55,7 +55,7 @@ static int __init parse_no_stealacc(char *arg) > early_param("no-steal-acc", parse_no_stealacc); > > static DEFINE_PER_CPU_DECRYPTED(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64); > -DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible; > +static DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible; > static int has_steal_clock = 0; > > /* > Queued, thanks. Paolo