Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp709114ybz; Wed, 15 Apr 2020 17:12:49 -0700 (PDT) X-Google-Smtp-Source: APiQypKz2l1i9Z5J3JEvx/ZrpqP9tnYrQJxH4aBU/J4ahZukAtseIN57mVux6xlzI8XmIcE2gyh/ X-Received: by 2002:a17:906:3399:: with SMTP id v25mr7081075eja.217.1586995969175; Wed, 15 Apr 2020 17:12:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586995969; cv=none; d=google.com; s=arc-20160816; b=IJUxN8domh+mYKJ9FNTv7hzSdRFXKZoKvgqeHh/trNcmazH5ANApTnBLEI05uZNSdD Jb44CFNbi2J+v9DcPcuruH/crg1851/76kIoE1eWQD+yevqmEndf30qP8VGbt6ldMAW+ w3aXeY6f0aSoMbrWjk0mqt6vagGbuncP3DmKUmpqziyjHFE8URbpaPc3UAN7J+4ZEclm rTRY5/mp+naqhr2hsAuRFPFqLvZQhSUHnjSbhar7PKp03DTUgSghIhjIWKxRGU+Hmkg/ ulaOacmJnswvAWetSPvRlG6Rd+3fpC7TNSUtuyp/vRJTicZkTWx6VhRFP/tPgWbtzpkW DdDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=V0U8DL3YBiZnvlswRWW65vlKQ6lUrl59VOqI15gm5vo=; b=CprZA5S+HJE6CYJGQ35GzNsxXE0Xw4sdfj9ilegkAKiu0U9ae7zZXGm/FaLU68y+0+ XgqAJyO9V0LeU3660sQd8RUjcpEMAqOREey5yiP+ldMg4D2fAQLSi0c+0xg+6kJqFlD/ GMnQrLP8gAiNxvrsPHCyXZhP0fkjlnzEcZy92riHz8tkxJBQGF87guauiCcFb2lZ14SA BiJq5zR8iqD5DycDaLeotWHwDU5sbDqxPNAD0grkUPzKWgx48rDMjlh1firMWlEWfR1O Dt7g3kQqtPyfGFUrmdT7z6oEgavERPNwMOmniiF05lzKK4TKa8wWsge+SUlPoV79RwZq YHmw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c24si11256162eds.119.2020.04.15.17.12.26; Wed, 15 Apr 2020 17:12:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S371174AbgDOO4k (ORCPT + 99 others); Wed, 15 Apr 2020 10:56:40 -0400 Received: from mga12.intel.com ([192.55.52.136]:42692 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S371095AbgDOOzw (ORCPT ); Wed, 15 Apr 2020 10:55:52 -0400 IronPort-SDR: 3xL3wAuJ140/u/8yEDyljI74ygBkNAxXAJl41mQLg2DvRpz0JmNtNevcc4lXL9xsLqkwmtG86n HXLM4QOoxUaA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 07:55:46 -0700 IronPort-SDR: nzBlDhgxLA/Vu41w8tUzhGXWrxA3Og/z70ebDgo7iz/xKPtB3kUMt5eQYwDOi7R1LzXF6yRba0 na6mea+rQMPg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,387,1580803200"; d="scan'208";a="245709874" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 15 Apr 2020 07:55:44 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 61499CA1; Wed, 15 Apr 2020 17:55:40 +0300 (EEST) From: Andy Shevchenko To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Mark Brown , linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v4 7/9] platform/x86: surface3_wmi: Switch DMI table match to a test of variable Date: Wed, 15 Apr 2020 17:55:22 +0300 Message-Id: <20200415145524.31745-8-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415145524.31745-1-andriy.shevchenko@linux.intel.com> References: <20200415145524.31745-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since we have a common x86 quirk that provides an exported variable, use it instead of local DMI table match. Signed-off-by: Andy Shevchenko --- drivers/platform/x86/surface3-wmi.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/platform/x86/surface3-wmi.c b/drivers/platform/x86/surface3-wmi.c index 130b6f52a600..5eeedc4ddb8a 100644 --- a/drivers/platform/x86/surface3-wmi.c +++ b/drivers/platform/x86/surface3-wmi.c @@ -11,9 +11,9 @@ #include #include -#include #include #include +#include #include #include @@ -29,18 +29,6 @@ MODULE_LICENSE("GPL"); MODULE_ALIAS("wmi:" SURFACE3_LID_GUID); -static const struct dmi_system_id surface3_dmi_table[] = { -#if defined(CONFIG_X86) - { - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "Microsoft Corporation"), - DMI_MATCH(DMI_PRODUCT_NAME, "Surface 3"), - }, - }, -#endif - { } -}; - struct surface3_wmi { struct acpi_device *touchscreen_adev; struct acpi_device *pnp0c0d_adev; @@ -201,7 +189,7 @@ static int __init s3_wmi_probe(struct platform_device *pdev) { int error; - if (!dmi_check_system(surface3_dmi_table)) + if (!x86_microsoft_surface_3_machine) return -ENODEV; memset(&s3_wmi, 0, sizeof(s3_wmi)); -- 2.25.1