Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp710196ybz; Wed, 15 Apr 2020 17:14:24 -0700 (PDT) X-Google-Smtp-Source: APiQypKq5yGDfjbC8txXV0YsEgUmxU1XEoC33+3I9O2Oh5WNesyhVClCUd0DznEpQ5rgPoJcsq3L X-Received: by 2002:a17:907:1185:: with SMTP id uz5mr7449494ejb.335.1586996064488; Wed, 15 Apr 2020 17:14:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1586996064; cv=none; d=google.com; s=arc-20160816; b=HRMTUyeLKHq+9PR7I0tASUqbNwQzB53qOOwa7WSYDNJD20T4H00ky+FJFj6FOUXbmu +NM+HHyhFMpS0FBF14mAhZaJHQV4HM6iz7sdkCOGA+px9p9kpB1PuhkOheW41n2yPFgQ mC0UDlh7MJiL3J0io8YH2qj/aR5AZHb8oC0bAXBHxn2d8uxx0Zz0ksmS55/NNIh59V4i eadovOuXbWf3Bzp1jk5w0q2H3Q2sJ9TquevXk98rClZr+SroB+K68i38Bhb1RPsxxKT7 NsoyjWDW+0nNA9I9K/iyhc4Gw/Q+Iv1ewEMS/PddZ/8YB2kpVih9PgTefe8Iio6o/4/d Px4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :ironport-sdr:ironport-sdr; bh=MCF0miU1OegHk7MO/uYP49POf3eE2pLodRdWSNHlfkg=; b=Nv3aJaznwvE2PWesN1QDKKSldpoMRYAtjKps1kNzMY4663QBfOUOU/SHXuo9bP3sfC eKy9YbXpKoWesPBaLG8wlM9gg/jJ+wCWNffivLc6IvA7LNWXIaHacJdEO8XAytnhkSOU xD7UmcrvccyBpcs9p093TAVbgiTkSVobxOoUOzh1lTMejI487rqckYNodxiR+iSEbhgc rPwe37HkVv69y8ijmEibwYWFYkhqk4qWfrXqSa3r3nYkxZGr12HKuQnHIuGVmomJcjB8 V3nAXkzOpaXDg6PjzlKBnAcDZ73Un/4VISud229Y6wnBjPTGXjhr0pb12XZzcCZbHJRo ravg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si11269263ejv.507.2020.04.15.17.14.01; Wed, 15 Apr 2020 17:14:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S371097AbgDOOzx (ORCPT + 99 others); Wed, 15 Apr 2020 10:55:53 -0400 Received: from mga11.intel.com ([192.55.52.93]:46559 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S371076AbgDOOzo (ORCPT ); Wed, 15 Apr 2020 10:55:44 -0400 IronPort-SDR: sgkIa+bN6RBlI0We6qm8R3eQoARu8D8ZnUFH9iJ+Hgdtmk9VrIhb/sJ7UThcHQi+z4I0l3S3NV e5kA/W1JiT6g== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Apr 2020 07:55:43 -0700 IronPort-SDR: wPwkqQeLhVw38AdafLLi1V2EaLmpDlmcaqVOBg7cGjpbzZfs8hzyKIWVcpjrYw15mLG2dUE/AN H3J0+k5YRfzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,387,1580803200"; d="scan'208";a="332520439" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga001.jf.intel.com with ESMTP; 15 Apr 2020 07:55:41 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 4670E76D; Wed, 15 Apr 2020 17:55:40 +0300 (EEST) From: Andy Shevchenko To: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Mark Brown , linux-kernel@vger.kernel.org Cc: Andy Shevchenko Subject: [PATCH v4 4/9] x86/quirks: Join string literals back Date: Wed, 15 Apr 2020 17:55:19 +0300 Message-Id: <20200415145524.31745-5-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200415145524.31745-1-andriy.shevchenko@linux.intel.com> References: <20200415145524.31745-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is no need to split string literals. Moreover, it would be simpler to grep for an actual code line, when debugging, by using almost any part of the string literal in question. No functional change intended. Signed-off-by: Andy Shevchenko --- arch/x86/kernel/quirks.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/arch/x86/kernel/quirks.c b/arch/x86/kernel/quirks.c index 0313016f6756..091d03cfbb1e 100644 --- a/arch/x86/kernel/quirks.c +++ b/arch/x86/kernel/quirks.c @@ -36,8 +36,7 @@ static void quirk_intel_irqbalance(struct pci_dev *dev) pci_bus_read_config_word(dev->bus, PCI_DEVFN(8, 0), 0x4c, &word); if (!(word & (1 << 13))) { - dev_info(&dev->dev, "Intel E7520/7320/7525 detected; " - "disabling irq balancing and affinity\n"); + dev_info(&dev->dev, "Intel E7520/7320/7525 detected; disabling irq balancing and affinity\n"); noirqdebug_setup(""); #ifdef CONFIG_PROC_FS no_irq_affinity = 1; @@ -110,16 +109,14 @@ static void ich_force_enable_hpet(struct pci_dev *dev) pci_read_config_dword(dev, 0xF0, &rcba); rcba &= 0xFFFFC000; if (rcba == 0) { - dev_printk(KERN_DEBUG, &dev->dev, "RCBA disabled; " - "cannot force enable HPET\n"); + dev_printk(KERN_DEBUG, &dev->dev, "RCBA disabled; cannot force enable HPET\n"); return; } /* use bits 31:14, 16 kB aligned */ rcba_base = ioremap(rcba, 0x4000); if (rcba_base == NULL) { - dev_printk(KERN_DEBUG, &dev->dev, "ioremap failed; " - "cannot force enable HPET\n"); + dev_printk(KERN_DEBUG, &dev->dev, "ioremap failed; cannot force enable HPET\n"); return; } @@ -149,8 +146,7 @@ static void ich_force_enable_hpet(struct pci_dev *dev) if (err) { force_hpet_address = 0; iounmap(rcba_base); - dev_printk(KERN_DEBUG, &dev->dev, - "Failed to force enable HPET\n"); + dev_printk(KERN_DEBUG, &dev->dev, "Failed to force enable HPET\n"); } else { force_hpet_resume_type = ICH_FORCE_HPET_RESUME; hpet_dev_print_force_hpet_address(&dev->dev); @@ -182,8 +178,7 @@ static struct pci_dev *cached_dev; static void hpet_print_force_info(void) { - printk(KERN_INFO "HPET not enabled in BIOS. " - "You might try hpet=force boot option\n"); + printk(KERN_INFO "HPET not enabled in BIOS. You might try hpet=force boot option\n"); } static void old_ich_force_hpet_resume(void) -- 2.25.1