Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: zGKqt3C8w7ws8MNP5NCW7PnywU9OBA/uVaA8cc7OW/KRKh05CivIUcWVgYA/ul97qDWFWF0mB6
 Gk4fHJqPLfvw==
IronPort-SDR: Rf+juQm0Yt6R8lmJypCUfmc+JoYx3NpXXd7JAaHqBYrZszR0KYEpcET01tBskpX40qybNGpPA9
 4ufVIcsVg4ow==
From:   "Kaneda, Erik" <erik.kaneda@intel.com>
To:     Jason Yan <yanaijie@huawei.com>,
        "Moore, Robert" <robert.moore@intel.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@intel.com>,
        "lenb@kernel.org" <lenb@kernel.org>,
        "linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
        "devel@acpica.org" <devel@acpica.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
CC:     Hulk Robot <hulkci@huawei.com>
Subject: RE: [PATCH] ACPICA: make acpi_protocol_lengths static
Thread-Topic: [PATCH] ACPICA: make acpi_protocol_lengths static
Thread-Index: AQHWEv87r4iBQd2ks0mDcH38j9TePqh6Whag
Date:   Wed, 15 Apr 2020 16:09:15 +0000
Message-ID: <CY4PR11MB171926DECDFC37ED7EF00623F0DB0@CY4PR11MB1719.namprd11.prod.outlook.com>
References: <20200415084933.6251-1-yanaijie@huawei.com>
In-Reply-To: <20200415084933.6251-1-yanaijie@huawei.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.2.0.6
dlp-product: dlpe-windows
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 1c0dc6ef-f556-4e9d-c5d4-08d7e1575855
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Apr 2020 16:09:15.5185
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BNpI1UHV93+oVDYhpWeKVeZuqC+/ZK36G86Rgz+Rw19TwQ37T8PrTw4rDnKBsBIzvxYbKg5SurdresbczRPlQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR11MB1573
X-OriginatorOrg: intel.com
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jason Yan <yanaijie@huawei.com>
> Sent: Wednesday, April 15, 2020 1:50 AM
> To: Moore, Robert <robert.moore@intel.com>; Kaneda, Erik
> <erik.kaneda@intel.com>; Wysocki, Rafael J <rafael.j.wysocki@intel.com>;
> lenb@kernel.org; linux-acpi@vger.kernel.org; devel@acpica.org; linux-
> kernel@vger.kernel.org
> Cc: Jason Yan <yanaijie@huawei.com>; Hulk Robot <hulkci@huawei.com>
> Subject: [PATCH] ACPICA: make acpi_protocol_lengths static
>=20
> Fix the following sparse warning:
>=20
> drivers/acpi/acpica/exfield.c:25:10: warning: symbol 'acpi_protocol_lengt=
hs'
> was not declared. Should it be static?

This has already been reported and I've made the appropriate fix in the ACP=
ICA code base already. it should be available in the next ACPICA release

Thanks,
Erik
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
> ---
>  drivers/acpi/acpica/exfield.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/acpi/acpica/exfield.c b/drivers/acpi/acpica/exfield.=
c index
> e85eb31e5075..3323a2ba6a31 100644
> --- a/drivers/acpi/acpica/exfield.c
> +++ b/drivers/acpi/acpica/exfield.c
> @@ -22,7 +22,7 @@ ACPI_MODULE_NAME("exfield")
>   */
>  #define ACPI_INVALID_PROTOCOL_ID        0x80
>  #define ACPI_MAX_PROTOCOL_ID            0x0F
> -const u8 acpi_protocol_lengths[] =3D {
> +static const u8 acpi_protocol_lengths[] =3D {
>  	ACPI_INVALID_PROTOCOL_ID,	/* 0 - reserved */
>  	ACPI_INVALID_PROTOCOL_ID,	/* 1 - reserved */
>  	0x00,			/* 2 - ATTRIB_QUICK */
> --
> 2.21.1