Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: A6B7A6n8zrP/rW8f/Fhs1fhhbQeWKUKnBXCDmA0CTVbDznYIAIOHEhjXJWyT0AuZszyRjpv0bX
 MAqopJjTR4/g==
IronPort-SDR: yeFr25nu7wUsN0oZLW8B8a5+hflpUXCHjTPFobsrRNazhu++pVLS18x2KbdAmVasHFl6s3goVC
 pe1+wU4Uk04A==
Date:   Wed, 15 Apr 2020 19:10:43 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Prarit Bhargava <prarit@redhat.com>
Cc:     linux-kernel@vger.kernel.org,
        Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] tools/power/x86/intel-speed-select: Fix CLX-N package
 information output
Message-ID: <20200415161043.GU185537@smile.fi.intel.com>
References: <20200402180732.24684-1-prarit@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200402180732.24684-1-prarit@redhat.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 02, 2020 at 02:07:32PM -0400, Prarit Bhargava wrote:
> On CLX-N the perf-profile output is missing the package, die, and cpu
> output.  On CLX-N the pkg_dev struct will never be evaluated by the core
> code so pkg_dev.processed is always 0 and the package, die, and cpu
> information is never output.
> 
> Set the pkg_dev.processed flag to 1 for CLX-N processors.

I will accept this with PR from Srinivas whenever he sends one to public mailing list.

> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Cc: andriy.shevchenko@linux.intel.com
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: platform-driver-x86@vger.kernel.org
> ---
>  tools/power/x86/intel-speed-select/isst-config.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/power/x86/intel-speed-select/isst-config.c b/tools/power/x86/intel-speed-select/isst-config.c
> index d1ac57be0cbd..2e64b9b6eb2e 100644
> --- a/tools/power/x86/intel-speed-select/isst-config.c
> +++ b/tools/power/x86/intel-speed-select/isst-config.c
> @@ -1169,6 +1169,7 @@ static void dump_clx_n_config_for_cpu(int cpu, void *arg1, void *arg2,
>  
>  		ctdp_level = &clx_n_pkg_dev.ctdp_level[0];
>  		pbf_info = &ctdp_level->pbf_info;
> +		clx_n_pkg_dev.processed = 1;
>  		isst_ctdp_display_information(cpu, outf, tdp_level, &clx_n_pkg_dev);
>  		free_cpu_set(ctdp_level->core_cpumask);
>  		free_cpu_set(pbf_info->core_cpumask);
> -- 
> 2.18.2
> 

-- 
With Best Regards,
Andy Shevchenko