Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 15 Apr 2020 17:25:07 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
        Liam Girdwood <liam.r.girdwood@linux.intel.com>,
        Jie Yang <yang.jie@linux.intel.com>,
        alsa-devel@alsa-project.org
Subject: Re: [PATCH v4 8/9] ASoC: rt5645: Switch DMI table match to a test of
 variable
Message-ID: <20200415162507.GG5265@sirena.org.uk>
References: <20200415145524.31745-1-andriy.shevchenko@linux.intel.com>
 <20200415145524.31745-9-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="/Zw+/jwnNHcBRYYu"
Content-Disposition: inline
In-Reply-To: <20200415145524.31745-9-andriy.shevchenko@linux.intel.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--/Zw+/jwnNHcBRYYu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Apr 15, 2020 at 05:55:23PM +0300, Andy Shevchenko wrote:
> Since we have a common x86 quirk that provides an exported variable,
> use it instead of local DMI table match.
>=20
> Note, arch/x86/kernel/quirks.c::early_platform_detect_quirk() prints
> the detected platform.

> @@ -3674,13 +3675,6 @@ static const struct dmi_system_id dmi_platform_dat=
a[] =3D {
>  		},
>  		.driver_data =3D (void *)&intel_braswell_platform_data,
>  	},
> -	{
> -		.ident =3D "Microsoft Surface 3",
> -		.matches =3D {
> -			DMI_MATCH(DMI_PRODUCT_NAME, "Surface 3"),
> -		},
> -		.driver_data =3D (void *)&intel_braswell_platform_data,
> -	},
>  	{

Are we going to convert all the other platforms to using a variable too?

--/Zw+/jwnNHcBRYYu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6XNWIACgkQJNaLcl1U
h9CV0wf/em9G/ERwnZy11DLRg2vrxZxULM/L8dpShtUtkEt3v/SYJ85NTVR9CAJD
vjbPS3J/WeRpLmdCalBk8O/QTApngJnK/q4xz0v+/qaYTWQYwlE+NXvsHa1l70Fb
v5H1hEMwq+2ZeDv3TwU0yAuDK2HlC/IDlppdWDGT5k5tQDAaCVzbs8sMm8fbCa2b
avEyI1dX3f9ovT6qZUiFEhudRVXLKrb56f7pecBIXtP/jalNrZ8MtKGxNHgDzDzf
tpXHfW9UH+7cvEn2ZShxvm6O++ye1gmRlzfnHLtf0Y7qlGN1dTVlVgJ2Vw1DubvW
9SJPbBT5dfSidGq/aedmAqzpVbddKQ==
=HWhC
-----END PGP SIGNATURE-----

--/Zw+/jwnNHcBRYYu--