Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932277AbWCANRq (ORCPT ); Wed, 1 Mar 2006 08:17:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932274AbWCANRq (ORCPT ); Wed, 1 Mar 2006 08:17:46 -0500 Received: from lucidpixels.com ([66.45.37.187]:9603 "EHLO lucidpixels.com") by vger.kernel.org with ESMTP id S932241AbWCANRp (ORCPT ); Wed, 1 Mar 2006 08:17:45 -0500 Date: Wed, 1 Mar 2006 08:17:42 -0500 (EST) From: Justin Piszcz X-X-Sender: jpiszcz@p34 To: Mark Lord cc: "Eric D. Mudama" , Jeff Garzik , David Greaves , Tejun Heo , linux-kernel@vger.kernel.org, IDE/ATA development list , albertcc@tw.ibm.com, axboe@suse.de, Linus Torvalds Subject: Re: LibPATA code issues / 2.6.15.4 In-Reply-To: <4404F31D.90407@rtr.ca> Message-ID: References: <4401122A.3010908@rtr.ca> <44017B4B.3030900@dgreaves.com> <4401B560.40702@rtr.ca> <4403704E.4090109@rtr.ca> <4403A84C.6010804@gmail.com> <4403CEA9.4080603@rtr.ca> <44042863.2050703@dgreaves.com> <44046CE6.60803@rtr.ca> <44046D86.7050809@pobox.com> <311601c90602280857x3f102af5l31c9a0ac1a896b4e@mail.gmail.com> <4404F31D.90407@rtr.ca> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1482 Lines: 52 On Tue, 28 Feb 2006, Mark Lord wrote: > Eric D. Mudama wrote: >> those drives should support all FUA opcodes properly, both queued and >> unqueued > > His first drive (sda) does not support queued commands at all, > but the newer firmware in his second drive (sdb) does support NCQ. > > Both drives support FUA. > > cheers > Could someone *PLEASE* produce a *unified* patch that is compatible with 2.6.16-rc5 or 2.6.15.4 so I can reproduce the error? Mark had two patches, I have had the most PIA time getting them to work, patch properly, etc.. With 2.6.16-rc5: # make bzImage CHK include/linux/version.h scripts/kconfig/conf -s arch/i386/Kconfig # # using defaults found in .config # SPLIT include/linux/autoconf.h -> include/config/* CHK include/linux/compile.h CHK usr/initramfs_list GEN .version CHK include/linux/compile.h UPD include/linux/compile.h CC init/version.o LD init/built-in.o LD .tmp_vmlinux1 drivers/built-in.o: In function `ata_to_sense_error': undefined reference to `print' drivers/built-in.o: In function `ata_to_sense_error': undefined reference to `print' make: *** [.tmp_vmlinux1] Error 1 Command exited with non-zero status 2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/