Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp785290ybz; Wed, 15 Apr 2020 19:02:24 -0700 (PDT) X-Google-Smtp-Source: APiQypJyJ4kayBDEqSf7D5aDQQEOWJwixvNSpN1x+IOR1SVKbvXmfeSwK3zo/a2Tat+tDC47up1r X-Received: by 2002:aa7:d794:: with SMTP id s20mr15640626edq.141.1587002543864; Wed, 15 Apr 2020 19:02:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587002543; cv=none; d=google.com; s=arc-20160816; b=nKDhtu7LLBblmBz2Z4vQ8p09sKyaumVFwer6L4J3fSRTZxCoYO2odyh5FO/9TMhqzq fkLQBTS11eSiepq9iFyKd1j3ckZyK+ZPAMgJRYMzsFBuxSbn77DsRlmQ5aCb9E7UtPaa mAT8DKDfoIh/GAN3+WFqAXy08JYXnqL+4sr/oPxoC0+w1WmLIpfvGW9WpzEeiPVcP7QF HeeEj7yXSwdPSV4II6lF1tEhlAQ+owSdJ13P/sE7PE8jXmh41wACkVkRl9aGUcGOVKKw BHQL67/5ALLl0x/dJz0ywSFYAIkFZHWHnuu+wJLUAXs1Auhw/O3OWI1IJZuh2BKSYTWX TtKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=QFC4ubHL4pw0hfA7mOXu2wqCbGfdlf8O8kZywOtM/38=; b=PVeqqDlUu+HLWy5IaYUbNWyKUoqeKV1NJf+P48dehTzn79jR/9qNHMT0eKOMPOstXB MPUSzXhtdidlvaG++mAI+9j5I1fYLb2FAXYxFv6gnRaltCVHPfunpAM/EuO62vuJJ823 XLBXrpha5ZF0myQe52fQjGr8eigugLLIQoN/gJBbuo456iOox3oOciWHywXgFuwcaIFs NYw7DgmxA6EArz3hz0y63qQXq9l4A8om28hqY2gm96Pwq4yG0rkhsVpJ8cEPcAn7tLuQ D6B1H9Uof97lDtYNv0t+Gd/L9Fmnh9k0bQ0dsk8cz6wDzQZvVSKl/FVKrFcionBM6U9N 9LpA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g5si10469419ejm.120.2020.04.15.19.02.01; Wed, 15 Apr 2020 19:02:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730768AbgDPCBD (ORCPT + 99 others); Wed, 15 Apr 2020 22:01:03 -0400 Received: from out30-54.freemail.mail.aliyun.com ([115.124.30.54]:60307 "EHLO out30-54.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729707AbgDPCAw (ORCPT ); Wed, 15 Apr 2020 22:00:52 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R851e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e07488;MF=tianjia.zhang@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0Tveg8zr_1587002446; Received: from 30.27.118.45(mailfrom:tianjia.zhang@linux.alibaba.com fp:SMTPD_---0Tveg8zr_1587002446) by smtp.aliyun-inc.com(127.0.0.1); Thu, 16 Apr 2020 10:00:47 +0800 Subject: Re: [PATCH] KVM: Optimize kvm_arch_vcpu_ioctl_run function To: Paolo Bonzini , Vitaly Kuznetsov Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, maz@kernel.org, james.morse@arm.com, julien.thierry.kdev@gmail.com, suzuki.poulose@arm.com References: <20200413034523.110548-1-tianjia.zhang@linux.alibaba.com> <875ze2ywhy.fsf@vitty.brq.redhat.com> <87a73dxgk6.fsf@vitty.brq.redhat.com> <9e122372-249d-3d93-99ed-a670fff33936@redhat.com> From: Tianjia Zhang Message-ID: <4843f690-7071-aa4f-cc9d-d9cc2321e669@linux.alibaba.com> Date: Thu, 16 Apr 2020 10:00:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <9e122372-249d-3d93-99ed-a670fff33936@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/15 22:53, Paolo Bonzini wrote: > On 15/04/20 11:07, Vitaly Kuznetsov wrote: >> In case this is no longer needed I'd suggest we drop 'kvm_run' parameter >> and extract it from 'struct kvm_vcpu' when needed. This looks like a >> natural add-on to your cleanup patch. > > I agree, though I think it should be _instead_ of Tianjia's patch rather > than on top. > > Paolo > Thank you very much for the comments of Vitaly and Paolo, I will make a v2 patch. Thanks and best, Tianjia