Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp831001ybz; Wed, 15 Apr 2020 20:13:00 -0700 (PDT) X-Google-Smtp-Source: APiQypINJ4Fs04VR5rmGgUS6vyA0Y2VJGBfncY3Q50pkrdIksXE57gB1S071CKkJQDcGhszbhl5J X-Received: by 2002:a50:b061:: with SMTP id i88mr28510197edd.325.1587006780276; Wed, 15 Apr 2020 20:13:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587006780; cv=none; d=google.com; s=arc-20160816; b=tM44DLnRHWia9N+/o2wQ7QbISP2j215AiI3g72IRgtP3mgUlny6PpJkdQs+wScV2Sx DL0QyIQZg7tXGozc6q/3WjtBjCMzSQkRZYyuCWByjesdytpUUPLCwid0LoeamgGDLHtV uZ3S5ZsbZ1Xt+P49K0NPLG0w/lTYJYKNWqZwNVXmCabAj7DnGoZfuu3dy9ZUeWenlHfj bJTiLSqYFDlq4iwaRtRElmWKoF7C4S3tt5jM2UP3qkJZ6DO0i4ZlmpQ+vAAV+uqPdZzW /9ii4oo6hnGuJL6/FtjovHAUkK+c0mlbZWDakus2JKqc81pN2/BrZgCTaO9mFLmOqRm6 tcvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=kvQz41+YJ6K8MZlwaic6g1JoTDzmLdupa02Hek26+Fw=; b=kO6JtlwZdwIsCD8PsDbmx91tvxKUv/indSnGMo3EDqEt5v7VSFMpQ1JF/d0tfbvR8d tJPHQzt3w+kv00zWuNvMBkQDJcIzPeZSJAGnw2594PKDQape2cdrJf7OyIi64Qx+QAzG e3VVznmQrRFokt/jS9mgDNr2L4pJ2J9pr8xBDTTdbJjnhugTHpYgfnKE7s6R8kJjcRF0 XgXArmUOoIKyIOX98ctsa8ycqM6caeW8BY4WRMbmUt3GkdxqtpBFqImjtuzhbwlGkfkm fJtlR/mMuQjWoGymDQCOFIxeuljadyEIcshKTspUd4d0jKipcY+VxyQFEva/MTd789xH cLoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=OiqRjo6F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ce9si10482872ejb.154.2020.04.15.20.12.35; Wed, 15 Apr 2020 20:13:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=OiqRjo6F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389486AbgDPDKf (ORCPT + 99 others); Wed, 15 Apr 2020 23:10:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2388679AbgDPDKc (ORCPT ); Wed, 15 Apr 2020 23:10:32 -0400 Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E89CDC061A0C for ; Wed, 15 Apr 2020 20:10:31 -0700 (PDT) Received: by mail-oi1-x231.google.com with SMTP id o25so15422316oic.11 for ; Wed, 15 Apr 2020 20:10:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=kvQz41+YJ6K8MZlwaic6g1JoTDzmLdupa02Hek26+Fw=; b=OiqRjo6FQ0/ABr0U7Pqk6ZHzf31I3Rnbctlzd4kIDtL1DK5iq3IWT/wqPpwH27Pp7e VlRyTRKgezkk8yFc0gP2eGd/Yiwa5aWyWYXd0+Kup/qUsMrBrl57Xc8kpo5e26+xr+BF bNwvP2u0qnt3Anad6hBZvjeDumm1uTtOGHgUscBQZ5a0HoTvTF7/1221uEcPayiwAhDM 1M3tgJNQw0tcqoGgK2rpjZ+zcOLxoPr0fDvcvfAzLdndWhnglfvY1R/DJtcSjZA7sz5b KEybyy6Iz5rOgJu/jwBY/WaQM01Ss97RWhBsB919mkmJnnbj0WX0FkD+qCwTD3g1ESvx enFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=kvQz41+YJ6K8MZlwaic6g1JoTDzmLdupa02Hek26+Fw=; b=ehNwNAsos2W8o1EGAluVcZtyEgzUyfXqcWtqQ8he8JWJFft2s7fVvFYUmvZNZgTwAu +8s8X3kWb4WyeIciavUCksq2aqqF+1SdoilcT31Cz7xvYU7hyTvwch+E/Q7pX/Kf5QJo RqGIB/Ru+qOmgc18lEFIoZmi05GcG19vVg5itY9PAUkFom1mgHvWyLY484b2225Au6Mi xN+30D5GxZw9BVdMpt+dmmIIyEiMvQiT3rOJzVh9aj3eP3WKjr8Rm1FVUI8hoObNJxJz 2Q6uhRMKzrsYjx3matHBrD505mV8nvXFb41ddfJd+xhWvy67qlziDZaf7ZayZ09FMf89 hDXw== X-Gm-Message-State: AGi0PuaEf9lcJ6tyO9YgV01tPrZ3f67onIYHum7HNLHg00C174suq25w XnPijnZSUMM3mY+XhibVfqvqsg== X-Received: by 2002:aca:cd0e:: with SMTP id d14mr1528914oig.167.1587006631069; Wed, 15 Apr 2020 20:10:31 -0700 (PDT) Received: from eggly.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id j17sm6769815otp.58.2020.04.15.20.10.29 (version=TLS1 cipher=ECDHE-ECDSA-AES128-SHA bits=128/128); Wed, 15 Apr 2020 20:10:30 -0700 (PDT) Date: Wed, 15 Apr 2020 20:10:15 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@eggly.anvils To: Yang Shi cc: Hugh Dickins , syzbot , Andrew Morton , Linux Kernel Mailing List , Linux MM , syzkaller-bugs@googlegroups.com Subject: Re: possible deadlock in shmem_mfill_atomic_pte In-Reply-To: Message-ID: References: <000000000000571acf05a229cb2f@google.com> User-Agent: Alpine 2.11 (LSU 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Apr 2020, Yang Shi wrote: > > Thanks, Hugh. I believe this commit could fix the splat. I'm trying to > push my test tree to github to let syzkaller test it. I will send the > formal patch once I get it tested. It is just slow to push to github, > less than 50KB/s... Your diligence is admirable. With straightforward ones like this, I tend to just rely on syzbot to call me out later if I've bluffed. Hugh