Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp948764ybz; Wed, 15 Apr 2020 23:12:46 -0700 (PDT) X-Google-Smtp-Source: APiQypJfh6EZrXwIZ8N4GKL+eaVulHVRygRLoMmm8MA8fuRsPFKsSEsVoeWk8sB2fkR5UJaVgYcm X-Received: by 2002:a50:b003:: with SMTP id i3mr28315323edd.303.1587017566278; Wed, 15 Apr 2020 23:12:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587017566; cv=none; d=google.com; s=arc-20160816; b=ufnvvHRCfM4xQBtDbmVBapyH/qU+oeO4Tje85JdqQgDHhXZCIE8dcCLXwNGjZU2ImL xAtcVhf1OdKiyyXNAB5TS/tvdLd3wWdLiSn5xTC25U1pojFKwaLesNrEcKQcLZPYC6yE E21iAM4AIp4s4aHO7N/hJNLQcjgekJyeUMUnkLvfCGb79Wz86LofiTOh/6+14bjpdTL7 XEKoeemEWX9TRm51kCn9tiMLQ82LWYfq4rzNlWBiSeUjLRD0BTZnT5ftwmsXrBsW41oU CcTnjffEt4UD1W//UADLoXIe5jIEC0n/0mSlp1WKB9Fp5A74LNFFZzNNcOkqHXYeJdni I6Ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=AJl8yn2emNw8zIztxEXXpkV98kDEJjTwQ7xdRzxp530=; b=yNY+4mC/Gdt+f0Dno+l3iXhNaEDtHAmrQi7dGekg7J4oGJh36KkBqz6fa/U1fzrND7 dVq5747wVOL3W7kKSJ4NgdnhSGYerLere9auav7jtCM5ajpAmZyNXt5R2Ma0NLzE7Y1O yuxtFv1QDf1ekJms/AHjLWg6n6SNbAOijD8hU+9SPng5HN2CyO1pB/stj3hNyrWfkgc/ Wo/8NC/QsUvkt8i3/xMmaN+IIZ33628f6FKCBZA4GKKAUoGFJPhJ2UeQs6ZH6BuaseQB 2Bl8tVbk4U4aW2fYsJ3ISKdOMk42H+VAryI51E/PiTthtVUj314+nXeNAP5pGJGKlZNb eT+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id oh24si11317822ejb.531.2020.04.15.23.12.23; Wed, 15 Apr 2020 23:12:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436549AbgDPGKo (ORCPT + 99 others); Thu, 16 Apr 2020 02:10:44 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:2379 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2407402AbgDPGKf (ORCPT ); Thu, 16 Apr 2020 02:10:35 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C34421E7C8418E60C631; Thu, 16 Apr 2020 14:10:25 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.202) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 16 Apr 2020 14:10:21 +0800 Subject: Re: [PATCH v5] f2fs: fix long latency due to discard during umount To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1586941673-4296-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Thu, 16 Apr 2020 14:10:20 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1586941673-4296-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/15 17:07, Sahitya Tummala wrote: > F2FS already has a default timeout of 5 secs for discards that > can be issued during umount, but it can take more than the 5 sec > timeout if the underlying UFS device queue is already full and there > are no more available free tags to be used. Fix this by submitting a > small batch of discard requests so that it won't cause the device > queue to be full at any time and thus doesn't incur its wait time > in the umount context. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks,