Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Jason Yan'" <yanaijie@huawei.com>
Cc:     <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <sj1557.seo@samsung.com>
In-Reply-To: <20200414120225.35540-1-yanaijie@huawei.com>
Subject: RE: [PATCH] exfat: remove the assignment of 0 to bool variable
Date:   Thu, 16 Apr 2020 15:34:33 +0900
Message-ID: <003f01d613b9$17864000$4692c000$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQHfREGer/8Wwi5J5+kbn3sveF3gFwD0yP6kqGFCiRA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <CGME20200414113819epcas1p4eafa861bec639fcdcb931fb68c1086ce@epcas1p4.samsung.com>
        <20200414120225.35540-1-yanaijie@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> There is no need to init 'sync' in exfat_set_vol_flags().
> This also fixes the following coccicheck warning:
> 
> fs/exfat/super.c:104:6-10: WARNING: Assignment of 0/1 to bool variable
> 
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Pushed it to exfat dev.

Thanks for your patch!
> ---
>  fs/exfat/super.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/exfat/super.c b/fs/exfat/super.c index
> 16ed202ef527..b86755468904 100644
> --- a/fs/exfat/super.c
> +++ b/fs/exfat/super.c
> @@ -101,7 +101,7 @@ int exfat_set_vol_flags(struct super_block *sb,
> unsigned short new_flag)  {
>  	struct exfat_sb_info *sbi = EXFAT_SB(sb);
>  	struct pbr64 *bpb;
> -	bool sync = 0;
> +	bool sync;
> 
>  	/* flags are not changed */
>  	if (sbi->vol_flag == new_flag)
> --
> 2.21.1