Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp971075ybz; Wed, 15 Apr 2020 23:47:38 -0700 (PDT) X-Google-Smtp-Source: APiQypJcc0nPL/5Fgm+vSPn7qkxrZIfaLZmLtCbBa0kZ3DpKP6/eZIoVIfFcaGMnli52fV7zi1dG X-Received: by 2002:a17:906:131b:: with SMTP id w27mr7529565ejb.230.1587019658267; Wed, 15 Apr 2020 23:47:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587019658; cv=none; d=google.com; s=arc-20160816; b=y+Ca7a2yEChzKveNn2gbXR0pO18w6mDvX8A55xms4KdVLuRhyLi7Y5ji9ZOqAK+JUB Ucow9oFU9VSrs9gJ707WKHvLg/fDnd3+i8WBH3q+K635xsAv2MylxYn1FqObzpCRW4tf 0alKn1xS8+9vux+bOWZ2aFWark/Urj1g4fod9o+VPmOUK2aZkJdDqhGCt/1XcWOVjZDt OZIDOcd3ln0M74nT9vlnuC8AbbyVnO3PzjtgOf6Mooo2gs97VELsbstgogpuQuDVU0eA 9gHFiuIIR9qfAtq5Ifmm9xxGhzBQAFpYKOJ5vOh/78X/C4tIXIoXkBE+RBeP+INrbp5E 4nnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=GOfFSoAbXuWHO0LSL3Gck7r4ogSXthkT+8qGJ+uIsXY=; b=wpNAIO1O9HvA7Bk707dJbqYct0bIqfPvFUMxmICPB1EAPlLhRIlTfV61royvo7vYrv wcm4Lx4NEzDsbyJ0nGnz0QzBbZsu7WEtA8XF96wWX7HJf/w3FdLe/8NQfO/wfQBhmwL4 o2X5GYi+49SXql8spbrKSL1veTZxcjM4q1YpKCUqfr5qiIa4YgJiP9NsBM5ZtRDlonCV gpzF5NatCICto/ZoG3msIebo7jilLj4Yg6TCHpsZCkUjti7EMgPwibwRH9BakSjCyOyH YyHnMf503I42Bt/cBUveyjuC9nPAL6lPlKFmxq6DknSAS10FHMgvNVMF6nnESY1RmBlQ vTzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mWchGAC+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm2si10789399edb.22.2020.04.15.23.47.14; Wed, 15 Apr 2020 23:47:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=mWchGAC+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408439AbgDPGnu (ORCPT + 99 others); Thu, 16 Apr 2020 02:43:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:52738 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2408168AbgDPGnp (ORCPT ); Thu, 16 Apr 2020 02:43:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B4DA8206D6; Thu, 16 Apr 2020 06:43:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587019423; bh=BKmhwxbmr2z9YCdItTQJHwRjKGeTBBS+eQgot1INXhM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mWchGAC+vAFFSp6qh9NsLKsGlU90wq24zkjqWRuJQDRzI7cr9AxDmicO2eD+IzJ3c sGCzNz3JCiuBvIVBeRdXO2UQKyfJ3SXnfZbVTf7z3X6+UWo1V7dQ9GHa/KBptAxeB3 icdyyi0gEO6PLAhNJ9+K2CaqqrQu1Y95AIUwfP44= Date: Thu, 16 Apr 2020 08:43:41 +0200 From: Greg KH To: Christoph Hellwig Cc: Linus Torvalds , Andrew Morton , Al Viro , Felix Kuehling , Alex Deucher , Zhenyu Wang , Zhi Wang , Felipe Balbi , "Michael S. Tsirkin" , Jason Wang , Jens Axboe , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] kernel: better document the use_mm/unuse_mm API contract Message-ID: <20200416064341.GB300290@kroah.com> References: <20200416053158.586887-1-hch@lst.de> <20200416053158.586887-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200416053158.586887-3-hch@lst.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 16, 2020 at 07:31:57AM +0200, Christoph Hellwig wrote: > Switch the function documentation to kerneldoc comments, and add > WARN_ON_ONCE asserts that the calling thread is a kernel thread and > does not have ->mm set (or has ->mm set in the case of unuse_mm). > > Also give the functions a kthread_ prefix to better document the > use case. > > Signed-off-by: Christoph Hellwig > Acked-by: Felix Kuehling Acked-by: Greg Kroah-Hartman [usb]