Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
Cc:     <Mori.Takahiro@ab.MitsubishiElectric.co.jp>,
        <Motai.Hirotaka@aj.MitsubishiElectric.co.jp>,
        "'Sungjong Seo'" <sj1557.seo@samsung.com>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        "'Matthew Wilcox'" <willy@infradead.org>
In-Reply-To: <TY1PR01MB157894A971A781BE900C5A7590DD0@TY1PR01MB1578.jpnprd01.prod.outlook.com>
Subject: RE: [PATCH v2] exfat: replace 'time_ms' with 'time_10ms'
Date:   Thu, 16 Apr 2020 15:47:24 +0900
Message-ID: <006a01d613ba$e2e19e10$a8a4da30$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQE756cOWkSWdyX4fUAG5iBImQRCHAHs2XDjAV3IMHoCBKFRS6mFKQKQ
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20200408074610.35591-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>
        <20200408112152.GP21484@bombadil.infradead.org>
        <CGME20200413094319epcas1p236a2145766a672f718030b4199b82956@epcas1p2.samsung.com>
        <TY1PR01MB157894A971A781BE900C5A7590DD0@TY1PR01MB1578.jpnprd01.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> > Please leave at least 24 hours between sending new versions so that
> > you can collect all feedback relating to your change, and we don't see
> > discussion fragment between different threads.
> 
> Thanks for good advice!
> 
> > > +		ts->tv_sec += (time_10ms * 10) / 1000;
> > > +		ts->tv_nsec = (time_10ms * 10) % 1000 * NSEC_PER_MSEC;
> >
> > I find this more confusing than the original.
> 
> The parentheses were intended to group conversions into milliseconds, but
> were not necessary from an "operator precedence" perspective.
> 
> 
> >
> > 		ts->tv_sec += time_10ms / 100;
> > 		ts->tv_nsec = (time_10ms % 100) * 10 * NSEC_PER_MSEC;
> >
> > is easier to understand for me, not least because I don't need to worry
> > about the operator precedence between % and *.
> 
> If I use '100' for the divisor of '10ms', I find it difficult to
> understand
> the meaning of the operation.
> 
> When using '100' for the divisor, I think cs (centi-sec) is easier to
> understand than 10ms.
> Which do you prefer, time_10ms or time_cs?
Can you resend the patch again after changing to time_cs ?

> 
> 
> BR
> ---
> Kohada Tetsuhiro <Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp>