Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp977121ybz; Wed, 15 Apr 2020 23:57:37 -0700 (PDT) X-Google-Smtp-Source: APiQypJITZvqA/C5FmjvHquOC71G7o2KOiozY5c/pICfQ7pzRsLMEyjDhDZiFlgHGKo11/1lxYt7 X-Received: by 2002:a50:8716:: with SMTP id i22mr6335523edb.248.1587020257258; Wed, 15 Apr 2020 23:57:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587020257; cv=none; d=google.com; s=arc-20160816; b=zlYIy/nn6akJ2taSzOjhstgXRHRiSSdJSQf/wOO5+mhgzoSVULS1ntJjtHzcyDOD5B hd1h0uNQ8HmecuuSWAOvbZU37r02wJH5ADTmbNtdYyp2nALr/ClUuiS+qZmdlMn9Rw87 WQGq9Pt+4XFc8qlPImT45BdDMFAVACS1bx5baX5JPsBXQnaXlVmLOA805GHqpzbNNQXR nSO/f2YDtmGOymzMWbOOWad/HRpFQUnIYDOCcfSKYRSM0qw2O24Lu5e2ZdtTLpmwY1EF MVAh5VIenTPn7BkZwG6SQLvC6Qr/seb0XR14Q+tyFSBdH/QUjJkxj0QTsoabtwc0cHOE 17BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject; bh=y9ZM4BJqh/6pfYvOAOqeJ82MbJCePLVCtGtwUXW+CXs=; b=H9Xv/RNfcRblGh5YVyk6FnS/iyMmf1KEvSwP00hKth6ysOhgCmIHlY2FcoAZk3hv7D 3X1DRht+gELXg6QopWRHmiqhRQ41WNTX3fDE6dfl/1KMCJWVVzKY1ch6PMI5P0pNzgXi u9KsnRa+wHDooP/VyDMjXgOIRU06p/o7uTtEcI8i6JZUY7cO4OauHRLBWgcKDhIHdmbR KaqsqVP5GPzxN92r5gZvUooiV2suKLUCEWslL02YSIec8ik5tYk1zkPTcaDpalmu9/yX emvq6KsBjnSTu4dHkW84EA0sj3dCM8Z3U7bJMeGF7d97BZUwMICqJHy/w13oFVjCfNWV dsHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c23si11207073edw.24.2020.04.15.23.57.14; Wed, 15 Apr 2020 23:57:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437167AbgDPG4N (ORCPT + 99 others); Thu, 16 Apr 2020 02:56:13 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:58156 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2436700AbgDPG4E (ORCPT ); Thu, 16 Apr 2020 02:56:04 -0400 Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id B277D564BEBE7EB6F5C3; Thu, 16 Apr 2020 14:55:58 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.201) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 16 Apr 2020 14:55:55 +0800 Subject: Re: [f2fs-dev] [PATCH v2] f2fs: add tracepoint for f2fs iostat To: Jaegeuk Kim , , , References: <20200413161649.38177-1-jaegeuk@kernel.org> <20200416034217.GA254838@google.com> From: Chao Yu Message-ID: <0a821dfb-f2fc-649b-617d-27c1d5ca599b@huawei.com> Date: Thu, 16 Apr 2020 14:55:54 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200416034217.GA254838@google.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/16 11:42, Jaegeuk Kim wrote: > v2: > - add sysfs entry to give the time period > - keep stat records in sbi > >>From 805015f3f2cec3acf43321359129c5382a1d5db4 Mon Sep 17 00:00:00 2001 > From: Daeho Jeong > Date: Mon, 30 Mar 2020 03:30:59 +0000 > Subject: [PATCH] f2fs: add tracepoint for f2fs iostat > > Added a tracepoint to see iostat of f2fs. Default period of that > is 3 second. This tracepoint can be used to be monitoring > I/O statistics periodically. > > Bug: 152162885 > Change-Id: I6fbe010b9cf1a90caa0f4793a6dab77c4cba7da6 Should be removed... > Signed-off-by: Daeho Jeong Otherwise, it looks good to me. Reviewed-by: Chao Yu Thanks,