Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp991859ybz; Thu, 16 Apr 2020 00:17:45 -0700 (PDT) X-Google-Smtp-Source: APiQypLuPN99Me4SAKu21SbGtsIGmrSw/SCqmg7aOk1eYezlxzeWLKqAD3+ZrEnsl7QmkqxKk2aG X-Received: by 2002:a17:906:4bc4:: with SMTP id x4mr8493663ejv.201.1587021465138; Thu, 16 Apr 2020 00:17:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587021465; cv=none; d=google.com; s=arc-20160816; b=IxEzYzxe4ntwxEvepE6hVe99RvneiUmq06QRB5H+yhpOWRwD1dFfLjPyY5RuFAtOEh ucAw1LRgz7AS1xsG2qk3gYWA5ZD1rrnEriEf7zPpVgWzGerlHwf5dRXWQvOSwMDBfPdJ 7Sx8/ShMOZbH8UUNWBWe/UR4HRHpnOdqlmGDRRVpZBwDRtgliI8Ue41rkQOulyU5NC7d R0KXMtm/GqS15xEWlJXBVX72SZTjU9rFN59uqgSPwTf265R11BN8ink9cOZgzhHJzmM2 ArqRJBmVzD6pj7fEzgUafiHAJ6W01COlpOo/aFLqaMuz0gr+aYJni36CwBArCqniTxJV 20zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=yjMFf/NW3vaT7DSAdBbS8xc9vZrvyTjcj19Fx3P/8NE=; b=0qYDJOhQ6ZLw9zyxbPqY5FAbqdArpTvjSj/k3yq5r8kRCaHc6XzAVD03zSi2i/Wgs8 o/5s2xEV6r4uwN7q5wPsXi4ouEoEkLHnSlQO2d78DvEmLLeTTLW6Q2VrIx4aX/dD5gwS AEKrCKEaQH+x3lnTh/xLD11jPDN84xppJH6vV/Ki+BYHVUzCjzVid5ghJ2S2D2jlAeG3 6sa2HOQZQHeVUldJXK9ytXhNGqv6O1nUF3PF1bNo66cfiLVK5YAQbBuU3lGHRQPQahOF vZfF7O/WCZnlcHfVQFrxKuMaJW/3vLDkgqNFn6aaPQaScg/22YhPXp0rJToKgR8ouddw ZxnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MbprBGRl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p31si10894878edb.495.2020.04.16.00.17.21; Thu, 16 Apr 2020 00:17:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=MbprBGRl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438711AbgDPHP5 (ORCPT + 99 others); Thu, 16 Apr 2020 03:15:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2437959AbgDPHPi (ORCPT ); Thu, 16 Apr 2020 03:15:38 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67A3EC061A41; Thu, 16 Apr 2020 00:15:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=yjMFf/NW3vaT7DSAdBbS8xc9vZrvyTjcj19Fx3P/8NE=; b=MbprBGRlNvYJJ+jV8H5/Fq2ZSR qc8zy0x10Fz2PSeRQyoAx4kg5gvTQbnRACNOWElpO8206O8ysMckHa4Y/JTNyzEVUmT+RnzFaAXvF jsSamMvQV4QL0S2IX8sBQNEnqeq1u4nXZ7gLBD1kSt8+TlaRZFOFqHcfZLrUj0qVIju8egvLY8Ka1 OTp4YVGrVjLEnJng9vehmHcOq3mPPolCRisWK23M6ayrn+0pwWXzBViWDFFwKpQU1dokqIvjbDgWT +PmcVpmU4LmOnjc1wxsRh3unBtjz+8J4T4/aNntutAnK/oBldLDULeed46xkbta3ZwDhSyZRdhij8 dYvPDhFg==; Received: from [2001:4bb8:184:4aa1:c70:4a89:bc61:2] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jOykB-0003Hc-K5; Thu, 16 Apr 2020 07:15:28 +0000 From: Christoph Hellwig To: axboe@kernel.dk Cc: yuyufen@huawei.com, tj@kernel.org, jack@suse.cz, bvanassche@acm.org, tytso@mit.edu, gregkh@linuxfoundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/8] bdi: use bdi_dev_name() to get device name Date: Thu, 16 Apr 2020 09:15:13 +0200 Message-Id: <20200416071519.807660-3-hch@lst.de> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200416071519.807660-1-hch@lst.de> References: <20200416071519.807660-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yufen Yu Use the common interface bdi_dev_name() to get device name. Signed-off-by: Yufen Yu Reviewed-by: Christoph Hellwig Signed-off-by: Christoph Hellwig --- block/bfq-iosched.c | 5 +++-- block/blk-cgroup.c | 2 +- fs/ceph/debugfs.c | 2 +- include/trace/events/wbt.h | 8 ++++---- 4 files changed, 9 insertions(+), 8 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index 78ba57efd16b..4d4fe44a9eea 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -4976,8 +4976,9 @@ bfq_set_next_ioprio_data(struct bfq_queue *bfqq, struct bfq_io_cq *bic) ioprio_class = IOPRIO_PRIO_CLASS(bic->ioprio); switch (ioprio_class) { default: - dev_err(bfqq->bfqd->queue->backing_dev_info->dev, - "bfq: bad prio class %d\n", ioprio_class); + pr_err("bdi %s: bfq: bad prio class %d\n", + bdi_dev_name(bfqq->bfqd->queue->backing_dev_info), + ioprio_class); /* fall through */ case IOPRIO_CLASS_NONE: /* diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index c5dc833212e1..930212c1a512 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -496,7 +496,7 @@ const char *blkg_dev_name(struct blkcg_gq *blkg) { /* some drivers (floppy) instantiate a queue w/o disk registered */ if (blkg->q->backing_dev_info->dev) - return dev_name(blkg->q->backing_dev_info->dev); + return bdi_dev_name(blkg->q->backing_dev_info); return NULL; } diff --git a/fs/ceph/debugfs.c b/fs/ceph/debugfs.c index 481ac97b4d25..dcaed75de9e6 100644 --- a/fs/ceph/debugfs.c +++ b/fs/ceph/debugfs.c @@ -271,7 +271,7 @@ void ceph_fs_debugfs_init(struct ceph_fs_client *fsc) &congestion_kb_fops); snprintf(name, sizeof(name), "../../bdi/%s", - dev_name(fsc->sb->s_bdi->dev)); + bdi_dev_name(fsc->sb->s_bdi)); fsc->debugfs_bdi = debugfs_create_symlink("bdi", fsc->client->debugfs_dir, diff --git a/include/trace/events/wbt.h b/include/trace/events/wbt.h index 37342a13c9cb..9996420d7ec4 100644 --- a/include/trace/events/wbt.h +++ b/include/trace/events/wbt.h @@ -33,7 +33,7 @@ TRACE_EVENT(wbt_stat, ), TP_fast_assign( - strlcpy(__entry->name, dev_name(bdi->dev), + strlcpy(__entry->name, bdi_dev_name(bdi), ARRAY_SIZE(__entry->name)); __entry->rmean = stat[0].mean; __entry->rmin = stat[0].min; @@ -68,7 +68,7 @@ TRACE_EVENT(wbt_lat, ), TP_fast_assign( - strlcpy(__entry->name, dev_name(bdi->dev), + strlcpy(__entry->name, bdi_dev_name(bdi), ARRAY_SIZE(__entry->name)); __entry->lat = div_u64(lat, 1000); ), @@ -105,7 +105,7 @@ TRACE_EVENT(wbt_step, ), TP_fast_assign( - strlcpy(__entry->name, dev_name(bdi->dev), + strlcpy(__entry->name, bdi_dev_name(bdi), ARRAY_SIZE(__entry->name)); __entry->msg = msg; __entry->step = step; @@ -141,7 +141,7 @@ TRACE_EVENT(wbt_timer, ), TP_fast_assign( - strlcpy(__entry->name, dev_name(bdi->dev), + strlcpy(__entry->name, bdi_dev_name(bdi), ARRAY_SIZE(__entry->name)); __entry->status = status; __entry->step = step; -- 2.25.1