Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp999630ybz; Thu, 16 Apr 2020 00:30:02 -0700 (PDT) X-Google-Smtp-Source: APiQypI8BcxpzkPeBsFj2DQf5WhZPWNlwCBPmJeLH0sHUQ8doY28GVW6teSWF/w4Roa3tyJUhD3l X-Received: by 2002:a50:d981:: with SMTP id w1mr28126641edj.275.1587022202753; Thu, 16 Apr 2020 00:30:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587022202; cv=none; d=google.com; s=arc-20160816; b=KM5/u5S4D/LnMbSk/HyppUUYp/ZqVX+97sVv9SUFvNRXZT7xkA9sihPAet63Rps6uA L/3s3hx1PnWJci7HsJBcXJWnL8OI91enGWK43szIcgIqyggY8jT0Gh8tMy68u2IOFy81 SD9Zds0R7xsKDunMB1wF3m1qqEweJOz/QWFVCEYFHrtrrs1uZH6+5H0TFFF6zTYvtmIv t1a4TebQTIWt0JnQ3V5Cd6tIvhCH+q0ngH88qDeNhNOLuQrubjr8BA+xIkMh38ttLciy tumISL/xecgbL+7hvFQc/DZEYv4NCf1gdS/H2dPOZvMWql06zLJx67guQcmD529lW37I eBFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=IuRt1kTPXApyBON6xAkQaHHGntyfDQ2SIECOxqpaO9w=; b=RTVnARRzFnmvl4HEwwZWlJvPCxtpTayZmkHri+XoPuif0rktzHEF70cQpIhCckHJYZ y98Hph/Akx9xS6kuZV9UroXoP+DjSEkwqGQcwN7RNmGBCFxigPVm5o+SQiimzKAndgYT UoQsihHuwLFJIWuj1UrU9egn8gmnGkLjzdxGtQOG2YlyvWtA+3mhdPHjU3Du2nJumQyZ PfnOgs/MluuY1yjCHVWqCk3LoIMe1doWIY8cbcEfw+P4Wu7eC1wueWaj3wegaHc13SJV i5/x1vWu9myGbCFChUNlg63QuFxoz+PU1JiRMHsbxIe2iT20zGJW5bAxZ9pNdsu08Ddj d2jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p25si14819199edt.291.2020.04.16.00.29.39; Thu, 16 Apr 2020 00:30:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439180AbgDPH12 (ORCPT + 99 others); Thu, 16 Apr 2020 03:27:28 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:39980 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2439002AbgDPH11 (ORCPT ); Thu, 16 Apr 2020 03:27:27 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 796BE80FCC6FEDB8FC34; Thu, 16 Apr 2020 15:27:25 +0800 (CST) Received: from [10.134.22.195] (10.134.22.195) by smtp.huawei.com (10.3.19.209) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 16 Apr 2020 15:27:24 +0800 Subject: Re: [PATCH] f2fs: Fix the accounting of dcc->undiscard_blks To: Sahitya Tummala , Jaegeuk Kim , CC: References: <1587017861-6454-1-git-send-email-stummala@codeaurora.org> From: Chao Yu Message-ID: Date: Thu, 16 Apr 2020 15:27:23 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1587017861-6454-1-git-send-email-stummala@codeaurora.org> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.134.22.195] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020/4/16 14:17, Sahitya Tummala wrote: > When a discard_cmd needs to be split due to dpolicy->max_requests, then > for the remaining length it will be either merged into another cmd or a > new discard_cmd will be created. In this case, there is double > accounting of dcc->undiscard_blks for the remaining len, due to which > it shows incorrect value in stats. > > Signed-off-by: Sahitya Tummala Reviewed-by: Chao Yu Thanks,