Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <CAEUGjKiLPQP9wp0AgLUvHgKBOe9We2a-RQaZ7cd7CvhnarwWiw@mail.gmail.com>
 <CAKywueT0Q9WkANNsg8cEDwGZSMaaE5c4LHuEeMhVDzJAzycroQ@mail.gmail.com>
 <CAEUGjKhSBNQboKOMFMgos9OQfxcLQZsXp8aBrUSFcaSe1saH2Q@mail.gmail.com>
 <CAH2r5mt1k5t8rSH1KizeSrcLaN1Fn3GWeMvDPwT2Kfq43UAWaQ@mail.gmail.com> <CAEUGjKhpgmhj9RzcGQXPuFUyoqsUnk2d3oCpOYBdR=EwCO21YQ@mail.gmail.com>
In-Reply-To: <CAEUGjKhpgmhj9RzcGQXPuFUyoqsUnk2d3oCpOYBdR=EwCO21YQ@mail.gmail.com>
From:   Jones Syue <jonessyue@qnap.com>
Date:   Thu, 16 Apr 2020 15:33:18 +0800
Message-ID: <CAEUGjKh5mj0rFUZPoguFh4G-_YfwACV+_jVK7TNi+jK_fE1dgQ@mail.gmail.com>
Subject: Re: [PATCH] cifs: improve read performance for page size 64KB &
 cache=strict & vers=2.1+
To:     Steve French <smfrench@gmail.com>
Cc:     Pavel Shilovsky <piastryyy@gmail.com>,
        linux-cifs <linux-cifs@vger.kernel.org>,
        Samba Technical <samba-technical@lists.samba.org>,
        Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello Steve

> Test read performance over 1GbE network with command:
Also test read performance over 10GbE network,
vers=3D2.1+ can reach over 600 MB/s with v2.patch.

aarch64, page size 64KB (CONFIG_ARM64_64K_PAGES=3Dy), linux-4.2.8,
cpu Annapurna Labs Alpine AL324 Quad-core ARM Cortex-A57 CPU @ 1.70GHz,
ram 8GB,
with patch,
vers=3D1.0,cache=3Dstrict: read throughput 110MB/s, max read IO size 16KB
vers=3D2.0,cache=3Dstrict: read throughput 106MB/s, max read IO size 16KB
vers=3D2.1,cache=3Dstrict: read throughput 667MB/s, max read IO size 1MB
vers=3D3.0,cache=3Dstrict: read throughput 639MB/s, max read IO size 1MB
without patch,
vers=3D1.0,cache=3Dstrict: read throughput 107MB/s, max read IO size 16KB
vers=3D2.0,cache=3Dstrict: read throughput 107MB/s, max read IO size 16KB
vers=3D2.1,cache=3Dstrict: read throughput 106MB/s, max read IO size 16KB
vers=3D3.0,cache=3Dstrict: read throughput 106MB/s, max read IO size 16KB

command:
mount -tcifs //<server_ip>/<share> /remote_strict
-overs=3D<x.y>,cache=3Dstrict,username=3D<uu>,password=3D<pp>
dd if=3D/remote_strict/10G.img of=3D/dev/null bs=3D1M count=3D10240

--
Regards,
Jones Syue | =E8=96=9B=E6=87=B7=E5=AE=97
QNAP Systems, Inc.

On Thu, Apr 16, 2020 at 11:46 AM Jones Syue <jonessyue@qnap.com> wrote:
>
> Hello Steve
>
> > Did you also test (at least briefly) with vers=3D1.0 since some of your
> > code affects that code path too?
>
> Yes test v2.patch on 2 platforms aarch64 (page size 64KB) and x86_64
> (page size 4KB), vers=3D1.0 read function works fine on both.
>
> Test read performance over 1GbE network with command:
> 'dd if=3D/remote_strict/10G.img of=3D/dev/null bs=3D1M count=3D10240'
>
> For read performance on aarch64 (page size 64KB), vers=3D[1.0|2.0] is not=
 as
> fast as vers=3D2.1+, max_read on both SMB 1 (16KB) and SMB 2.0 (64KB) are
> still smaller then page size 64KB plus packet header size, hence do not
> support readpages.
> aarch64, page size 64KB (CONFIG_ARM64_64K_PAGES=3Dy), linux-4.2.8,
> cpu Annapurna Labs Alpine AL324 Quad-core ARM Cortex-A57 CPU @ 1.70GHz,
> ram 8GB,
> with patch,
> vers=3D1.0,cache=3Dstrict: read throughput 40MB/s, max read IO size 16KB
> vers=3D2.0,cache=3Dstrict: read throughput 40MB/s, max read IO size 16KB
> vers=3D2.1,cache=3Dstrict: read throughput 115MB/s, max read IO size 1MB
> vers=3D3.0,cache=3Dstrict: read throughput 115MB/s, max read IO size 1MB
> without patch,
> vers=3D1.0,cache=3Dstrict: read throughput 40MB/s, max read IO size 16KB
> vers=3D2.0,cache=3Dstrict: read throughput 40MB/s, max read IO size 16KB
> vers=3D2.1,cache=3Dstrict: read throughput 40MB/s, max read IO size 16KB
> vers=3D3.0,cache=3Dstrict: read throughput 40MB/s, max read IO size 16KB
>
> For read performance on x86_64 (page size 4KB), all vers can support
> readpages because max_read is bigger than page size 4KB plus packet heade=
r
> size.
> x86_64, page size 4KB, linux-4.2.8,
> cpu AMD Embedded R-Series RX-421ND 2.10GHz,
> ram 4GB,
> without patch,
> vers=3D1.0,cache=3Dstrict: read throughput 109MB/s, read IO size 60KB
> vers=3D2.0,cache=3Dstrict: read throughput 115MB/s, read IO size 64KB
> vers=3D2.1,cache=3Dstrict: read throughput 117MB/s, read IO size 1MB
> vers=3D3.0,cache=3Dstrict: read throughput 117MB/s, read IO size 1MB
> with patch,
> vers=3D1.0,cache=3Dstrict: read throughput 110MB/s, read IO size 60KB
> vers=3D2.0,cache=3Dstrict: read throughput 115MB/s, read IO size 64KB
> vers=3D2.1,cache=3Dstrict: read throughput 117MB/s, read IO size 1MB
> vers=3D3.0,cache=3Dstrict: read throughput 117MB/s, read IO size 1MB
>
> > And if anyone figures out how to configure an x86_64 Linux to use
> > PAGE_SIZE of 64K or larger let me know...
> I am using physical platform with arm cpu and aarch64 toolchain,
> perhaps try qemu-system-aarch64 later.
>
> --
> Regards,
> Jones Syue | =E8=96=9B=E6=87=B7=E5=AE=97
> QNAP Systems, Inc.