Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1170690ybz; Thu, 16 Apr 2020 04:20:59 -0700 (PDT) X-Google-Smtp-Source: APiQypLN6E3z5QAD2t+Phm7nIJC1bImk97/zKPOQvxJcwUO6I5Ngbp/ahiPxXBc8LpflrqQYeYJo X-Received: by 2002:a17:906:48ce:: with SMTP id d14mr8655166ejt.113.1587036058835; Thu, 16 Apr 2020 04:20:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587036058; cv=none; d=google.com; s=arc-20160816; b=FMaK2895ZKbeI6+aAFhO0DjRbZEau6aC7UC0ojrrmu2S5+6QsI0ICvO/hEUzZxLmB4 0Lm1w5PzciMIbvyBm5t+ddKtrJY7Q+CuGUDuA2fxtVf6DuemA5N6lC3tly0zquzoGLfk GRhiECddNS8RhTKGnCrH7lcqHkggvqfuSPRzK5uo/fOwkxsAJWzU5YpDGgFUMpU2LKGE LAFO0ALV6+fdBChs9F1wjfSTB+NcbBqg/eGPSxk5z0hrH60tVaEhwqi2wPSrjDGt5i4e WAKXfd2MCQ9FFVfuHDVcOZkUajjmCYhKf91tZqCFkTTCwZb0iSFNgvY3HtDIxEWMjb3c QlVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=uMhEZOoHAJnjG/UJiypTrpHYCbpZgvJbU4bT3L0FKI4=; b=0oN8/EaJ3E+HTCy2+R7pBk+ZSwL/pvPDGL7fl6+NSFXVupsfrRFD6xay1uf0V+zoe+ TbtDCcyDMkw/w0SIhH6a2cWF7gp024CVz1OaN+BYhNrEtK7ZGYDOzqPh06BUUsH+i0YJ s9FosC7sDMhKwLhDh5LjEw7sVPTzvttsAF318uEP+YGd+VTCkvitRT9279KeFwmzHmnc wcXOZ7DtpycUGz97/LFGkjjEFpQZxNplimxpxBk7zlWmmh894DPcLwvhGv9FzyFsYHEs dAup6muC7lgw4nipYKU/yOeok8JmDIDOdDcllQ6v0MtBP19btyjhgYWkO6gzvA0cNuLp 6Gtg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hh7rete3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m17si1207770eds.553.2020.04.16.04.20.35; Thu, 16 Apr 2020 04:20:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Hh7rete3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2506306AbgDPLRE (ORCPT + 99 others); Thu, 16 Apr 2020 07:17:04 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:54847 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S2506160AbgDPLOW (ORCPT ); Thu, 16 Apr 2020 07:14:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587035661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uMhEZOoHAJnjG/UJiypTrpHYCbpZgvJbU4bT3L0FKI4=; b=Hh7rete3ARXQJJ6CQij9vn+QxSdXsHjWC8oi8jSs6rzA1Bo6BZ2ApYJOMUvKM+MbCg6zAJ QM8pYpo2Yg35TtcxOUkWUsF7G9xOwLfcpSMCTOZfjxUP3Is/OwTYYk3fcJRQd6GHaApqkn 0+F3K8P2RGAKHX3TT/n9s8s9UEPpSAg= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-IhQnZEqzOiyLqd_xHe7YTA-1; Thu, 16 Apr 2020 07:14:19 -0400 X-MC-Unique: IhQnZEqzOiyLqd_xHe7YTA-1 Received: by mail-wm1-f72.google.com with SMTP id h6so1252682wmi.7 for ; Thu, 16 Apr 2020 04:14:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uMhEZOoHAJnjG/UJiypTrpHYCbpZgvJbU4bT3L0FKI4=; b=C1FPKOW6qETBQ/IcJ15Z5XCueXIQd0yG8/tFm6icMPM1ijhj6t7qv2C2QQSJpwIDt1 DzvpXhWeClDJ3TlL6qy3Y1553NOBg3j3QZwjAxurK4cgIxAIN4h0ZiYRcZXgEinECW9X OBIzvqP3SDkezWjn/8grqfzoWMll7mnPgHiYBw3J7tOdfgMMTfqyQ2O5u/MFwHTJt4h6 44rOO5yIt2c35fkkZ2Y0WRvEsedRG9uxLk85fw9sdImN0b+ntzZwmgMbJ80hHa0oqyrG L+OA7uFfcavsAJaYiHAcZHqkG7AtdoIhD58iMzU+ntTjksKI1LsgRjys63OTSImO1jIE q1Uw== X-Gm-Message-State: AGi0PubcGOZUuzTwLgpFZuCXwwX/rstHfBWbqF3jLv+5lHrJ5FuHnemO QGrHKfTmCWDnppZHLp3DIFsIpaH/27sEpnrWZQunN+2oVJynJMH/6mOltWEIi0896UfjT0eFZNe m30r7fwQlge5XS4zK1F2Zfxso X-Received: by 2002:a5d:408a:: with SMTP id o10mr14651246wrp.163.1587035658170; Thu, 16 Apr 2020 04:14:18 -0700 (PDT) X-Received: by 2002:a5d:408a:: with SMTP id o10mr14651234wrp.163.1587035657963; Thu, 16 Apr 2020 04:14:17 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:399d:3ef7:647c:b12d? ([2001:b07:6468:f312:399d:3ef7:647c:b12d]) by smtp.gmail.com with ESMTPSA id h5sm8397012wrp.97.2020.04.16.04.14.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2020 04:14:17 -0700 (PDT) Subject: Re: [PATCH] x86/kvm: make steal_time static To: Jason Yan , sean.j.christopherson@intel.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, joro@8bytes.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hulk Robot References: <20200415084939.6367-1-yanaijie@huawei.com> <35c3890e-0c45-0dac-e9f0-f2a9446a387d@huawei.com> From: Paolo Bonzini Message-ID: Date: Thu, 16 Apr 2020 13:14:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <35c3890e-0c45-0dac-e9f0-f2a9446a387d@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/04/20 04:15, Jason Yan wrote: >> > > Sorry that I found 14e581c381b9 ("x86/kvm: Make steal_time visible") > said that it is used by assembler code but I didn't find where. > Please drop this patch if it's true. > > Sorry to make this trouble again. Here: arch/x86/kernel/kvm.c:"cmpb $0, " __stringify(KVM_STEAL_TIME_preempted) "+steal_time(%rax);" The __visible argument shouldn't be needed, __used should be enough. I'll take a look. Paolo