Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1185263ybz; Thu, 16 Apr 2020 04:38:18 -0700 (PDT) X-Google-Smtp-Source: APiQypJ0vjeL2ZQluZbveb6byuelWuhkizlaUrYhYrHhzOZxpK74DzLbHb3P80qqo0zmeMxDSQ5N X-Received: by 2002:a17:906:cd1:: with SMTP id l17mr8925561ejh.319.1587037097930; Thu, 16 Apr 2020 04:38:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587037097; cv=none; d=google.com; s=arc-20160816; b=nafCrFrzsKNnpPvToJba3dE/yiRQpX5uyyxnmkpzPT9s3Sm6Xe14mg6RoHlP9RBrZp 89eW9sr0jDVE/RwAgtGyKhU654XppD9WZw43CclIve1ZhxlOvBF9dgpMJgaldtKxcRtK D6DJoi+26F+DqhDGmAT2N5pGbTsYMzzK+odsaGwkaECB4d/0NSQLi38zQFFbPrk8qFaA eDGV0ZjimVPufbCAwE9GtcKgED3P0ZQI4sz/7bhu9sM3lZqIpPBd3cxUS7XsKvQL3v9b B9z6jcShBf4IVtX3RvTKWOs+KXUFyy3DCgXMQI6k823RdVgUYmSeE5DnlyDGe2Vkfvj+ v/Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1O074pBLqyTFD9k7wtMxYMKMEH2M6e1rlcL3gx4htII=; b=hsZ3Vlj33pQGc4sHsye/3qkEzhTnwtUHmFU0qebKlwK8lr1JT08rZBXB2GvMtx30rX //DMgcXcjF/f/2pJOqVHusGSiWuIYldStphyLn59DJWeBtRlnIdMC14qNz81gyatjUPN CAMgfgPsHWReDJpyBEhrcVsj8UgO+Y05lJLBXP+Nkwn5dgZxdyyw4fXJsAZGAhByESSo 4abuogMNRRm0Qa07KTGMITVwoUkaC9hCi/+yrbJS6ciytv/0tCoueHk6JVyec3qyW4Xa uvDxs9TWn9BRi4yZrDBdtpYdWOXEFtsxxxufBhtbU5S1zZ8UHMpCtQSL4CKv5syMCAkn /sjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wn0R9ybv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cm2si11165394edb.22.2020.04.16.04.37.55; Thu, 16 Apr 2020 04:38:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wn0R9ybv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633548AbgDPLgE (ORCPT + 99 others); Thu, 16 Apr 2020 07:36:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:36826 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2633830AbgDPLfm (ORCPT ); Thu, 16 Apr 2020 07:35:42 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E68E3221F9; Thu, 16 Apr 2020 11:35:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587036942; bh=1O074pBLqyTFD9k7wtMxYMKMEH2M6e1rlcL3gx4htII=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wn0R9ybvpPtD+hJriLIIlK2HrDvwNZuYowM5oNOUaynHQWDpXcxjDvP8fjH0TYhHf ovqudIrkqGhQ93oRANM7b/OCeIHaVKFU/rkk6VHh0vWhrvkHhlHYUxg9JECoPNAYPn mzxHdrf9LEXOcIfgn/3yhViyun/b8AdzCdUYCF6w= Date: Thu, 16 Apr 2020 12:35:39 +0100 From: Mark Brown To: Clement Leger Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] spi: dw: remove cs_control and poll_mode members from chip_data Message-ID: <20200416113539.GG5354@sirena.org.uk> References: <20200416110823.22565-1-cleger@kalray.eu> <20200416110916.22633-1-cleger@kalray.eu> <20200416110916.22633-2-cleger@kalray.eu> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="DWg365Y4B18r8evw" Content-Disposition: inline In-Reply-To: <20200416110916.22633-2-cleger@kalray.eu> X-Cookie: Tempt me with a spoon! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --DWg365Y4B18r8evw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Apr 16, 2020 at 01:09:16PM +0200, Clement Leger wrote: > Since these members were initialized only with previous dw_spi_chip > struct members and that there is no user anymore, remove them. Along > this removal, remove code path which were using these members. This means that your first patch will break the build, to keep things bisectable please do some combination of moving this before the first patch and squashing it into the first patch. --DWg365Y4B18r8evw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6YQwsACgkQJNaLcl1U h9A6uwf/TM+SknyZfv4czhh1vQN+MJ1nQdZrChLiBIqdfo9aNkryncc2MEnUL/J2 gjKN5DMzNaAuiMeZMQVlOLeCEwm0tkUP/1KFWTV2V+pPWrCSTZHYe7fgfk/XSg1X Xq9R29E1/XCPnlfI6T2KjATZICins0nQrJnFDGM9xQCNsqJfMvw04dE8ZtQUE6Xr fLuupPyBnn+kGSYQjbk6KJmDq8JK1hP46EZUDWCqjYL98GMsI0Y/Hmvg16MdI8iN UZ7L6hNdu++XhmS2Yy4Szc/0dQ7chorIYGczEkLPp+p9raGTcHkAErlGBxumYNNP llJoGFPjjjn43eEoaSxIyeE0yPlW6Q== =4w+e -----END PGP SIGNATURE----- --DWg365Y4B18r8evw--