Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Apr 2020 08:32:24 -0400
From:   "Michael S. Tsirkin" <mst@redhat.com>
To:     Jason Wang <jasowang@redhat.com>
Cc:     Randy Dunlap <rdunlap@infradead.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        virtualization@lists.linux-foundation.org
Subject: Re: linux-next: Tree for Apr 15 (vdpa)
Message-ID: <20200416082248-mutt-send-email-mst@kernel.org>
References: <20200415152240.2422e06c@canb.auug.org.au>
 <620e1646-5899-a077-b9de-95443887364d@infradead.org>
 <33e4922f-d2b5-f3fa-4d32-a5db5a177238@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <33e4922f-d2b5-f3fa-4d32-a5db5a177238@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Apr 16, 2020 at 12:07:06PM +0800, Jason Wang wrote:
> 
> On 2020/4/16 上午12:16, Randy Dunlap wrote:
> > On 4/14/20 10:22 PM, Stephen Rothwell wrote:
> > > Hi all,
> > > 
> > > Changes since 20200414:
> > > 
> > on x86_64:
> > 
> > ERROR: modpost: "vringh_set_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_init_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_iov_push_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_iov_pull_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_complete_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > ERROR: modpost: "vringh_getdesc_iotlb" [drivers/vdpa/vdpa_sim/vdpa_sim.ko] undefined!
> > 
> > 
> > Full randconfig file is attached.
> > 
> 
> The config has
> 
> CONFIG_VHOST_IOTLB=m
> CONFIG_VHOST_RING=y
> 
> But we don't select VHOST_IOTLB in VHOST_RING after commit
> e6faeaa128417("vhost: drop vring dependency on iotlb"). Which seems wrong.
> 
> Thanks

Well selecting IOTLB from ring breaks configs which don't need IOTLB.

Legal configurations are:

CONFIG_VHOST_IOTLB=y
CONFIG_VHOST_RING=n

CONFIG_VHOST_IOTLB=m
CONFIG_VHOST_RING=n

CONFIG_VHOST_IOTLB=n
CONFIG_VHOST_RING=n

CONFIG_VHOST_IOTLB=y
CONFIG_VHOST_RING=y

CONFIG_VHOST_IOTLB=n
CONFIG_VHOST_RING=y

CONFIG_VHOST_IOTLB=n
CONFIG_VHOST_RING=m

CONFIG_VHOST_IOTLB=y
CONFIG_VHOST_RING=m

CONFIG_VHOST_IOTLB=m
CONFIG_VHOST_RING=m


So VHOST_RING=y and VHOST_IOTLB=m is the only illegal one.


-- 
MST