Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 16 Apr 2020 13:47:25 +0100
From:   Mark Brown <broonie@kernel.org>
To:     =?iso-8859-1?Q?Cl=E9ment?= Leger <cleger@kalrayinc.com>
Cc:     linux-spi@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] spi: dw: remove cs_control and poll_mode members
 from chip_data
Message-ID: <20200416124725.GI5354@sirena.org.uk>
References: <20200416110823.22565-1-cleger@kalray.eu>
 <20200416110916.22633-1-cleger@kalray.eu>
 <20200416110916.22633-2-cleger@kalray.eu>
 <20200416113539.GG5354@sirena.org.uk>
 <622416308.15749883.1587037855167.JavaMail.zimbra@kalray.eu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="vs0rQTeTompTJjtd"
Content-Disposition: inline
In-Reply-To: <622416308.15749883.1587037855167.JavaMail.zimbra@kalray.eu>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--vs0rQTeTompTJjtd
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 16, 2020 at 01:50:55PM +0200, Cl=E9ment Leger wrote:
> Hi Mark,

Please don't top post, reply in line with needed context.  This allows
readers to readily follow the flow of conversation and understand what
you are talking about and also helps ensure that everything in the
discussion is being addressed.

> Sorry, maybe the commit message was not clear enough but actually
> these fields were not initialized so it does not break anything
> (ie, the default values were always used).

When you remove the definition of the struct and declaration of the
variable pointing to it then the code won't compile.

> > This means that your first patch will break the build, to keep things


--vs0rQTeTompTJjtd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl6YU9wACgkQJNaLcl1U
h9CynAf/cERHw1lDgcjGpWKP29Y6t9qpmuSpunVEQfNALtsXedN0p45TjOiIbLK+
AtwUukszTHyTRJSlerBi2WrcIJCbW6iWJFDAqP05OGfIaDsZM01ZE90Z4jETXK6+
adrBGEQYPqbiCjOyHQhOp2mKTdf7rW9DRVvZiN1AEFVSpwX+XnOULanFl62urimI
IvMAND8D5gPOvr0c/1T5tqXjjpte22V1H9C6ym074dHOKmUYjSkMbx0qGcqo7/Il
QKIs1vLX6ZQ2096YEdBvYb9TQ0XHWDucjediRVodoiuMbiKpeLIxVOrfaOuYOQ2g
bl2IYJ1DjmI9U36oShXwn1cEjVpzEw==
=2I3/
-----END PGP SIGNATURE-----

--vs0rQTeTompTJjtd--