Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1271885ybz; Thu, 16 Apr 2020 06:17:05 -0700 (PDT) X-Google-Smtp-Source: APiQypK1lW2xAVGJaPr/SjREEBDvKXdidXWS2O1WrT7fJvhCarCdKRP3VhJ5uEEag3CMOjOe8pS4 X-Received: by 2002:a50:ff07:: with SMTP id a7mr4419937edu.210.1587043025188; Thu, 16 Apr 2020 06:17:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587043025; cv=none; d=google.com; s=arc-20160816; b=PVS1J9ZCnKPARU8mmibxyVFRbvimgjGZTnO+Kd+p6rlO528BQgKtwIOMgyAnFlZqqO JNgdddKNRM3ZBUI31pPkqU1s5HKrUPQ7kdt+ap+MR5kR2rrVkDlYmdnfG6yBSArpnSzN QofPhRhZToCtFUob//Kx/7Q0ZtDV7ax80VeXIxG5fT07SdX/5wlqEGrzAiRzCcJXoiSR WMEOFh1A08p1egASuTBUFR8CLOf5D340gNQwiZLOZe0Op8qX6ZvfVLGkOt7WGTT2o1WS YwlTGqfbSVdK2W01exTfp/4dVs7h6exoXIJokkBn3AuDrQjKjp4+dILZrUqf6LOECvZS NRgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:ironport-sdr:ironport-sdr; bh=8vgw2EzErQbOHO2WQk9OdclTXJ+uGqZCOR26ky6R+hI=; b=I36oNEBCFVnBMMhEf411ycuLul3sa1sgDrwIQS65LUGa+dwjOMMMC+zgRMa3ljwE4R /8Tr3NS+MmA6z815yXVjCr3pLJkjRZcFVyyvKI2mZTq2lSE6tMcpbcWDfrYxiq1s6W1f yEv4m1h5tLSioproN9oDstcdcKaVsQ8RuxJnU2tc6dIO8HKI2ifFDqee/t7O9x5sudiT aHsbdR8Hvn8emVpg0BeCdf/tjhzuzazW9x4Xn3BHM/S2265qexOSFyOCCCgJBcIx3TVx BvawY1wKZ7/c87k8e3vQdTHkgUSVHLAHjIb2qKSlKU6hpqSBuw1bBS8FtI5S4t9U9MPg CBYw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 30si14761557edr.255.2020.04.16.06.16.41; Thu, 16 Apr 2020 06:17:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2894986AbgDPNOG (ORCPT + 99 others); Thu, 16 Apr 2020 09:14:06 -0400 Received: from mga14.intel.com ([192.55.52.115]:27289 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2894939AbgDPNOC (ORCPT ); Thu, 16 Apr 2020 09:14:02 -0400 IronPort-SDR: CcmgXTLjx0NJ1DluPc8qvyzD++5ZOQo8ZhR4P5O+DATiRMyqdPHLkv/SUgOhVYm5BdJYBNgA/I /PwBQCvCF3Kw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 06:13:42 -0700 IronPort-SDR: WvI81BDYmtxqUsTDFRbJ7tWkzpztLdDLQPZXYSdcA4+j62BciXmPy3JbTTpOaVrSVcm/25Ai/b yJajpsV9fqOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,391,1580803200"; d="scan'208";a="332834202" Received: from otazetdi-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.42.128]) by orsmga001.jf.intel.com with ESMTP; 16 Apr 2020 06:13:39 -0700 Date: Thu, 16 Apr 2020 16:13:39 +0300 From: Jarkko Sakkinen To: Hans de Goede Cc: linux-integrity@vger.kernel.org, stable@vger.kernel.org, Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH] tpm/tpm_tis: Free IRQ if probing fails Message-ID: <20200416131339.GB65786@linux.intel.com> References: <20200412170412.324200-1-jarkko.sakkinen@linux.intel.com> <20200413180732.GA11147@linux.intel.com> <7df7f8bd-c65e-1435-7e82-b9f4ecd729de@redhat.com> <20200414071349.GA8403@linux.intel.com> <20200414160404.GA32775@linux.intel.com> <20200414164542.GC32775@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 07:15:08PM +0200, Hans de Goede wrote: > Sounds good, I guess it would be best to combine that with a: > > if (priv->irq == 0) > return; > > At the top of disable_interrupts() and then unconditionally > call disable_interrupts() where your v1 of this patch > calls devm_free_irq(). That would be a reasonable clean > solution I think. Great, this was my plan (just wanted to double check). /Jarkko