Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] net/mlx5: add the missing space character
To:     Saeed Mahameed <saeedm@mellanox.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "leon@kernel.org" <leon@kernel.org>
Cc:     "cai@lca.pw" <cai@lca.pw>,
        "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
        "lsahlber@redhat.com" <lsahlber@redhat.com>,
        "kw@linux.com" <kw@linux.com>,
        "xiubli@redhat.com" <xiubli@redhat.com>,
        "airlied@redhat.com" <airlied@redhat.com>,
        Moshe Shemesh <moshe@mellanox.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "wqu@suse.com" <wqu@suse.com>,
        "chris@chris-wilson.co.uk" <chris@chris-wilson.co.uk>,
        "yamada.masahiro@socionext.com" <yamada.masahiro@socionext.com>,
        "stfrench@microsoft.com" <stfrench@microsoft.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
References: <20200403042659.9167-1-xianfengting221@163.com>
 <14df0ecf093bb2df4efaf9e6f5220ea2bf863f53.camel@mellanox.com>
From:   Hu Haowen <xianfengting221@163.com>
Message-ID: <fae7a094-62e8-d797-a89b-23faf0eb374e@163.com>
Date:   Thu, 16 Apr 2020 22:44:17 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.9.0
MIME-Version: 1.0
In-Reply-To: <14df0ecf093bb2df4efaf9e6f5220ea2bf863f53.camel@mellanox.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2020/4/9 3:42 AM, Saeed Mahameed wrote:
> On Fri, 2020-04-03 at 12:26 +0800, Hu Haowen wrote:
>> Commit 91b56d8462a9 ("net/mlx5: improve some comments") did not add
>> that missing space character and this commit is used to fix it up.
>>
>> Fixes: 91b56d8462a9 ("net/mlx5: improve some comments")
>>
> Please re-spin and submit to net-next once net-next re-opens,
> avoid referencing the above commit since this patch is a stand alone
> and has nothing to do with that patch.. just have a stand alone commit
> message explaining the space fix.

Sorry for my late reply. Because I'm a kernel newbie, I know nothing
about the basic methods and manners in the kernel development. Thanks
a lot for your patience on my mistake, pointing it out and fixing it
up.

Btw, did net-next re-open and did my changes get into the mainline?


>
> i fixed the commit message of the previous patch, so the Fixes tag is
> unnecessary
>
>> Signed-off-by: Hu Haowen <xianfengting221@163.com>
>
>> ---
>>   drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
>> b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
>> index c9c9b479bda5..31bddb48e5c3 100644
>> --- a/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/diag/fw_tracer.c
>> @@ -676,7 +676,7 @@ static void mlx5_fw_tracer_handle_traces(struct
>> work_struct *work)
>>   	block_count = tracer->buff.size / TRACER_BLOCK_SIZE_BYTE;
>>   	start_offset = tracer->buff.consumer_index *
>> TRACER_BLOCK_SIZE_BYTE;
>>   
>> -	/* Copy the block to local buffer to avoid HW override while
>> being processed*/
>> +	/* Copy the block to local buffer to avoid HW override while
>> being processed */
>>   	memcpy(tmp_trace_block, tracer->buff.log_buf + start_offset,
>>   	       TRACER_BLOCK_SIZE_BYTE);
>>