Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1389141ybz; Thu, 16 Apr 2020 08:19:18 -0700 (PDT) X-Google-Smtp-Source: APiQypIN9gQ6L+epjAGB2jQrt+k36D0CByxIbEP4xYguyrZDGS/kVuzo5cK5V7kuwuri5ygR4BjG X-Received: by 2002:a17:906:5c0f:: with SMTP id e15mr9450499ejq.159.1587050358757; Thu, 16 Apr 2020 08:19:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587050358; cv=none; d=google.com; s=arc-20160816; b=0rLXxbNd8OMGzrJ4tcrupN0wNI2lWi+6kgGRf7F6fN96gL1tr5szDyNTn6RqTsTKZD 0kecXSVua9fA2CTIrqfIhfcXzSwvU28vk3VwhX0/plB/nMbph9DW1j/yLlSHwXQMHCKJ 4cstEjTitV1wTIKpUCBe8EdfsZEL8JXGETVpnTA9WeE8B2iW9tJi7bbP7qLohhGKVeeE DBKRrXAWZ+4uEEud9M0bfGrJSRDN1YHQHcwuk1mHzr4UtGgHIotOg6TP7w2feLoWidsF nxSfJE6BQ+P/+K2wVXJBrMLWAw0oJ2SZmR5nCHUu82sNDa5RlCLcbIEw2vyGTn/BH1X1 Ve9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=EMOAyk88D6R977qjoB69yr418f3v14O5N4yjBpZ3sgw=; b=gjk32PbgNq4OtFbedMbOv1RZEE9y/85fJfQpJIM/iDMXL9B/e+1IWBFy/4OOSfLVPA hepiEstzOVSkMCZnLPBjehPg4nwUi1CnoboA4oOnmSE5jtY6ZAA9a1WO0SNgouTSiduB FOykh7rZGgy3Ax1LnzJVV2M8ephyt6pFcSZsW20Zg7jtJBRnqpHLh0x7ZwUaeqdE3pMz D3q/h/bVU7Pu87hpFP3qqJsxKqYRpsyAzQwUIxv5aCUi1F13L5c8LgzDHFOgrnREY7rh 6ypP6C9eSpP7huE5iQzvjY6lnC9650EFbcC2vg/BcH4kFOzmggV7E4VSjueRIz4aBKGF pzBg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JUtGO1vf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s1si13066005edw.590.2020.04.16.08.18.55; Thu, 16 Apr 2020 08:19:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=JUtGO1vf; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387452AbgDPPRN (ORCPT + 99 others); Thu, 16 Apr 2020 11:17:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:35048 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2898808AbgDPNtB (ORCPT ); Thu, 16 Apr 2020 09:49:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95AFD22275; Thu, 16 Apr 2020 13:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587044941; bh=jMsruKGjjFKM1+jVEVDnynaeTh0Q77G9inJ3ExDcGzQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JUtGO1vfOJtqaQM6bluE/tkhkB+Bk1stYY4Zi0N7r/1VepsZhqx2pbO2YWaI6pn02 tqN2g/cROd+0/l7cQEgo1/f4EvojSZNtDBFRC7d1kpSDGg26Y0RbB8zdd/KpFGDQun 7UDn+axFJsuTqhbv7LkVKLHUFQenaQfODTnu8+zA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Harshini Shetty , Mike Snitzer Subject: [PATCH 5.4 163/232] dm verity fec: fix memory leak in verity_fec_dtr Date: Thu, 16 Apr 2020 15:24:17 +0200 Message-Id: <20200416131335.414898097@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131316.640996080@linuxfoundation.org> References: <20200416131316.640996080@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shetty, Harshini X (EXT-Sony Mobile) commit 75fa601934fda23d2f15bf44b09c2401942d8e15 upstream. Fix below kmemleak detected in verity_fec_ctr. output_pool is allocated for each dm-verity-fec device. But it is not freed when dm-table for the verity target is removed. Hence free the output mempool in destructor function verity_fec_dtr. unreferenced object 0xffffffffa574d000 (size 4096): comm "init", pid 1667, jiffies 4294894890 (age 307.168s) hex dump (first 32 bytes): 8e 36 00 98 66 a8 0b 9b 00 00 00 00 00 00 00 00 .6..f........... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<0000000060e82407>] __kmalloc+0x2b4/0x340 [<00000000dd99488f>] mempool_kmalloc+0x18/0x20 [<000000002560172b>] mempool_init_node+0x98/0x118 [<000000006c3574d2>] mempool_init+0x14/0x20 [<0000000008cb266e>] verity_fec_ctr+0x388/0x3b0 [<000000000887261b>] verity_ctr+0x87c/0x8d0 [<000000002b1e1c62>] dm_table_add_target+0x174/0x348 [<000000002ad89eda>] table_load+0xe4/0x328 [<000000001f06f5e9>] dm_ctl_ioctl+0x3b4/0x5a0 [<00000000bee5fbb7>] do_vfs_ioctl+0x5dc/0x928 [<00000000b475b8f5>] __arm64_sys_ioctl+0x70/0x98 [<000000005361e2e8>] el0_svc_common+0xa0/0x158 [<000000001374818f>] el0_svc_handler+0x6c/0x88 [<000000003364e9f4>] el0_svc+0x8/0xc [<000000009d84cec9>] 0xffffffffffffffff Fixes: a739ff3f543af ("dm verity: add support for forward error correction") Depends-on: 6f1c819c219f7 ("dm: convert to bioset_init()/mempool_init()") Cc: stable@vger.kernel.org Signed-off-by: Harshini Shetty Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-verity-fec.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/md/dm-verity-fec.c +++ b/drivers/md/dm-verity-fec.c @@ -551,6 +551,7 @@ void verity_fec_dtr(struct dm_verity *v) mempool_exit(&f->rs_pool); mempool_exit(&f->prealloc_pool); mempool_exit(&f->extra_pool); + mempool_exit(&f->output_pool); kmem_cache_destroy(f->cache); if (f->data_bufio)