Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1396348ybz; Thu, 16 Apr 2020 08:26:39 -0700 (PDT) X-Google-Smtp-Source: APiQypLwzLCa2JtGuErI2yAr4ZN6GUqQEzNyxsS9wp7ma5WvLNG6wSlS0Y1NR0luxQOsBshcww8v X-Received: by 2002:aa7:d0d8:: with SMTP id u24mr8042119edo.138.1587050799188; Thu, 16 Apr 2020 08:26:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587050799; cv=none; d=google.com; s=arc-20160816; b=lz5yVsTgtn3gndHDZHbk6w9C9yWhO28FCLAoih3ccL50jvqtJmQHK+bA8tgXX5mePa CgtXq+vLoARzsrjhrsjGMZhVNB58shty7ClyGMCC9/wvWTEcVuipb0/DRsTKtsPjWb+L dzZV3u97pSTprVsDnWT3oAgZ4PTl8cZzBZJ99V7zrvsiMvH0j9DgZYdnTM3vGj/7tdOx L02JXzIK2Hih/3BvmBCUJLkeatso+k1MrGB/G47BYiMGlojxoXzi/R+y/z7/PCRpovRI YFU9jdadVdGr7/mljwk1QYxphmpXvaGbIa81iOzcMqYl1p1toR7mLVSeMhYXTm8toNBy tRbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=v4b/j6mcqDiENYYQL3eEUmKS+1Ml7SMMZw6YZdIPCyM=; b=WEiWikrzN6dZ0hHYbGQxo5h/w3BdnJtsernMhRl1x+WX2tZ/JnyEfNKZ7RI4rkgoL+ in/2YFrWstoiiOX3oJ2v0xqvSR5c3j3Txgwf6KOFjQcxmb4iYIxbxc8jYcCAI9Vv8qFO y/GSZJqcDGZSWzh1bk640kMOHy7pcBKG/AVtfZUmyg+gd0tUhPA+6pQQcPfPZ+FSHr9V N01ahoqPnp0ZANvjxmy9w6CH+DoC5Zy1nLArPaN82cTbXLL6knjaxauMOHSfbByebhJK hjf6abImMZtLmoT3l0inDGve8ypR/iFIlfL3rM9eJkeZ/RvH2N/gFGsOU22CpSR36cr8 vvmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ivxj3U7W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b11si13781970edq.566.2020.04.16.08.26.15; Thu, 16 Apr 2020 08:26:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Ivxj3U7W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2633982AbgDPPX4 (ORCPT + 99 others); Thu, 16 Apr 2020 11:23:56 -0400 Received: from mail.kernel.org ([198.145.29.99]:37410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395166AbgDPPXr (ORCPT ); Thu, 16 Apr 2020 11:23:47 -0400 Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6B1A7206D6; Thu, 16 Apr 2020 15:23:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587050627; bh=NZWRfbKCU3e1vKz9ksF25BpNuwFMYPJivYt57TEZYUM=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=Ivxj3U7WYuce2CfCor9Ix8Kd4Azv+1Cs6CbH5sq7vsrsKStmg6SwG679WHI+sa1rX wdUqoVuEbQq2dkKifgpk2AGxmBXpl6oEZx9KZGtoOKHr+zG+7xtMNroa6c4cPoig7J KbqoEwfwBgTO1bBD3w1FQhgZ9B5XYpYzuZmQQtiA= Date: Thu, 16 Apr 2020 16:23:44 +0100 From: Mark Brown To: Matthias Blankertz Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , Liam Girdwood , linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Mark Brown , Takashi Iwai Subject: Applied "ASoC: rsnd: Fix HDMI channel mapping for multi-SSI mode" to the asoc tree In-Reply-To: <20200415141017.384017-3-matthias.blankertz@cetitec.com> Message-Id: X-Patchwork-Hint: ignore Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: rsnd: Fix HDMI channel mapping for multi-SSI mode has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From b94e164759b82d0c1c80d4b1c8f12c9bee83f11d Mon Sep 17 00:00:00 2001 From: Matthias Blankertz Date: Wed, 15 Apr 2020 16:10:17 +0200 Subject: [PATCH] ASoC: rsnd: Fix HDMI channel mapping for multi-SSI mode The HDMI?_SEL register maps up to four stereo SSI data lanes onto the sdata[0..3] inputs of the HDMI output block. The upper half of the register contains four blocks of 4 bits, with the most significant controlling the sdata3 line and the least significant the sdata0 line. The shift calculation has an off-by-one error, causing the parent SSI to be mapped to sdata3, the first multi-SSI child to sdata0 and so forth. As the parent SSI transmits the stereo L/R channels, and the HDMI core expects it on the sdata0 line, this causes no audio to be output when playing stereo audio on a multichannel capable HDMI out, and multichannel audio has permutated channels. Fix the shift calculation to map the parent SSI to sdata0, the first child to sdata1 etc. Signed-off-by: Matthias Blankertz Acked-by: Kuninori Morimoto Link: https://lore.kernel.org/r/20200415141017.384017-3-matthias.blankertz@cetitec.com Signed-off-by: Mark Brown --- sound/soc/sh/rcar/ssiu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c index f35d88211887..9c7c3e7539c9 100644 --- a/sound/soc/sh/rcar/ssiu.c +++ b/sound/soc/sh/rcar/ssiu.c @@ -221,7 +221,7 @@ static int rsnd_ssiu_init_gen2(struct rsnd_mod *mod, i; for_each_rsnd_mod_array(i, pos, io, rsnd_ssi_array) { - shift = (i * 4) + 16; + shift = (i * 4) + 20; val = (val & ~(0xF << shift)) | rsnd_mod_id(pos) << shift; } -- 2.20.1