Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1399909ybz; Thu, 16 Apr 2020 08:30:25 -0700 (PDT) X-Google-Smtp-Source: APiQypK0nEkXjrSWnah6+bT0TW6vf2e+5rihUVzDN0CGmov62tf+TxJrjNGft3WWW+Zi3Bw9fXct X-Received: by 2002:a17:906:2ccc:: with SMTP id r12mr10397766ejr.47.1587051024910; Thu, 16 Apr 2020 08:30:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587051024; cv=none; d=google.com; s=arc-20160816; b=joFza7QNBwrdV+sEZHmRV1SyZh2okT0H6U5R2zLLuQHg8oMSE/8lq3Vkob7yjRyhsD dlwByy8VbW0v5h+DdU/GiAkocpmFvjRMlP0nWFhcUPZKz2WkP/WRrUn0SsFD546Cxb+R hyU2BtYZGZ64hGlNSnVBK6Q7RykL1iyKOv/xxfHf97x5JNF0pZxp8szJlqDKZi07ccJM qqCTxIIYZnBc7szMB75UAycmhA+v5lkQeemrWF42ueG4gZJ4+LFcKLC/qQPLWJDMLvKw UjaTCpMXzLfk9MzHj2qHEa9c/2MobFq1/vlJTlK/zXDOBF4MbK283rhVq4BYoiqqeCpI pDvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=J+iM4IV/bLEyrF9kw46DZpxuO4x2QaA2JmBIMEiwT5M=; b=SNPfIsOha2MWa5MIZ+4vrjPg3zoKtHjXc3+b/ywDzRFBggD4is8T9qouruVIup2E0g 5dxAd9qoA571I+Jlgt+r4PVC2FC9T5zqC7/3L8XMPQn8vwEL6sWAHh+cpIERSzzOxEFI BFvaa0pT8JGXk5Hq7e6v+CIja41pktvfl2Og/lZcLcteYQqtsbnBh2l9ps+ur29evglR qNkfP8AEWCVf/8USQdqiAo6c4neoE6Fs9BWAUGYj22Od3n2FORhALL4Nviz5XwfRxFii W3S/hYw2P/Ob2SEAZHAVgmYVhB2k9AjNCmeHdEZjvIgJJFC5ifvpCtR8V69FhdveA4mK RJkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=k0w5KgsQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jr16si12108307ejb.374.2020.04.16.08.29.55; Thu, 16 Apr 2020 08:30:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=k0w5KgsQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2395251AbgDPP1s (ORCPT + 99 others); Thu, 16 Apr 2020 11:27:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S2392343AbgDPP1P (ORCPT ); Thu, 16 Apr 2020 11:27:15 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46E2DC061A0F for ; Thu, 16 Apr 2020 08:27:15 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id d2so7319357ilc.0 for ; Thu, 16 Apr 2020 08:27:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=J+iM4IV/bLEyrF9kw46DZpxuO4x2QaA2JmBIMEiwT5M=; b=k0w5KgsQW7J5bI3TlEYBfxGM81pCvY0fB9a4hzWcaD3hTWXEUa4NOh3fyBwV14FPZa I99cQhbp/5Vc5WzgFRSmdQo4Gn68RVa3Z+BndxfAYykQz3Yagrp2TMLzBkmyZvHbCWgH UdsDfP/84bkpwxejAVeeFvmYzZzPo0pBzbRZRIAlK8KC6+b6yRwQb65juf2rwZHesF+K roCv09PQHLX/CJKnJriR69mdDqeWURCvcfZUOAId0VmMrAi+opR//HRS5RZV1q8SWdxt MUEie0Mz2ukiUybilfMOY6+j+lbBfOIyA4uSu0p8U1qEwPSa2AkIQg8yiESOuzFJe260 REDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=J+iM4IV/bLEyrF9kw46DZpxuO4x2QaA2JmBIMEiwT5M=; b=HE3T133WtfoYazPDP/X9mhRKUPdYKRc72b26gce8vorUvyv4JTI+P6vehK7l+HMdun n5ccfuWP1VET0kPspUipiAA6qq+2tWVbbI2TdZn1vjqmYLs5GG+N0IzyWEd+p4erseCs IX99XSFMz//CgwfApBphdXFDBBDBcFO5zg+FRIIp9lZysLFWpBpiYxxQLdoxIyBL//Yw 3AYpBEllpWgk4YHe5McJ2Kjjfng/IWXZnGs00JFxvNPMFurnrbkgl2amidK0lMK33SYm r6wqShJ82XBlk6tRVheg6HHQ7zhoFfmN8gKGXXy2fNi5bss7NxFpV42MOMylfV8SLKid zmmA== X-Gm-Message-State: AGi0PuaIsx0SeRutARhUZt6hZvj0vIoml/4i1CPowVhILMtERZG45nGf kJdDSyqRImDVPQgD/Tsggc+BIQ== X-Received: by 2002:a92:606:: with SMTP id x6mr10385653ilg.92.1587050834482; Thu, 16 Apr 2020 08:27:14 -0700 (PDT) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id 10sm7234116ilb.45.2020.04.16.08.27.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2020 08:27:13 -0700 (PDT) Subject: Re: [PATCH] blk-mq: Put driver tag in blk_mq_dispatch_rq_list() when no budget To: John Garry Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ming.lei@redhat.com References: <1587035931-125028-1-git-send-email-john.garry@huawei.com> From: Jens Axboe Message-ID: <8b247811-7ce5-7a2c-66f4-1a45235f622c@kernel.dk> Date: Thu, 16 Apr 2020 09:27:12 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <1587035931-125028-1-git-send-email-john.garry@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/16/20 5:18 AM, John Garry wrote: > If in blk_mq_dispatch_rq_list() we find no budget, then we break of the > dispatch loop, but the request may keep the driver tag, evaulated > in 'nxt' in the previous loop iteration. > > Fix by putting the driver tag for that request. Applied, thanks. -- Jens Axboe