Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1403189ybz; Thu, 16 Apr 2020 08:33:46 -0700 (PDT) X-Google-Smtp-Source: APiQypLeWsICQvgON4PTm8FoajL8uVIEhFtlSOgGQZ7IzdcEZxreZvxsAqCGY4DABFd9swYyMfiu X-Received: by 2002:a17:906:64b:: with SMTP id t11mr10034692ejb.224.1587051226555; Thu, 16 Apr 2020 08:33:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587051226; cv=none; d=google.com; s=arc-20160816; b=e/ImvO+8TwmGlqqburr/lC2hpF+7EEr8H/LBHb1VVyccY/wJSE+DiCkL22NJAGG6cy EfTQbxaTYNr3YiQ5acmGvuMYpZ8dP8seqXfd1rvt5nMoaBJQxXX1z3MZzIQdt4lwQDs9 JfVin4eRk3LEi/bGIY55+28/vwfzeKBhiikARkY7B5z2x/wSg6L6nAb0mbAR+RxmehUx 4J3dtScWnFXGjY/c+cLqRjXGu5vMHVRbAnmVwSnMoqKj4K4HJ5Go3vM3ilhPCTHzScqi 04UPAs58cgWqp9YutnBouePphxSiSEQC0K6DAUef0/ecpjh+3FnO5OXLEjvCHVWhgTGN o1hw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=VcWQ/PVO0oPYd3gTeAfmzJCfHzslL3qe6WI7TUMu4p8=; b=rprYiU6SHUSW3wUJGyMNT2aXx5XKd99mrtOgDC3arikxb5DRk5GeV2lgrZdNqPU1lU VuMkJ2SAjpPNFXjc40oUR4/MN6mlwrtLelHVJZREBKJOhOUfENASKtSKAVOzyc06NJ/E lSxBHiErS9LAFj+Xb190CykWuKgMGM+/vR+61a+XTT/8Sr6n8FTC5EUk7ieBp5iYetbD im1KHcv+Ymt6Ivehrw7uJ76RMfhXzmfyZ/QKmKBwFC6ZZY8OrZ5Ua5tYyfv/e8+H6q2k hpCIVaLTPGUBSYjsOYw5v7XGfgxpQTAZvsdHgK+N7BVLYnZfxph/RTceoG+ZOYfZm7Ho 4rxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AsBhb1Xt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c7si6544495edq.184.2020.04.16.08.33.22; Thu, 16 Apr 2020 08:33:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=AsBhb1Xt; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2442429AbgDPPbT (ORCPT + 99 others); Thu, 16 Apr 2020 11:31:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:56210 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392188AbgDPNnA (ORCPT ); Thu, 16 Apr 2020 09:43:00 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2DF9C2222C; Thu, 16 Apr 2020 13:42:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587044579; bh=jO0bfRACoDqbJtxtvsGKsvpEltAHBXHauexTK0lbnSo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AsBhb1XtSnCtzIg7OHX1nIJoiaTa/8PBIVv3Robk48B6126+IQL/m8O4gsrNQkpgh JADId8g4qRrNqrF0PD1dFoNs8U6g61EYex58gFxJ4ORMrV0G80G9sdtMjQNGpHSwVf ijbhLu7724SMgjYxvmMVdr4/nBEbvTIcRnBEdpf4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Raju Rangoju , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 018/232] cxgb4/ptp: pass the sign of offset delta in FW CMD Date: Thu, 16 Apr 2020 15:21:52 +0200 Message-Id: <20200416131318.596803079@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131316.640996080@linuxfoundation.org> References: <20200416131316.640996080@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Raju Rangoju [ Upstream commit 50e0d28d3808146cc19b0d5564ef4ba9e5bf3846 ] cxgb4_ptp_fineadjtime() doesn't pass the signedness of offset delta in FW_PTP_CMD. Fix it by passing correct sign. Signed-off-by: Raju Rangoju Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c index 58a039c3224ad..af1f40cbccc88 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c @@ -246,6 +246,9 @@ static int cxgb4_ptp_fineadjtime(struct adapter *adapter, s64 delta) FW_PTP_CMD_PORTID_V(0)); c.retval_len16 = cpu_to_be32(FW_CMD_LEN16_V(sizeof(c) / 16)); c.u.ts.sc = FW_PTP_SC_ADJ_FTIME; + c.u.ts.sign = (delta < 0) ? 1 : 0; + if (delta < 0) + delta = -delta; c.u.ts.tm = cpu_to_be64(delta); err = t4_wr_mbox(adapter, adapter->mbox, &c, sizeof(c), NULL); -- 2.20.1