Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1404438ybz; Thu, 16 Apr 2020 08:35:02 -0700 (PDT) X-Google-Smtp-Source: APiQypLBzbzInKQDS09c1AF9LVh8l2EFxN++2L/C/hydA1ZBG6LSUkodz6N2RtgKhbPYYaYa2H5B X-Received: by 2002:a50:cb84:: with SMTP id k4mr31306260edi.89.1587051302375; Thu, 16 Apr 2020 08:35:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587051302; cv=none; d=google.com; s=arc-20160816; b=K5lULLMf+Z75WCSkgfEW6jA9AUdUHhSls0aLh06hjl1eQ2DjIIrVWcuXHojTwHqDdJ HnmB4ss3Aj8Fxlx2oUhGOmjazXCBnp0Cb34FcKM0qJYpmwqkVpbbT1RHe+Vd3i9q5L8V plkKx9yO3Zv4YN0ys0FtYPa/PLTiDzdxkkKqeioakjhJ1kwTQ6o8V26OObbmrEPT2OyJ FjxVxkPNb5OxH8gJLR0BonLN7ZwdTRhONT4XWhPYwJ0Itt99gL2ELLnBfKjlsoqSnhMg 56+VGB+kQ0JTqa/VkJMQQgjBBebKxpzJhtsHANLx5zfYCOP9TnsJHHZrWoeH/z6VIxTd +6Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=N2MDlnU/0sIUnshbQf/UuhlFayHs0cxSUtHnZUZF5Vo=; b=FWWNpu2AtaArQ1TN8NItFxfRW7M+inx/nAIZF6jU2ccx+0d12YDJKifVbqnhQKTDbZ jUadB5b4wCSUqD65MrQ5e6RtP3SojvuTsLuW2YTuaeqZRvMnK+hpezrktBh9UMPEYq6A ER/bXAnRaENm6b2xnvY/HyAKtbwrheQojhSVIDdXx19xV3JeZPFWdL0gliAv1IhjqYZE X7mt8n+CXcHYMfwEyS4KGMW/OzLApvk7ZjWn9xiESSMXXp++UfsSAoB8o2RMYBaCpRXN FNXzfId+C45C7hr6+zYAFLXF1xw2spIvPiag7fIBSyOQ+RC1Fk+oWS6mvBzzav4h8dpK 6g1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i26si7650868ejg.474.2020.04.16.08.34.38; Thu, 16 Apr 2020 08:35:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2634271AbgDPP37 (ORCPT + 99 others); Thu, 16 Apr 2020 11:29:59 -0400 Received: from verein.lst.de ([213.95.11.211]:52669 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2395180AbgDPP3u (ORCPT ); Thu, 16 Apr 2020 11:29:50 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id F038268BEB; Thu, 16 Apr 2020 17:29:46 +0200 (CEST) Date: Thu, 16 Apr 2020 17:29:46 +0200 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , yuyufen@huawei.com, tj@kernel.org, jack@suse.cz, bvanassche@acm.org, tytso@mit.edu, gregkh@linuxfoundation.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: bdi: fix use-after-free for dev_name(bdi->dev) Message-ID: <20200416152946.GA10845@lst.de> References: <20200416071519.807660-1-hch@lst.de> <874d57cb-90f1-db09-8f9d-29527451e241@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874d57cb-90f1-db09-8f9d-29527451e241@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 16, 2020 at 09:29:13AM -0600, Jens Axboe wrote: > On 4/16/20 1:15 AM, Christoph Hellwig wrote: > > Hi all, > > > > the first three patches are my take on the proposal from Yufen Yu > > to fix the use after free of the device name of the bdi device. > > > > The rest is vaguely related cleanups. > > Applied, thanks. Please hold back, we still have a major issues with it. I will resend a fixed version tomorrow.