Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1442444ybz; Thu, 16 Apr 2020 09:13:47 -0700 (PDT) X-Google-Smtp-Source: APiQypJM6K2oWM3t+hoCz/KPn7oxxei6Na3PMmMjtwkU5WwicxFyI2oN3C1bBh2GOlB4fLKYV/MP X-Received: by 2002:a50:e68e:: with SMTP id z14mr31410933edm.307.1587053626915; Thu, 16 Apr 2020 09:13:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587053626; cv=none; d=google.com; s=arc-20160816; b=vbniZu1KrmBewfhqZptp1PNLosiKwNw5IFm9OhmM1wUOJGXJt1AG86omAGIRxhTMtm xPdiogfd/LWDvkpZZB/oGuvqf+qTWjibZM0irgBnS0yKqg1mVGIsg05LsoZxCs9irWra sVznwtfhCbOcGVZ2wSXzTCjDIRQuVg7WPaoFgxSQgDnfleH7c2cLyI1xc26lLrG+/eYs YLXwp2FvbUGbphKmnBRX41ZW4oKpbJ/RyOlJTiYAxyfMfsvDm3P564mOadPTVtaH83Vs 8A+86ZEBK0QG97Q5xq3+D4XxR/Use+7UcFc4239A4XHnIxe+DMOYVgGrids6YQzVtImH Ra+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:ironport-sdr:ironport-sdr; bh=2MJfgXNgnuT5KNTV7jsxU4xAbh/Ohr0zwfB5mDiXioo=; b=C4sKi3LLooBgOYNRV4lMXJGTrwb7PbpK3LBs92Td1hD4RTGr+T5bddrua7U8+N1gXg FJTyPMFhnL+5r0OWJfW9hyWR714zUhjdUvyq1rjiy7Jw7PIbAxF4GyzDx5JxaW8Npf16 13W+wRO/gyF6Qy54fqN3Z1CHHqmpGLjM7hE43rSJ55F6kEvSz7JebpwouES/foN44PCk QhzH6sXXWK+VgCgBXbCelyrnujtsz8NnaP3MSdYHRSTfhCBFRNvRTpIsLMNwhWNX/DFJ IaUUitE/rS5ssQvh5Nd7WjszGxLH/LZ48q3b5bnTxmqld0APFYBPu2lBZAE8MjSVeWgn UlSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dk10si3341629edb.3.2020.04.16.09.13.22; Thu, 16 Apr 2020 09:13:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2506003AbgDPQLs (ORCPT + 99 others); Thu, 16 Apr 2020 12:11:48 -0400 Received: from mga02.intel.com ([134.134.136.20]:59774 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729590AbgDPQLp (ORCPT ); Thu, 16 Apr 2020 12:11:45 -0400 IronPort-SDR: GDEFM96pkWk7SITHruncP6SCCHuoCEc4+tNp9fBWpTAU/C1tpfYG72y1Yw7Mkp3VlXsHk7ubIr zQfHV1RD5GyA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2020 09:11:44 -0700 IronPort-SDR: q5OWoPoACa6Z3qbloJMXeX+bcgoLmhw37ndlmffyLuRUZLNvt/iYRC/1fjvi6j0MpupWgYVHQd c0dpwSj3rnfQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,391,1580803200"; d="scan'208";a="272118808" Received: from otazetdi-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.42.128]) by orsmga002.jf.intel.com with ESMTP; 16 Apr 2020 09:11:42 -0700 Date: Thu, 16 Apr 2020 19:11:41 +0300 From: Jarkko Sakkinen To: Roberto Sassu , Tianjia Zhang , "peterhuewe@gmx.de" , "jgg@ziepe.ca" , "arnd@arndb.de" , "gregkh@linuxfoundation.org" , "zhang.jia@linux.alibaba.com" , "linux-integrity@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Silviu Vlasceanu Subject: Re: [PATCH] tpm: fix wrong return value in tpm_pcr_extend Message-ID: <20200416161141.GA181141@linux.intel.com> References: <20200414114226.96691-1-tianjia.zhang@linux.alibaba.com> <76d46ffbad294a6385779c29c4e5cafd@huawei.com> <20200414193542.GB13000@linux.intel.com> <20200414202615.stnurisucqxblenj@cantor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200414202615.stnurisucqxblenj@cantor> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 14, 2020 at 01:26:15PM -0700, Jerry Snitselaar wrote: > On Tue Apr 14 20, Jarkko Sakkinen wrote: > > On Tue, Apr 14, 2020 at 11:55:43AM +0000, Roberto Sassu wrote: > > > > -----Original Message----- > > > > From: linux-integrity-owner@vger.kernel.org [mailto:linux-integrity- > > > > owner@vger.kernel.org] On Behalf Of Tianjia Zhang > > > > Sent: Tuesday, April 14, 2020 1:42 PM > > > > To: peterhuewe@gmx.de; jarkko.sakkinen@linux.intel.com; jgg@ziepe.ca; > > > > arnd@arndb.de; gregkh@linuxfoundation.org; zhang.jia@linux.alibaba.com > > > > Cc: linux-integrity@vger.kernel.org; linux-kernel@vger.kernel.org; > > > > tianjia.zhang@linux.alibaba.com > > > > Subject: [PATCH] tpm: fix wrong return value in tpm_pcr_extend > > > > > > > > For the algorithm that does not match the bank, a positive > > > > value EINVAL is returned here. I think this is a typo error. > > > > It is necessary to return an error value. > > > > > > Yes, thanks. > > > > > > Reviewed-by: Roberto Sassu > > > > Happen to have the commit ID at hand for fixes? > > > > Thanks. > > > > /Jarkko > > > > 9f75c8224631 ("KEYS: trusted: correctly initialize digests and fix locking issue") Thanks. Also added: Cc: stable@vger.kernel.org # 5.4.x /Jarkko