Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1533125ybz; Thu, 16 Apr 2020 10:50:26 -0700 (PDT) X-Google-Smtp-Source: APiQypIscr7HIuCku9CPt+PQE8oSBZi1ElJvE7GXzIOPt6mIlT8JyoHionP8OkIZTsMW3kl6pRtU X-Received: by 2002:a05:6402:32e:: with SMTP id q14mr31349019edw.84.1587059426022; Thu, 16 Apr 2020 10:50:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587059426; cv=none; d=google.com; s=arc-20160816; b=l7A98l7Oykxe/RQykvXVJ9/n3zvoADsxft3UafY+EaAZ1wp8xdhk8zWiSZlmvmtN/c VxS+uAJfH6qKH2+iJjdx7pkV9od1KyPEvEiX6q348s8ylm/DsVSVlxCVvlO0gk/WJ5n9 yDBHQv3eMHG4FbFk6CESpG+E6F2jIqfWcbxB1Wd+VAwZ0rPrRm1FXFnALd8nIXwcxHNJ CNs2nL7JsIFEfnnAbdCty3IosR+Fnct25T2MqsyacEHX/ReZCyWMn2IwYA9FjnaJ4yVJ dUnL/o/kz/El0HFYlv69BvVPJZeixBbL2kD56rBzVca9+Qupe++BE5D6JIp1N2VFOgNu uHVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hgTMJLANzXAWvoQlLhh/HI6MIO5ZWYvwGft7TJ8chjk=; b=0MlTziyJnTXf/di5sVkGpXZV/qE2n+SzXkkNGZZy6OPkezWJK2M82klrIHxUjBOsJ1 +s187lhgPr+krX91AgQHKot1SFkwNeKipFbYwpZZ5D6HyvIyqiC0jSyhjPRbWoutCIaQ dE24QaO0jNK1IfwqZJyAPkRJ798gMYwIMkMAbTxKUB0kjTTPhsZ6K0pcK9z8q5G6uVCb aR1Ls/aNTV1Alrb3PDUVi0VqKzbFYWjL0cT5atwU42oNoHKecXvjbbl1pJMB45X0PCiq ldAJ+rR2+Yxa50FsvOsN5+8dr6vMf7ZINs718v9rfNJ1jXZtiNNgqhBYTrDy82E+hD3G aT/Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EHsY3ZgY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e8si13845831edl.2.2020.04.16.10.50.02; Thu, 16 Apr 2020 10:50:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EHsY3ZgY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2895688AbgDPN2K (ORCPT + 99 others); Thu, 16 Apr 2020 09:28:10 -0400 Received: from mail.kernel.org ([198.145.29.99]:35370 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895347AbgDPN1F (ORCPT ); Thu, 16 Apr 2020 09:27:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B2687206E9; Thu, 16 Apr 2020 13:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587043625; bh=8PpGL1xkqmeHJ2Vira44+EEkc2xrM5AF6XsNGJQaXU4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EHsY3ZgYbacBT58OVUeQTP/5PI+73WXJp7u3i82LAq/qIqJQyHq8LsP1z/p08zQEs 0sNJUgobenWBcy6KfPrPBB9XSRqfLmo8TLajnXvxVMD5F83onBM9JkFlyNITBz9hiK lWs9gHQyiUndNaOzW1qri+9oITszwPpAnh5TCchg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Raju Rangoju , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 007/146] cxgb4/ptp: pass the sign of offset delta in FW CMD Date: Thu, 16 Apr 2020 15:22:28 +0200 Message-Id: <20200416131243.507556526@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131242.353444678@linuxfoundation.org> References: <20200416131242.353444678@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Raju Rangoju [ Upstream commit 50e0d28d3808146cc19b0d5564ef4ba9e5bf3846 ] cxgb4_ptp_fineadjtime() doesn't pass the signedness of offset delta in FW_PTP_CMD. Fix it by passing correct sign. Signed-off-by: Raju Rangoju Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c index 9f9d6cae39d55..758f2b8363282 100644 --- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c +++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_ptp.c @@ -246,6 +246,9 @@ static int cxgb4_ptp_fineadjtime(struct adapter *adapter, s64 delta) FW_PTP_CMD_PORTID_V(0)); c.retval_len16 = cpu_to_be32(FW_CMD_LEN16_V(sizeof(c) / 16)); c.u.ts.sc = FW_PTP_SC_ADJ_FTIME; + c.u.ts.sign = (delta < 0) ? 1 : 0; + if (delta < 0) + delta = -delta; c.u.ts.tm = cpu_to_be64(delta); err = t4_wr_mbox(adapter, adapter->mbox, &c, sizeof(c), NULL); -- 2.20.1