Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1533877ybz; Thu, 16 Apr 2020 10:51:17 -0700 (PDT) X-Google-Smtp-Source: APiQypKvfaJAsS+P7yj9Q/a+EtDVFhI0uBB4qHB+ZURGKdapoYmnhPmXu/5mAdKpA5keY5YnawbG X-Received: by 2002:a17:906:d7a2:: with SMTP id pk2mr11240476ejb.272.1587059477360; Thu, 16 Apr 2020 10:51:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587059477; cv=none; d=google.com; s=arc-20160816; b=WAfUfFO6k7Ne1MBsYOFDGw4hGefPHgwrulI/8m/pQs60YHXsNkTF41cDiCojXRT/ZA pd1mOKqSUzS0h6ZbWkT5pH5PF1G98gGvM9uy6xdUPdgU/GHP33Nznwdvnc0tMyYhy6AZ FKr0WDHPR+YzbTAH1PGNZZeyxyzARzpsflJhF+1r1v4fax2X5RpHDAs1n/4LXd2YW5Lz 8iH/F+JOzSYIDah2Tl7HJuioQ4yQZUWYkI9U5wHqgmkdVj9UF5frcqSwN74MSj+iwI2F eg+NSFZuLYvxQccK89c+i7My2M6YmngYTP2f0NpfYGecSB88AH4M910NJo1Pv0jfrHIw b0XA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Ud4VgI2+ttaefMsCGyggcq99E+lzS6L9r3X1Rl+TwZc=; b=n4zHROUQKzhsLT9nz0taDcYWsMeEygh+qP+KTdSlCrrBESLeDOceRTearK24N7A/Bq UXa/1cVPXWg25DIxfisRCHSB7+qCFfXN60l8DYZpMYv78STUD2iiuXyiaiWx9LRRuSaL YpxSQvc9DO6VstZ5Vr/ZCZl7144HZEi+bWpDLii9hTiV9aR/Q8eR4Y5AcBbFPLzn7Xq/ 61c6U9HvhNB0g+7E2Q7mhaVZc0RgmbjGmC76L0y9NahqiXD7sbiv0/3bh8FBKewhYkFh kwpIqzqBUfS4bJ0ILjY2ZX3nMgWZOzKZn72Fj94BHl56oJopXOwkcbPuWfvakVZyP/jq tJ3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pg1lN2+l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w16si11608508ejb.521.2020.04.16.10.50.54; Thu, 16 Apr 2020 10:51:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pg1lN2+l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2896076AbgDPN3s (ORCPT + 99 others); Thu, 16 Apr 2020 09:29:48 -0400 Received: from mail.kernel.org ([198.145.29.99]:36222 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2895561AbgDPN1m (ORCPT ); Thu, 16 Apr 2020 09:27:42 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D0FB206E9; Thu, 16 Apr 2020 13:27:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587043661; bh=Ldv/NJjXofzhti8uNHL/ou24Ity42qDaHmmg10Dk09I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pg1lN2+l7kdWaiTMSpT9cdvmimpL2BcyAfrhrYPG6C93BsfzP0PGk5C+K6tZVLGbe tX3D63ZOL/6m4aj8alyWb8TS3pun+zk4rXuAn8NsNkS2begpCeY1mmSxChsxabwxcf ilVU+jKWKPmTyF8x+5jHNTiDR4AiBvtsKqzASQB0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thinh Nguyen , Felipe Balbi Subject: [PATCH 4.19 049/146] usb: gadget: composite: Inform controller driver of self-powered Date: Thu, 16 Apr 2020 15:23:10 +0200 Message-Id: <20200416131249.594458723@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131242.353444678@linuxfoundation.org> References: <20200416131242.353444678@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thinh Nguyen commit 5e5caf4fa8d3039140b4548b6ab23dd17fce9b2c upstream. Different configuration/condition may draw different power. Inform the controller driver of the change so it can respond properly (e.g. GET_STATUS request). This fixes an issue with setting MaxPower from configfs. The composite driver doesn't check this value when setting self-powered. Cc: stable@vger.kernel.org Fixes: 88af8bbe4ef7 ("usb: gadget: the start of the configfs interface") Signed-off-by: Thinh Nguyen Signed-off-by: Felipe Balbi Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/composite.c | 9 +++++++++ 1 file changed, 9 insertions(+) --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -847,6 +847,11 @@ static int set_config(struct usb_composi else power = min(power, 900U); done: + if (power <= USB_SELF_POWER_VBUS_MAX_DRAW) + usb_gadget_set_selfpowered(gadget); + else + usb_gadget_clear_selfpowered(gadget); + usb_gadget_vbus_draw(gadget, power); if (result >= 0 && cdev->delayed_status) result = USB_GADGET_DELAYED_STATUS; @@ -2265,6 +2270,7 @@ void composite_suspend(struct usb_gadget cdev->suspended = 1; + usb_gadget_set_selfpowered(gadget); usb_gadget_vbus_draw(gadget, 2); } @@ -2293,6 +2299,9 @@ void composite_resume(struct usb_gadget else maxpower = min(maxpower, 900U); + if (maxpower > USB_SELF_POWER_VBUS_MAX_DRAW) + usb_gadget_clear_selfpowered(gadget); + usb_gadget_vbus_draw(gadget, maxpower); }