Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1642037ybz; Thu, 16 Apr 2020 12:50:26 -0700 (PDT) X-Google-Smtp-Source: APiQypL6lKbJgozfPagiBKnwloPCtwq81TgfegNgPsd9tcWNHSlKSNnP4OkjPXnTXiVlOH3F5Dft X-Received: by 2002:a17:906:adb:: with SMTP id z27mr1074720ejf.263.1587066626140; Thu, 16 Apr 2020 12:50:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587066626; cv=none; d=google.com; s=arc-20160816; b=r2uFh1wk3VxYHuOADoKq3M6Kr8Rr0ssliLJRZBOS4I4oc5MqAHC8HSue81ZI7FvON9 kn5vdJBudX6r0UAeulaJOButKxVl9DsUKjrnncn1rS7GhEVlqswdivV3o/cNE+DgzQyk 9s6Pv76WKi88WqKQEHTr5Kr2wkmyGL10ZLYjLaJiH1l/l+q4H8WE2eYbtWRnoF1lUhtu Ccaw7pqBHSeIZ4lYF0bSRfLcLNlhExwZixBivq6JhHz/KMpUcOH1JjVcCh48cC5x34u1 r3fi5NuLLqAUxQtzuUJfIOrpKyLa3CCZ6kGcEbwePlnU8Ye4ZLdlZFV/vgw0fkdToOCv +sIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=5VsqseOYcQ3Ewd28EQgWkzSWE63pDRgwg1m7TyOoY40=; b=fvI5Z1eyUJkw0F+UrsJ5ujdNwkWVfvR+Bk9no37FAftIswENwBaf6gaesN6E0aJX07 Hnm0Xlwi/yIQwftn6KOhgf7Z1YmpSGVANZXVvtYutK55CDakVsfCHcdyYJJjfcacC6mP us7uw/+aKhVvafhCXkL9jTap81BOvGX3g7JuAeYVeYjhLrTHchvBNUoBvsdQZjpvfkLP tD1c50iLFtt52Uei5aVJeg00XAH8lUT//QHzooEUrwxXnMbvlZXcs5iNGFDBq+4Bhmi6 NUX4jYEL2digJFb1Q1l4B8pG+x0GoaDhGU3f0W2zjIRoaX6fHg0SMKqlO8AaaLxJgSqR f+1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Scpv/tMJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w25si12835863edt.358.2020.04.16.12.50.02; Thu, 16 Apr 2020 12:50:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="Scpv/tMJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2897430AbgDPNhQ (ORCPT + 99 others); Thu, 16 Apr 2020 09:37:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:39984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896113AbgDPN3z (ORCPT ); Thu, 16 Apr 2020 09:29:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0CDEF21D79; Thu, 16 Apr 2020 13:29:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587043795; bh=Oe2n37IU0ZIiK87FA7J1wsyFrCHPIyn5hYyKd8sObtw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Scpv/tMJR37fjxKnSRrdHVDi9IXwSb8BxYltgRmrQwgOQ8ANid5RJ0cz2bonhIBfb m6aKZsQY5MJHSIcuFrct32ldcN7thzl0FV/0DTW+4WI3q5/iMOXghlAHorzStm1GLu xEieIau0jAHQVzQYBdbXrZRl/1v5AdACrfNuhsvw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Harshini Shetty , Mike Snitzer Subject: [PATCH 4.19 103/146] dm verity fec: fix memory leak in verity_fec_dtr Date: Thu, 16 Apr 2020 15:24:04 +0200 Message-Id: <20200416131256.779461399@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131242.353444678@linuxfoundation.org> References: <20200416131242.353444678@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Shetty, Harshini X (EXT-Sony Mobile) commit 75fa601934fda23d2f15bf44b09c2401942d8e15 upstream. Fix below kmemleak detected in verity_fec_ctr. output_pool is allocated for each dm-verity-fec device. But it is not freed when dm-table for the verity target is removed. Hence free the output mempool in destructor function verity_fec_dtr. unreferenced object 0xffffffffa574d000 (size 4096): comm "init", pid 1667, jiffies 4294894890 (age 307.168s) hex dump (first 32 bytes): 8e 36 00 98 66 a8 0b 9b 00 00 00 00 00 00 00 00 .6..f........... 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<0000000060e82407>] __kmalloc+0x2b4/0x340 [<00000000dd99488f>] mempool_kmalloc+0x18/0x20 [<000000002560172b>] mempool_init_node+0x98/0x118 [<000000006c3574d2>] mempool_init+0x14/0x20 [<0000000008cb266e>] verity_fec_ctr+0x388/0x3b0 [<000000000887261b>] verity_ctr+0x87c/0x8d0 [<000000002b1e1c62>] dm_table_add_target+0x174/0x348 [<000000002ad89eda>] table_load+0xe4/0x328 [<000000001f06f5e9>] dm_ctl_ioctl+0x3b4/0x5a0 [<00000000bee5fbb7>] do_vfs_ioctl+0x5dc/0x928 [<00000000b475b8f5>] __arm64_sys_ioctl+0x70/0x98 [<000000005361e2e8>] el0_svc_common+0xa0/0x158 [<000000001374818f>] el0_svc_handler+0x6c/0x88 [<000000003364e9f4>] el0_svc+0x8/0xc [<000000009d84cec9>] 0xffffffffffffffff Fixes: a739ff3f543af ("dm verity: add support for forward error correction") Depends-on: 6f1c819c219f7 ("dm: convert to bioset_init()/mempool_init()") Cc: stable@vger.kernel.org Signed-off-by: Harshini Shetty Signed-off-by: Mike Snitzer Signed-off-by: Greg Kroah-Hartman --- drivers/md/dm-verity-fec.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/md/dm-verity-fec.c +++ b/drivers/md/dm-verity-fec.c @@ -552,6 +552,7 @@ void verity_fec_dtr(struct dm_verity *v) mempool_exit(&f->rs_pool); mempool_exit(&f->prealloc_pool); mempool_exit(&f->extra_pool); + mempool_exit(&f->output_pool); kmem_cache_destroy(f->cache); if (f->data_bufio)