Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1649193ybz; Thu, 16 Apr 2020 12:58:45 -0700 (PDT) X-Google-Smtp-Source: APiQypKQFDdHeBOk2v4/VR5HgC7NN+FJOzODU1SrGLPnANrKjUvxM10jnDgoR69JiCg8kVVjhxjB X-Received: by 2002:a17:906:d215:: with SMTP id w21mr11192527ejz.132.1587067124890; Thu, 16 Apr 2020 12:58:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587067124; cv=none; d=google.com; s=arc-20160816; b=H+CjdjYh0pi+9nFku8Ncbkorpnw69R9ZPSv6963OgLE6K9/tWFRfc1SqXflOW3k52U +sezKEuBR87bFmsQU6mKrt9fbL90RsJCvR10si+VSFFUXGa2hDB2SHzavTETSsNOBTXg ivsKBjP+Qw2c7qCYkJZk5xXg6rUNVprnRsdbe8rX36Dkkszya8+Ra8SE43tOG+FpWT/C Emd22AWIOvlYryLZzfWzN0NyqGx8loOXQq/2lLWx3v5JaGn5oli0tA/IHJa6finXk1HK aTVgPe/q6b9JnoSDHev/SY4LqZyuLgVx21oAbvaNwyIJ1ytXBFqnavXnx0a0g9QEiwXM gnQA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0qttnk4qIllTbDAb+K6uVzo/0U/r8cCOkz9r7Hp4DzI=; b=y3LJsxJzxTc2vu60vU++fw9XMZqWtHacxUm++x70BmsoBSCrZipOvc2RUBExKuHK4O x2hPxUWU8r/3ZEiMBUapNtddjuUoW//jzfOYRQmiLKvEqIk85aRDeEUCSD3M6CdGt5n2 cZolCeHvVYPeiAQM+i8x8dM387doPnSb5gCXfGjrw9Z33oguzjbsPdMnBFL9vesmDw3+ Oeqp37lFWmfK0O+p4bdyt4KZK37r8//6imKhPFARYW3Igxhp8bCAzA6vrC5aou9pLFJ1 FNRYYwG7SeDJb7aNPp/8T4j9AEvaZxC13oMMlBneqPk3Y3VakALQ+42RuZQaofgIgXUQ OAzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1vwg4Wqn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dx23si10630455ejb.181.2020.04.16.12.58.20; Thu, 16 Apr 2020 12:58:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=1vwg4Wqn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2897872AbgDPNjM (ORCPT + 99 others); Thu, 16 Apr 2020 09:39:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:41018 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2896303AbgDPNar (ORCPT ); Thu, 16 Apr 2020 09:30:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41FAD206E9; Thu, 16 Apr 2020 13:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587043846; bh=hPHzP1cI6xI6P4p/39gIrtLEtm8iXU+X02YekCBI8Ho=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=1vwg4WqnYf5TI+v93iCet6sQZJuE/1B4GeiKSPbwTjS4JK1BHDXRgSlXvmd5/E9xR k160nmPdjMPWVK/C5oYgvd98/ANKmyRJBaNs1rVeJuMEM3hYYvDOToPH8V7ggOAjQf 4w5EjNvgflbfQgvYtWdFOEkroWaC7U2dZvjoW3uQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sean Christopherson , Vitaly Kuznetsov , Paolo Bonzini Subject: [PATCH 4.19 084/146] KVM: x86: Gracefully handle __vmalloc() failure during VM allocation Date: Thu, 16 Apr 2020 15:23:45 +0200 Message-Id: <20200416131254.309852839@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131242.353444678@linuxfoundation.org> References: <20200416131242.353444678@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sean Christopherson commit d18b2f43b9147c8005ae0844fb445d8cc6a87e31 upstream. Check the result of __vmalloc() to avoid dereferencing a NULL pointer in the event that allocation failres. Fixes: d1e5b0e98ea27 ("kvm: Make VM ioctl do valloc for some archs") Cc: stable@vger.kernel.org Signed-off-by: Sean Christopherson Reviewed-by: Vitaly Kuznetsov Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- arch/x86/kvm/svm.c | 4 ++++ arch/x86/kvm/vmx.c | 4 ++++ 2 files changed, 8 insertions(+) --- a/arch/x86/kvm/svm.c +++ b/arch/x86/kvm/svm.c @@ -1917,6 +1917,10 @@ static void __unregister_enc_region_lock static struct kvm *svm_vm_alloc(void) { struct kvm_svm *kvm_svm = vzalloc(sizeof(struct kvm_svm)); + + if (!kvm_svm) + return NULL; + return &kvm_svm->kvm; } --- a/arch/x86/kvm/vmx.c +++ b/arch/x86/kvm/vmx.c @@ -10986,6 +10986,10 @@ STACK_FRAME_NON_STANDARD(vmx_vcpu_run); static struct kvm *vmx_vm_alloc(void) { struct kvm_vmx *kvm_vmx = vzalloc(sizeof(struct kvm_vmx)); + + if (!kvm_vmx) + return NULL; + return &kvm_vmx->kvm; }