Received: by 2002:a25:1985:0:0:0:0:0 with SMTP id 127csp1666066ybz; Thu, 16 Apr 2020 13:16:05 -0700 (PDT) X-Google-Smtp-Source: APiQypIJlSNELEl9pyVL3rtuvI9/Y//oorNxoikCD7uK52mt73Tc4OOSdLWoJR3+9F494tY81ed0 X-Received: by 2002:a50:ed19:: with SMTP id j25mr30494174eds.264.1587068164904; Thu, 16 Apr 2020 13:16:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1587068164; cv=none; d=google.com; s=arc-20160816; b=NeyEPqfBIdfXRwxAfCushqfvYO1+wgl7ZwFl9rGJpYHvNRK3kVfuOGBFLgfLHwMMJM QvILkAu1Hv1jNxv2aCXeDhrs+EXNYDP5PptPKJK7V492VvKNDDAULg29mgYqd4dAPujY I7IyX3oaZYTNhlDY3asjTG6Dk7p74SNo0raHUbfwiI9sWQXTsBAwvta9+8XjeD+mo9RA 6XSgGdsfwUHqWlgTCMYG1JWapcB4WMcsOoE7wHZGS/fiJsJcAoMUjSaWArIKReG2Bbmg SUqhTI/ZXVkyMW4ZwRmGfRiVCj4X03Lw7vuXu6iTYCgGlTtrI6zm3jC8/l6AD0+vbaw3 XjbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dpLs3pVKXDYmeKzX4BBCsHbZNuiY2XCrOONLECuNPRw=; b=vwbWD07reKOnkULl6ImxIRt0/gIvIrC6Fz4ny090PWuN47WOzZyx/FaMxRZbdNz4pw f2t1rRKM/2nqO7Br1Ar632cHX1zUZFtgKNoWfM+HyIQerYHArv3AF9TcJ5tSykhdbjCX JA8sdvB4juZV1SMgYNZAAn8TO2kL81H9kkK26lgUeKCHd/r1xl6IXhbQTfoAQ7ibfqJ1 pGayVV5HfCQ0/bhAWzXYkclgc9qEK/tZO1dSX14/vjZoRfnhdSiPWi2ZNqvTkwDLhBXR nqExT/y8lx7VR/aGO1V7y5agRuM+77co3eFA02uV7qwdzcfniYQP+4QU7jBWhrOmE1Hr hZOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EI27Myi8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e25si12774588eje.513.2020.04.16.13.15.41; Thu, 16 Apr 2020 13:16:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EI27Myi8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392890AbgDPOHx (ORCPT + 99 others); Thu, 16 Apr 2020 10:07:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:58658 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2898489AbgDPNpN (ORCPT ); Thu, 16 Apr 2020 09:45:13 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CCE2D21974; Thu, 16 Apr 2020 13:45:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587044713; bh=b1bkKEiIhAph+dn2ToZrwjnu4RBnov2ljwff0iyoAeM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EI27Myi8bbie7Y+dCxH/RInqXtkDVZHxs+CqwHtDCb4uKiPycxBM3aF0w+qhuweOD /IdAOZCN48j0E7zHGm3raCvtc6x5kYSwuSrzq2alPIovVOtPDMo3MIqbC7Ke0VY45g 9a1xEYkl2AeT4Tlq/bYaciJPtJW9kleRgJaAcAR8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Gyeongtaek Lee , Vinod Koul , Mark Brown Subject: [PATCH 5.4 071/232] ASoC: dpcm: allow start or stop during pause for backend Date: Thu, 16 Apr 2020 15:22:45 +0200 Message-Id: <20200416131324.226297216@linuxfoundation.org> X-Mailer: git-send-email 2.26.1 In-Reply-To: <20200416131316.640996080@linuxfoundation.org> References: <20200416131316.640996080@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: 이경택 commit 21fca8bdbb64df1297e8c65a746c4c9f4a689751 upstream. soc_compr_trigger_fe() allows start or stop after pause_push. In dpcm_be_dai_trigger(), however, only pause_release is allowed command after pause_push. So, start or stop after pause in compress offload is always returned as error if the compress offload is used with dpcm. To fix the problem, SND_SOC_DPCM_STATE_PAUSED should be allowed for start or stop command. Signed-off-by: Gyeongtaek Lee Reviewed-by: Vinod Koul Link: https://lore.kernel.org/r/004d01d607c1$7a3d5250$6eb7f6f0$@samsung.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- sound/soc/soc-pcm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) --- a/sound/soc/soc-pcm.c +++ b/sound/soc/soc-pcm.c @@ -2222,7 +2222,8 @@ int dpcm_be_dai_trigger(struct snd_soc_p switch (cmd) { case SNDRV_PCM_TRIGGER_START: if ((be->dpcm[stream].state != SND_SOC_DPCM_STATE_PREPARE) && - (be->dpcm[stream].state != SND_SOC_DPCM_STATE_STOP)) + (be->dpcm[stream].state != SND_SOC_DPCM_STATE_STOP) && + (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PAUSED)) continue; ret = dpcm_do_trigger(dpcm, be_substream, cmd); @@ -2252,7 +2253,8 @@ int dpcm_be_dai_trigger(struct snd_soc_p be->dpcm[stream].state = SND_SOC_DPCM_STATE_START; break; case SNDRV_PCM_TRIGGER_STOP: - if (be->dpcm[stream].state != SND_SOC_DPCM_STATE_START) + if ((be->dpcm[stream].state != SND_SOC_DPCM_STATE_START) && + (be->dpcm[stream].state != SND_SOC_DPCM_STATE_PAUSED)) continue; if (!snd_soc_dpcm_can_be_free_stop(fe, be, stream))